From: Petr Machata <petrm@nvidia.com>
To: David Ahern <dsahern@gmail.com>
Cc: Petr Machata <petrm@nvidia.com>, <netdev@vger.kernel.org>,
Ido Schimmel <idosch@nvidia.com>,
David Ahern <dsahern@kernel.org>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>
Subject: Re: [PATCH net-next 04/14] nexthop: Add netlink defines and enumerators for resilient NH groups
Date: Thu, 11 Mar 2021 17:00:28 +0100 [thread overview]
Message-ID: <87czw5istf.fsf@nvidia.com> (raw)
In-Reply-To: <33a20197-78b7-847d-7657-7a33ba9fef3b@gmail.com>
David Ahern <dsahern@gmail.com> writes:
> On 3/11/21 8:45 AM, Petr Machata wrote:
>>
>> David Ahern <dsahern@gmail.com> writes:
>>
>>> On 3/10/21 8:02 AM, Petr Machata wrote:
>>>> diff --git a/include/uapi/linux/nexthop.h b/include/uapi/linux/nexthop.h
>>>> index 2d4a1e784cf0..8efebf3cb9c7 100644
>>>> --- a/include/uapi/linux/nexthop.h
>>>> +++ b/include/uapi/linux/nexthop.h
>>>> @@ -22,6 +22,7 @@ struct nexthop_grp {
>>>>
>>>> enum {
>>>> NEXTHOP_GRP_TYPE_MPATH, /* default type if not specified */
>>>
>>> Update the above comment that it is for legacy, hash based multipath.
>>
>> Maybe this would make sense?
>>
>> NEXTHOP_GRP_TYPE_MPATH, /* hash-threshold nexthop group */
>>
>
> yes, the description is fine. keep the comment about 'default type'.
OK.
next prev parent reply other threads:[~2021-03-11 16:01 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-10 15:02 [PATCH net-next 00/14] nexthop: Resilient next-hop groups Petr Machata
2021-03-10 15:02 ` [PATCH net-next 01/14] nexthop: Pass nh_config to replace_nexthop() Petr Machata
2021-03-11 15:20 ` David Ahern
2021-03-10 15:02 ` [PATCH net-next 02/14] nexthop: __nh_notifier_single_info_init(): Make nh_info an argument Petr Machata
2021-03-11 15:21 ` David Ahern
2021-03-10 15:02 ` [PATCH net-next 03/14] nexthop: Add a dedicated flag for multipath next-hop groups Petr Machata
2021-03-11 15:28 ` David Ahern
2021-03-11 15:39 ` Petr Machata
2021-03-11 15:53 ` David Ahern
2021-03-11 16:57 ` Petr Machata
2021-03-10 15:02 ` [PATCH net-next 04/14] nexthop: Add netlink defines and enumerators for resilient NH groups Petr Machata
2021-03-11 15:34 ` David Ahern
2021-03-11 15:45 ` Petr Machata
2021-03-11 15:49 ` David Ahern
2021-03-11 16:00 ` Petr Machata [this message]
2021-03-10 15:02 ` [PATCH net-next 05/14] nexthop: Add implementation of resilient next-hop groups Petr Machata
2021-03-11 15:47 ` David Ahern
2021-03-10 15:02 ` [PATCH net-next 06/14] nexthop: Add data structures for resilient group notifications Petr Machata
2021-03-11 15:55 ` David Ahern
2021-03-10 15:02 ` [PATCH net-next 07/14] nexthop: Implement notifiers for resilient nexthop groups Petr Machata
2021-03-11 15:57 ` David Ahern
2021-03-10 15:02 ` [PATCH net-next 08/14] nexthop: Allow setting "offload" and "trap" indication of nexthop buckets Petr Machata
2021-03-11 16:03 ` David Ahern
2021-03-10 15:03 ` [PATCH net-next 09/14] nexthop: Allow reporting activity " Petr Machata
2021-03-11 16:04 ` David Ahern
2021-03-10 15:03 ` [PATCH net-next 10/14] nexthop: Add netlink handlers for resilient nexthop groups Petr Machata
2021-03-11 16:11 ` David Ahern
2021-03-10 15:03 ` [PATCH net-next 11/14] nexthop: Add netlink handlers for bucket dump Petr Machata
2021-03-11 16:17 ` David Ahern
2021-03-10 15:03 ` [PATCH net-next 12/14] nexthop: Add netlink handlers for bucket get Petr Machata
2021-03-11 16:19 ` David Ahern
2021-03-10 15:03 ` [PATCH net-next 13/14] nexthop: Notify userspace about bucket migrations Petr Machata
2021-03-11 16:20 ` David Ahern
2021-03-10 15:03 ` [PATCH net-next 14/14] nexthop: Enable resilient next-hop groups Petr Machata
2021-03-11 16:20 ` David Ahern
2021-03-11 16:22 ` [PATCH net-next 00/14] nexthop: Resilient " David Ahern
2021-03-11 17:18 ` Petr Machata
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87czw5istf.fsf@nvidia.com \
--to=petrm@nvidia.com \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=dsahern@kernel.org \
--cc=idosch@nvidia.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.