All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marc Zyngier <maz@kernel.org>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Michael Walle <michael@walle.cc>,
	linux-kernel@vger.kernel.org, tglx@linutronix.de
Subject: Re: [PATCH] irqdomain: remove debugfs_file from struct irq_domain
Date: Thu, 18 Feb 2021 09:08:12 +0000	[thread overview]
Message-ID: <87czwxpwub.wl-maz@kernel.org> (raw)
In-Reply-To: <YC4q5TRXWI8KZ8n9@kroah.com>

On Thu, 18 Feb 2021 08:52:53 +0000,
Greg KH <gregkh@linuxfoundation.org> wrote:

[...]

> Ok, how about this:
> 
> 
> diff --git a/fs/debugfs/inode.c b/fs/debugfs/inode.c
> index 2fcf66473436..86c7f0489620 100644
> --- a/fs/debugfs/inode.c
> +++ b/fs/debugfs/inode.c
> @@ -297,7 +297,7 @@ struct dentry *debugfs_lookup(const char *name, struct dentry *parent)
>  {
>  	struct dentry *dentry;
>  
> -	if (IS_ERR(parent))
> +	if (!debugfs_initialized() || IS_ERR_OR_NULL(name) || IS_ERR(parent))
>  		return NULL;
>  
>  	if (!parent)
> @@ -318,6 +318,9 @@ static struct dentry *start_creating(const char *name, struct dentry *parent)
>  	if (!(debugfs_allow & DEBUGFS_ALLOW_API))
>  		return ERR_PTR(-EPERM);
>  
> +	if (!debugfs_initialized())
> +		return ERR_PTR(-ENOENT);
> +
>  	pr_debug("creating file '%s'\n", name);
>  
>  	if (IS_ERR(parent))
> 

That one boots correctly in a guest.

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.

  parent reply	other threads:[~2021-02-18 10:19 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-16 14:36 [PATCH] irqdomain: remove debugfs_file from struct irq_domain Greg Kroah-Hartman
2021-02-16 15:36 ` [irqchip: irq/irqchip-next] irqdomain: Remove " irqchip-bot for Greg Kroah-Hartman
2021-02-17 19:57 ` [PATCH] irqdomain: remove " Michael Walle
2021-02-17 20:02   ` Marc Zyngier
2021-02-17 20:10     ` Michael Walle
2021-02-17 21:50       ` Marc Zyngier
2021-02-17 22:21         ` Michael Walle
2021-02-18  7:16           ` Greg KH
2021-02-18  7:31         ` Greg KH
2021-02-18  8:27           ` Michael Walle
2021-02-18  8:38             ` Greg KH
2021-02-18  8:47               ` Marc Zyngier
2021-02-18  8:54                 ` Greg KH
2021-02-18  9:04                   ` Marc Zyngier
2021-02-18  9:38                     ` Greg KH
2021-02-18 10:39                       ` Marc Zyngier
2021-02-18  8:52             ` Greg KH
2021-02-18  9:04               ` Michael Walle
2021-02-18  9:08               ` Marc Zyngier [this message]
2021-02-18  8:40   ` Greg KH
2021-02-18  8:46     ` Michael Walle
2021-02-18 11:43 ` [irqchip: irq/irqchip-next] irqdomain: Remove " irqchip-bot for Greg Kroah-Hartman
2021-03-08 20:25 ` irqchip-bot for Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87czwxpwub.wl-maz@kernel.org \
    --to=maz@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michael@walle.cc \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.