From: "Alex Bennée" <alex.bennee@linaro.org>
To: Richard Henderson <richard.henderson@linaro.org>
Cc: lvivier@redhat.com, alistair23@gmail.com, qemu-devel@nongnu.org
Subject: Re: [PATCH] tcg: Increase the static number of temporaries
Date: Thu, 21 Jan 2021 12:10:32 +0000 [thread overview]
Message-ID: <87czxytrr5.fsf@linaro.org> (raw)
In-Reply-To: <20210121025439.1120405-1-richard.henderson@linaro.org>
Richard Henderson <richard.henderson@linaro.org> writes:
> This isn't a total or permanent solution to the problem of running
> out of temporaries, but it puts off the issue for a bit.
>
> Make the assert in tcg_temp_alloc unconditional. If we do run out
> of temps, this can fail much later as a weird SIGSEGV, due to the
> buffer overrun of the temp array.
>
> Remove the inlines from tcg_temp_alloc and tcg_global_alloc.
>
> Buglink: https://bugs.launchpad.net/bugs/1912065
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
--
Alex Bennée
next prev parent reply other threads:[~2021-01-21 12:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-21 2:54 [PATCH] tcg: Increase the static number of temporaries Richard Henderson
2021-01-21 7:32 ` Philippe Mathieu-Daudé
2021-01-21 12:10 ` Alex Bennée [this message]
2021-01-23 16:19 ` Laurent Vivier
2021-01-23 19:36 ` Laurent Vivier
2021-01-23 22:18 ` Richard Henderson
2021-01-25 9:31 ` Alex Bennée
2021-01-25 11:00 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87czxytrr5.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=alistair23@gmail.com \
--cc=lvivier@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.