From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19008C388F9 for ; Tue, 27 Oct 2020 16:05:01 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 679B2206C1 for ; Tue, 27 Oct 2020 16:05:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="LmU5icgy" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 679B2206C1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:60894 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kXRT1-0000GX-F6 for qemu-devel@archiver.kernel.org; Tue, 27 Oct 2020 12:04:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43480) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kXRQ9-000528-7n for qemu-devel@nongnu.org; Tue, 27 Oct 2020 12:02:02 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:58217) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kXRQ5-0006LY-WD for qemu-devel@nongnu.org; Tue, 27 Oct 2020 12:02:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1603814516; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CGyKz1q260jjUHZCZDMxgBqJ/urEZDrXMjL4FT7Sg6U=; b=LmU5icgyYEDTnm5gaXxPy4E8BpqmZU+uk3aX6XfBLNELlNUypCU4GkfmREsJZwM1KxLqpL wfCOHPOOKrlDSUKHyZRF+IlacgJfSHroKnHzf9RuLTXfPRqiCshzbzYQsHhFjcT4V/y8TN WsSOvuEtR4lU7TPMrAKXj+Zyw9Fuehg= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-418-06U1hH20MIWK-HWsp4xCcw-1; Tue, 27 Oct 2020 12:01:54 -0400 X-MC-Unique: 06U1hH20MIWK-HWsp4xCcw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9BF2F8C8B82 for ; Tue, 27 Oct 2020 16:01:52 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-112-182.ams2.redhat.com [10.36.112.182]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 76D235C1BB; Tue, 27 Oct 2020 16:01:43 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id A5F60113865F; Tue, 27 Oct 2020 17:01:41 +0100 (CET) From: Markus Armbruster To: marcandre.lureau@redhat.com Subject: Re: [PATCH v2 3/3] console: make QMP/HMP screendump run in coroutine References: <20201027133602.3038018-1-marcandre.lureau@redhat.com> <20201027133602.3038018-4-marcandre.lureau@redhat.com> Date: Tue, 27 Oct 2020 17:01:41 +0100 In-Reply-To: <20201027133602.3038018-4-marcandre.lureau@redhat.com> (marcandre lureau's message of "Tue, 27 Oct 2020 17:36:02 +0400") Message-ID: <87d0134pzu.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=armbru@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=63.128.21.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/27 01:06:07 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , kraxel@redhat.com, qemu-devel@nongnu.org, Stefan Hajnoczi , "Dr. David Alan Gilbert" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" marcandre.lureau@redhat.com writes: > From: Marc-Andr=C3=A9 Lureau > > Thanks to the monitors' coroutine support (merge commit b7092cda1b3), > the screendump handler can trigger a graphic_hw_update(), yield and let > the main loop run until update is done. Then the handler is resumed, and > ppm_save() will write the screen image to disk in the coroutine context. > > The IO is still blocking though, as the file is set blocking so far, > this could be addressed by some future change (with other caveats). > > Related to: > https://bugzilla.redhat.com/show_bug.cgi?id=3D1230527 > > Signed-off-by: Marc-Andr=C3=A9 Lureau > Reviewed-by: Gerd Hoffmann Thanks for persevering! Reviewed-by: Markus Armbruster