From: "Alex Bennée" <alex.bennee@linaro.org>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: fam@euphon.net, berrange@redhat.com,
Juan Quintela <quintela@redhat.com>,
stefanb@linux.vnet.ibm.com, richard.henderson@linaro.org,
qemu-devel <qemu-devel@nongnu.org>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
"Emilio G. Cota" <cota@braap.org>,
stefanha@redhat.com, marcandre.lureau@redhat.com,
Paolo Bonzini <pbonzini@redhat.com>,
aurelien@aurel32.net
Subject: Re: [PATCH v1 8/8] migration: use pstrcpy to copy run state
Date: Fri, 04 Sep 2020 11:03:51 +0100 [thread overview]
Message-ID: <87d0315054.fsf@linaro.org> (raw)
In-Reply-To: <8cddf56b-4115-579d-d4eb-524d2cad1385@redhat.com>
Philippe Mathieu-Daudé <philmd@redhat.com> writes:
> On 9/3/20 2:13 PM, Paolo Bonzini wrote:
>> Il gio 3 set 2020, 13:21 Alex Bennée <alex.bennee@linaro.org
>> <mailto:alex.bennee@linaro.org>> ha scritto:
>>
>> The gcov build triggered:
>>
>> ../../migration/global_state.c:47:5: error: ‘strncpy’ specified
>> bound 100 equals destination size [-Werror=stringop-truncation]
>> strncpy((char *)global_state.runstate
>>
>> As we shouldn't be using strncpy anyway lets use the suggested
>> pstrcpy.
>>
>>
>> This is wrong, we want the all-zeros behavior of strncpy that pstrcpy lacks.
>
> FWIW links to previous discussions:
> https://www.mail-archive.com/qemu-devel@nongnu.org/msg584216.html
Hmm I wonder why gprof interfered with the assert. Either way I'll drop
the patch.
>
>>
>> Paolo
--
Alex Bennée
next prev parent reply other threads:[~2020-09-04 10:04 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-03 11:20 [PATCH v1 0/8] some testing and CI updates (re-greening) Alex Bennée
2020-09-03 11:21 ` [PATCH v1 1/8] CODING_STYLE.rst: flesh out our naming conventions Alex Bennée
2020-09-03 12:24 ` Paolo Bonzini
2020-09-03 11:21 ` [PATCH v1 2/8] crypto: fix build with gcrypt enabled Alex Bennée
2020-09-03 19:02 ` Richard Henderson
2020-09-03 11:21 ` [PATCH v1 3/8] tests/docker: add python3-setuptools the docker images Alex Bennée
2020-09-03 11:40 ` Thomas Huth
2020-09-03 19:30 ` Philippe Mathieu-Daudé
2020-09-03 11:21 ` [PATCH v1 4/8] usb-host: restrict workaround to new libusb versions Alex Bennée
2020-09-03 11:21 ` [PATCH v1 5/8] qemu-iotests: move check-block back to Makefiles Alex Bennée
2020-09-03 11:21 ` [PATCH v1 6/8] tests/meson.build: fp tests don't need CONFIG_TCG Alex Bennée
2020-09-03 12:10 ` Paolo Bonzini
2020-09-07 9:11 ` Alex Bennée
2020-09-07 9:41 ` Philippe Mathieu-Daudé
2020-09-07 9:55 ` Alex Bennée
2020-09-07 10:08 ` Philippe Mathieu-Daudé
2020-09-03 11:21 ` [PATCH v1 7/8] target/mips: simplify gen_compute_imm_branch logic Alex Bennée
2020-09-03 17:16 ` Richard Henderson
2020-09-03 11:21 ` [PATCH v1 8/8] migration: use pstrcpy to copy run state Alex Bennée
2020-09-03 12:13 ` Paolo Bonzini
2020-09-03 19:43 ` Philippe Mathieu-Daudé
2020-09-04 10:03 ` Alex Bennée [this message]
2020-09-03 11:34 ` [PATCH v1 0/8] some testing and CI updates (re-greening) Daniel P. Berrangé
2020-09-03 14:17 ` Thomas Huth
2020-09-03 14:38 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d0315054.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=aurelien@aurel32.net \
--cc=berrange@redhat.com \
--cc=cota@braap.org \
--cc=dgilbert@redhat.com \
--cc=fam@euphon.net \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=richard.henderson@linaro.org \
--cc=stefanb@linux.vnet.ibm.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.