From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0126C433DF for ; Wed, 29 Jul 2020 12:32:55 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7A64E20809 for ; Wed, 29 Jul 2020 12:32:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="jMf6GO/z" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7A64E20809 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:55874 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k0lGQ-0006H4-Oo for qemu-devel@archiver.kernel.org; Wed, 29 Jul 2020 08:32:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56498) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k0lFq-0005rz-GN for qemu-devel@nongnu.org; Wed, 29 Jul 2020 08:32:18 -0400 Received: from us-smtp-delivery-74.mimecast.com ([63.128.21.74]:41307) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1k0lFm-0001m1-3A for qemu-devel@nongnu.org; Wed, 29 Jul 2020 08:32:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1596025931; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8/Lmr7pOXL80tBhsqctn2v+R5zGzuYOJ6iBLSWrNCEA=; b=jMf6GO/zB6v1Ip4eOXC1k/pBcW3zLkOpItwSVOymeIbOJTuC2c9Ovidhtxj8MUFv3bJv9p u2jRIMYvZyu2t8BIt+EmchTDwUCZLfdrz2FVyipBOMvU4JbiEWeGIoUUXcDL4nTY8sRRVS 5pLwQbs2N186pquHzQV+gj8rxv08DAE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-458-iOxb7m4PN4m37_ijry-MnQ-1; Wed, 29 Jul 2020 08:32:09 -0400 X-MC-Unique: iOxb7m4PN4m37_ijry-MnQ-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D0EF4193F562; Wed, 29 Jul 2020 12:32:08 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-112-143.ams2.redhat.com [10.36.112.143]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 89AF46932E; Wed, 29 Jul 2020 12:32:08 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 1A1311132FD2; Wed, 29 Jul 2020 14:32:07 +0200 (CEST) From: Markus Armbruster To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Subject: Re: [PATCH-for-5.2 v4] hw/core/qdev: Increase qdev_realize() kindness References: <20200727175112.6820-1-f4bug@amsat.org> <87d04gf5i4.fsf@dusky.pond.sub.org> <87r1suahxu.fsf@dusky.pond.sub.org> Date: Wed, 29 Jul 2020 14:32:07 +0200 In-Reply-To: ("Philippe =?utf-8?Q?Mathieu-Daud=C3=A9=22's?= message of "Wed, 29 Jul 2020 14:02:22 +0200") Message-ID: <87d04e7b94.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=63.128.21.74; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-74.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/29 01:09:48 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org, Paolo Bonzini , Richard Henderson , "Daniel P. =?utf-8?Q?Berrang=C3=A9?=" , Eduardo Habkost Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Philippe Mathieu-Daud=C3=A9 writes: > On 7/29/20 9:39 AM, Markus Armbruster wrote: >> Paolo Bonzini writes: >>=20 >>> On 28/07/20 09:44, Markus Armbruster wrote: >>>>> - assert(!DEVICE_GET_CLASS(dev)->bus_type); >>>>> + } else if (DEVICE_GET_CLASS(dev)->bus_type) { >>>>> + error_setg(errp, "Unexpected bus '%s' for bus-less device '%= s'", >>>>> + DEVICE_GET_CLASS(dev)->bus_type, >>>>> + object_get_typename(OBJECT(dev))); >>>>> + return false; >>>>> } >>>>> =20 >>>>> object_property_set_bool(OBJECT(dev), true, "realized", &err); >>>> Objection. This turns an abort into something else unless the caller >>>> passes &error_abort. The caller in your commit message's example does= , >>>> others don't. >>>> >>>> Keep the unconditional abort, please. Feel free to print something ki= nd >>>> right before. I doubt it's all that useful, as I believe whoever gets >>>> to fix the bug will have to figure out the code anyway, but I could be >>>> wrong. >>>> >>> >>> This was my request, actually. We have an Error**, we should use it in >>> case this code is reached via device_add. >>=20 >> That's not actually possible. > > I agree this condition is not possible in current mainstream. > > What I'm working on is: > > qmp command that: > - create a SDCard or FloppyDisk medium > - eventually link a block driver to it > - insert the medium into a slot > > then another qmp command that > - eject the medium > - unlink the block driver > - destroy the medium > > second step is a command that takes as argument > (block driver, bus endpoint) and automatically > creates the envelope media and insert it to the bus. If this makes the error possible, then your code fails to establish qdev_realize()'s precondition, and therefore needs fixing. Could a combination of existing commands get the job done?