All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: qianjun.kernel@gmail.com, peterz@infradead.org, will@kernel.org,
	luto@kernel.org, urezki@gmail.com, linux-kernel@vger.kernel.org
Cc: laoar.shao@gmail.com, jun qian <qianjun.kernel@gmail.com>
Subject: Re: [PATCH V3] Softirq:avoid large sched delay from the pending softirqs
Date: Thu, 23 Jul 2020 15:41:50 +0200	[thread overview]
Message-ID: <87d04mxs9t.fsf@nanos.tec.linutronix.de> (raw)
In-Reply-To: <1595480041-10597-1-git-send-email-qianjun.kernel@gmail.com>

qianjun.kernel@gmail.com writes:
> From: jun qian <qianjun.kernel@gmail.com>
> +		/*
> +		 * the softirq's action has been running for too much time
> +		 * so it may need to wakeup the ksoftirqd
> +		 */
> +		if (need_resched() && ktime_get() > end)
> +			break;

As per my reply on V2 this is leaking non handled pending bits. If you
do a V4, can you please use sched_clock() instead of ktime_get()?

Thanks,

        tglx

  reply	other threads:[~2020-07-23 13:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-23  4:54 [PATCH V3] Softirq:avoid large sched delay from the pending softirqs qianjun.kernel
2020-07-23 13:41 ` Thomas Gleixner [this message]
2020-07-23 14:11   ` jun qian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d04mxs9t.fsf@nanos.tec.linutronix.de \
    --to=tglx@linutronix.de \
    --cc=laoar.shao@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=peterz@infradead.org \
    --cc=qianjun.kernel@gmail.com \
    --cc=urezki@gmail.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.