From: Markus Armbruster <armbru@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>,
Cornelia Huck <cohuck@redhat.com>,
Halil Pasic <pasic@linux.ibm.com>,
Christian Borntraeger <borntraeger@de.ibm.com>
Cc: qemu-devel@nongnu.org
Subject: Intended purpose of virtio-rng's QOM link "rng"?
Date: Mon, 20 Jul 2020 17:07:08 +0200 [thread overview]
Message-ID: <87d04qfco3.fsf@dusky.pond.sub.org> (raw)
What is the intended purpose of object_property_set_link() in
static void virtio_rng_pci_realize(VirtIOPCIProxy *vpci_dev, Error **errp)
{
VirtIORngPCI *vrng = VIRTIO_RNG_PCI(vpci_dev);
DeviceState *vdev = DEVICE(&vrng->vdev);
if (!qdev_realize(vdev, BUS(&vpci_dev->bus), errp)) {
return;
}
object_property_set_link(OBJECT(vrng), "rng", OBJECT(vrng->vdev.conf.rng),
NULL);
}
?
I'm asking because the function *always* fails. I believe it's been
failing for years.
Similar code in the CCW buddy. Also virtio-crypto-pci and
virtio-crypto-ccw link "cryptodev".
I tried moving it before qdev_realize(), where it doesn't fail. But
then *I* fail, namely at finding any effect in QOM.
If it's really useless, I'll send a patch to drop it.
If it has a use, tell me more, so I can test my patch to move it.
next reply other threads:[~2020-07-20 15:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-20 15:07 Markus Armbruster [this message]
2020-07-20 15:56 ` Intended purpose of virtio-rng's QOM link "rng"? Michael S. Tsirkin
2020-07-21 7:05 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d04qfco3.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=mst@redhat.com \
--cc=pasic@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.