From: Kalle Valo <kvalo@codeaurora.org>
To: Kai-Heng Feng <kai.heng.feng@canonical.com>
Cc: Tony Chuang <yhchuang@realtek.com>,
"David S. Miller" <davem@davemloft.net>,
"open list\:REALTEK WIRELESS DRIVER \(rtw88\)"
<linux-wireless@vger.kernel.org>,
"open list\:NETWORKING DRIVERS" <netdev@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] rtw88: Use udelay instead of usleep in atomic context
Date: Thu, 23 Apr 2020 10:01:03 +0300 [thread overview]
Message-ID: <87d07yn0sw.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <D2ACB475-AE1A-41D1-BEB9-1FC30DA13AE8@canonical.com> (Kai-Heng Feng's message of "Thu, 23 Apr 2020 14:53:18 +0800")
Kai-Heng Feng <kai.heng.feng@canonical.com> writes:
>> On Apr 23, 2020, at 14:49, Kalle Valo <kvalo@codeaurora.org> wrote:
>>
>> Kai-Heng Feng <kai.heng.feng@canonical.com> writes:
>>
>>> It's incorrect to use usleep in atomic context.
>>>
>>> Switch to a macro which uses udelay instead of usleep to prevent the issue.
>>>
>>> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
>>
>> This fixes a regression, right? So there should be a Fixes line.
>
> Yes, but the regression commit isn't in Linus' tree, so the sha1 may change.
No, the commit id won't change after I have commited the patch. I don't
rebase my trees.
--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2020-04-23 7:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-23 6:38 [PATCH 1/2] iopoll: Introduce read_poll_timeout_atomic macro Kai-Heng Feng
2020-04-23 6:38 ` [PATCH 2/2] rtw88: Use udelay instead of usleep in atomic context Kai-Heng Feng
2020-04-23 6:49 ` Kalle Valo
2020-04-23 6:53 ` Kai-Heng Feng
2020-04-23 7:01 ` Kalle Valo [this message]
2020-04-23 7:30 ` [PATCH v2 " Kai-Heng Feng
2020-04-23 16:07 ` Kalle Valo
2020-05-06 8:31 ` Kalle Valo
2020-04-23 6:47 ` [PATCH 1/2] iopoll: Introduce read_poll_timeout_atomic macro Kalle Valo
2020-04-23 10:23 ` Mark Brown
2020-04-23 11:27 ` Kalle Valo
2020-04-23 14:47 ` Mark Brown
2020-04-23 15:13 ` Kalle Valo
2020-04-24 18:49 ` [PATCH v2 " Kai-Heng Feng
2020-05-06 8:30 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d07yn0sw.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=davem@davemloft.net \
--cc=kai.heng.feng@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yhchuang@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.