From: Juan Quintela <quintela@redhat.com>
To: Yuri Benditovich <yuri.benditovich@daynix.com>
Cc: yan@daynix.com, jasowang@redhat.com, qemu-devel@nongnu.org,
dgilbert@redhat.com, mst@redhat.com
Subject: Re: [PATCH v5 6/7] vmstate.h: provide VMSTATE_VARRAY_UINT16_ALLOC macro
Date: Wed, 18 Mar 2020 14:02:37 +0100 [thread overview]
Message-ID: <87d099g6j6.fsf@secure.laptop> (raw)
In-Reply-To: <20200318091525.27044-7-yuri.benditovich@daynix.com> (Yuri Benditovich's message of "Wed, 18 Mar 2020 11:15:24 +0200")
Yuri Benditovich <yuri.benditovich@daynix.com> wrote:
> Similar to VMSTATE_VARRAY_UINT32_ALLOC, but the size is
> 16-bit field.
>
> Signed-off-by: Yuri Benditovich <yuri.benditovich@daynix.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Same caveat about attribution to MST.
Once told tha, I don't understand why you are using a unit16_t.
You define indirections_len as:
+ uint16_t indirections_len;
But its maximum value right now is:
+#define VIRTIO_NET_RSS_MAX_TABLE_LEN 128
So, are we planning to increase that value in the next future, or we
just want to give enough space?
Later, Juan.
next prev parent reply other threads:[~2020-03-18 13:04 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-18 9:15 [PATCH v5 0/7] reference implementation of RSS and hash report Yuri Benditovich
2020-03-18 9:15 ` [PATCH v5 1/7] virtio-net: introduce RSS and hash report features Yuri Benditovich
2020-03-18 9:15 ` [PATCH v5 2/7] virtio-net: implement RSS configuration command Yuri Benditovich
2020-03-18 9:15 ` [PATCH v5 3/7] virtio-net: implement RX RSS processing Yuri Benditovich
2020-03-18 9:15 ` [PATCH v5 4/7] tap: allow extended virtio header with hash info Yuri Benditovich
2020-03-18 9:15 ` [PATCH v5 5/7] virtio-net: reference implementation of hash report Yuri Benditovich
2020-03-18 9:15 ` [PATCH v5 6/7] vmstate.h: provide VMSTATE_VARRAY_UINT16_ALLOC macro Yuri Benditovich
2020-03-18 9:42 ` Michael S. Tsirkin
2020-03-19 17:12 ` Yuri Benditovich
2020-03-19 17:55 ` Michael S. Tsirkin
2020-03-18 11:00 ` Dr. David Alan Gilbert
2020-03-18 13:02 ` Juan Quintela [this message]
2020-03-18 15:19 ` Michael S. Tsirkin
2020-03-18 9:15 ` [PATCH v5 7/7] virtio-net: add migration support for RSS and hash report Yuri Benditovich
2020-03-18 10:48 ` Dr. David Alan Gilbert
2020-03-19 17:19 ` Yuri Benditovich
2020-03-19 17:23 ` Michael S. Tsirkin
2020-03-19 17:58 ` Juan Quintela
2020-03-19 18:09 ` Dr. David Alan Gilbert
2020-03-18 9:43 ` [PATCH v5 0/7] reference implementation of " Michael S. Tsirkin
2020-03-18 9:53 ` no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d099g6j6.fsf@secure.laptop \
--to=quintela@redhat.com \
--cc=dgilbert@redhat.com \
--cc=jasowang@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=yan@daynix.com \
--cc=yuri.benditovich@daynix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.