From: Markus Armbruster <armbru@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
qemu-devel@nongnu.org, Kashyap Chamarthy <kchamart@redhat.com>
Subject: Re: [PATCH] softmmu/vl.c: Handle '-cpu help' and '-device help' before 'no default machine'
Date: Sat, 14 Mar 2020 12:36:53 +0100 [thread overview]
Message-ID: <87d09f9nhm.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <20200313172447.15471-1-peter.maydell@linaro.org> (Peter Maydell's message of "Fri, 13 Mar 2020 17:24:47 +0000")
Peter Maydell <peter.maydell@linaro.org> writes:
> Currently if you try to ask for the list of CPUs for a target
> architecture which does not specify a default machine type
> you just get an error:
>
> $ qemu-system-arm -cpu help
> qemu-system-arm: No machine specified, and there is no default
> Use -machine help to list supported machines
>
> Since the list of CPUs doesn't depend on the machine, this is
> unnecessarily unhelpful. "-device help" has a similar problem.
>
> Move the checks for "did the user ask for -cpu help or -device help"
> up so they precede the select_machine() call which checks that the
> user specified a valid machine type.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> This has been on-and-off irritating me for years, and it's
> embarrassing how simple the fix turns out to be...
Same here. The patch works as advertized, thus:
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Can you offer a completeness argument? We call is_help_option() and
qemu_opt_has_help_opt() from quite a few places.
next prev parent reply other threads:[~2020-03-14 11:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-13 17:24 [PATCH] softmmu/vl.c: Handle '-cpu help' and '-device help' before 'no default machine' Peter Maydell
2020-03-14 11:36 ` Markus Armbruster [this message]
2020-03-16 11:00 ` Kashyap Chamarthy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d09f9nhm.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=kchamart@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.