From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD2F3C35641 for ; Fri, 21 Feb 2020 07:39:02 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ADFA520656 for ; Fri, 21 Feb 2020 07:39:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="MXGZEvzV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ADFA520656 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1j52t8-0006Tp-NV; Fri, 21 Feb 2020 07:38:18 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1j52t6-0006Tk-Vo for xen-devel@lists.xenproject.org; Fri, 21 Feb 2020 07:38:17 +0000 X-Inumbo-ID: 1e119dd4-547d-11ea-85f1-12813bfff9fa Received: from us-smtp-1.mimecast.com (unknown [207.211.31.120]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTP id 1e119dd4-547d-11ea-85f1-12813bfff9fa; Fri, 21 Feb 2020 07:38:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582270693; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ivlYN+I1MiRVaAJX3T1ltBTxmac4Df8VdwXtfcMODnw=; b=MXGZEvzVqU722XvTc9HGMUDKs4qnkh5CbN60sljRT/5Gqe5za9IDfwhgnBI5hN2/hMGC/o aTnMrM3xne28BSHigSWekchu9qjdo30zTSiJAtUr5dz8ymxD75nFAJIy85KScVCUbwY/bI /UaYqFNGKbMh/WLe9DRaj4IYARfQWVQ= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-63-Uj8oUS1wOMeD0qif6IMjEA-1; Fri, 21 Feb 2020 02:38:11 -0500 X-MC-Unique: Uj8oUS1wOMeD0qif6IMjEA-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A2DF88018C0; Fri, 21 Feb 2020 07:38:09 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-116-129.ams2.redhat.com [10.36.116.129]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9B9EF388; Fri, 21 Feb 2020 07:38:03 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 12D6D11386A6; Fri, 21 Feb 2020 08:38:02 +0100 (CET) From: Markus Armbruster To: Vladimir Sementsov-Ogievskiy References: <20200131130118.1716-1-vsementsov@virtuozzo.com> <20200131130118.1716-2-vsementsov@virtuozzo.com> Date: Fri, 21 Feb 2020 08:38:02 +0100 In-Reply-To: <20200131130118.1716-2-vsementsov@virtuozzo.com> (Vladimir Sementsov-Ogievskiy's message of "Fri, 31 Jan 2020 16:01:08 +0300") Message-ID: <87d0a88k6d.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Subject: Re: [Xen-devel] [PATCH v7 01/11] qapi/error: add (Error **errp) cleaning APIs X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Stefano Stabellini , Michael Roth , qemu-block@nongnu.org, Paul Durrant , Laszlo Ersek , qemu-devel@nongnu.org, armbru@redhat.com, Greg Kurz , Gerd Hoffmann , Stefan Hajnoczi , Anthony Perard , xen-devel@lists.xenproject.org, Max Reitz , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Stefan Berger Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" VmxhZGltaXIgU2VtZW50c292LU9naWV2c2tpeSA8dnNlbWVudHNvdkB2aXJ0dW96em8uY29tPiB3 cml0ZXM6Cgo+IEFkZCBmdW5jdGlvbnMgdG8gY2xlYW4gRXJyb3IgKiplcnJwOiBjYWxsIGNvcnJl c3BvbmRpbmcgRXJyb3IgKmVycgo+IGNsZWFuaW5nIGZ1bmN0aW9uIGFuIHNldCBwb2ludGVyIHRv IE5VTEwuCj4KPiBOZXcgZnVuY3Rpb25zOgo+ICAgZXJyb3JfZnJlZV9lcnJwCj4gICBlcnJvcl9y ZXBvcnRfZXJycAo+ICAgd2Fybl9yZXBvcnRfZXJycAo+Cj4gU2lnbmVkLW9mZi1ieTogVmxhZGlt aXIgU2VtZW50c292LU9naWV2c2tpeSA8dnNlbWVudHNvdkB2aXJ0dW96em8uY29tPgo+IFJldmll d2VkLWJ5OiBHcmVnIEt1cnogPGdyb3VnQGthb2Qub3JnPgo+IFJldmlld2VkLWJ5OiBFcmljIEJs YWtlIDxlYmxha2VAcmVkaGF0LmNvbT4KPiAtLS0KPgo+IENDOiBFcmljIEJsYWtlIDxlYmxha2VA cmVkaGF0LmNvbT4KPiBDQzogS2V2aW4gV29sZiA8a3dvbGZAcmVkaGF0LmNvbT4KPiBDQzogTWF4 IFJlaXR6IDxtcmVpdHpAcmVkaGF0LmNvbT4KPiBDQzogR3JlZyBLdXJ6IDxncm91Z0BrYW9kLm9y Zz4KPiBDQzogU3RlZmFubyBTdGFiZWxsaW5pIDxzc3RhYmVsbGluaUBrZXJuZWwub3JnPgo+IEND OiBBbnRob255IFBlcmFyZCA8YW50aG9ueS5wZXJhcmRAY2l0cml4LmNvbT4KPiBDQzogUGF1bCBE dXJyYW50IDxwYXVsQHhlbi5vcmc+Cj4gQ0M6IFN0ZWZhbiBIYWpub2N6aSA8c3RlZmFuaGFAcmVk aGF0LmNvbT4KPiBDQzogIlBoaWxpcHBlIE1hdGhpZXUtRGF1ZMOpIiA8cGhpbG1kQHJlZGhhdC5j b20+Cj4gQ0M6IExhc3psbyBFcnNlayA8bGVyc2VrQHJlZGhhdC5jb20+Cj4gQ0M6IEdlcmQgSG9m Zm1hbm4gPGtyYXhlbEByZWRoYXQuY29tPgo+IENDOiBTdGVmYW4gQmVyZ2VyIDxzdGVmYW5iQGxp bnV4LmlibS5jb20+Cj4gQ0M6IE1hcmt1cyBBcm1icnVzdGVyIDxhcm1icnVAcmVkaGF0LmNvbT4K PiBDQzogTWljaGFlbCBSb3RoIDxtZHJvdGhAbGludXgudm5ldC5pYm0uY29tPgo+IENDOiBxZW11 LWJsb2NrQG5vbmdudS5vcmcKPiBDQzogeGVuLWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnCj4K PiAgaW5jbHVkZS9xYXBpL2Vycm9yLmggfCAyNiArKysrKysrKysrKysrKysrKysrKysrKysrKwo+ ICAxIGZpbGUgY2hhbmdlZCwgMjYgaW5zZXJ0aW9ucygrKQo+Cj4gZGlmZiAtLWdpdCBhL2luY2x1 ZGUvcWFwaS9lcnJvci5oIGIvaW5jbHVkZS9xYXBpL2Vycm9yLmgKPiBpbmRleCBhZDViNmU4OTZk Li5kMzQ5ODcxNDhkIDEwMDY0NAo+IC0tLSBhL2luY2x1ZGUvcWFwaS9lcnJvci5oCj4gKysrIGIv aW5jbHVkZS9xYXBpL2Vycm9yLmgKPiBAQCAtMzA5LDYgKzMwOSwzMiBAQCB2b2lkIHdhcm5fcmVw b3J0Zl9lcnIoRXJyb3IgKmVyciwgY29uc3QgY2hhciAqZm10LCAuLi4pCj4gIHZvaWQgZXJyb3Jf cmVwb3J0Zl9lcnIoRXJyb3IgKmVyciwgY29uc3QgY2hhciAqZm10LCAuLi4pCj4gICAgICBHQ0Nf Rk1UX0FUVFIoMiwgMyk7Cj4gIAo+ICsvKgo+ICsgKiBGdW5jdGlvbnMgdG8gY2xlYW4gRXJyb3Ig KiplcnJwOiBjYWxsIGNvcnJlc3BvbmRpbmcgRXJyb3IgKmVyciBjbGVhbmluZwo+ICsgKiBmdW5j dGlvbiwgdGhlbiBzZXQgcG9pbnRlciB0byBOVUxMLgo+ICsgKi8KPiArc3RhdGljIGlubGluZSB2 b2lkIGVycm9yX2ZyZWVfZXJycChFcnJvciAqKmVycnApCj4gK3sKPiArICAgIGFzc2VydChlcnJw ICYmICplcnJwKTsKPiArICAgIGVycm9yX2ZyZWUoKmVycnApOwo+ICsgICAgKmVycnAgPSBOVUxM Owo+ICt9Cj4gKwo+ICtzdGF0aWMgaW5saW5lIHZvaWQgZXJyb3JfcmVwb3J0X2VycnAoRXJyb3Ig KiplcnJwKQo+ICt7Cj4gKyAgICBhc3NlcnQoZXJycCAmJiAqZXJycCk7Cj4gKyAgICBlcnJvcl9y ZXBvcnRfZXJyKCplcnJwKTsKPiArICAgICplcnJwID0gTlVMTDsKPiArfQo+ICsKPiArc3RhdGlj IGlubGluZSB2b2lkIHdhcm5fcmVwb3J0X2VycnAoRXJyb3IgKiplcnJwKQo+ICt7Cj4gKyAgICBh c3NlcnQoZXJycCAmJiAqZXJycCk7Cj4gKyAgICB3YXJuX3JlcG9ydF9lcnIoKmVycnApOwo+ICsg ICAgKmVycnAgPSBOVUxMOwo+ICt9Cj4gKwo+ICsKPiAgLyoKPiAgICogSnVzdCBsaWtlIGVycm9y X3NldGcoKSwgZXhjZXB0IHlvdSBnZXQgdG8gc3BlY2lmeSB0aGUgZXJyb3IgY2xhc3MuCj4gICAq IE5vdGU6IHVzZSBvZiBlcnJvciBjbGFzc2VzIG90aGVyIHRoYW4gRVJST1JfQ0xBU1NfR0VORVJJ Q19FUlJPUiBpcwoKVGhlc2UgYXBwZWFyIHRvIGJlIHVudXNlZCBhcGFydCBmcm9tIHRoZSBDb2Nj aW5lbGxlIHNjcmlwdCBpbiBQQVRDSCAwMy4KClRoZXkgYXJlIHVzZWQgaW4gdGhlIGZ1bGwgIltS RkMgdjUgMDAwLzEyNl0gZXJyb3I6IGF1dG8gcHJvcGFnYXRlZApsb2NhbF9lcnIiIHNlcmllcy4g IE9wdGlvbnM6CgoxLiBQaWNrIGEgZmV3IG1vcmUgcGF0Y2hlcyBpbnRvIHRoaXMgcGFydCBJIHNl cmllcywgc28gdGhlc2UgZ3V5cyBjb21lCiAgIHdpdGggdXNlcnMuCgoyLiBQdW50IHRoaXMgcGF0 Y2ggdG8gdGhlIGZpcnN0IHBhcnQgdGhhdCBoYXMgdXNlcnMsIGFsb25nIHdpdGggdGhlCiAgIHBh cnQgb2YgdGhlIENvY2NpbmVsbGUgc2NyaXB0IHRoYXQgZGVhbHMgd2l0aCB0aGVtLgoKMy4gRG8g bm90aGluZzogYWNjZXB0IHRoZSBmdW5jdGlvbnMgd2l0aG91dCB1c2Vycy4KCkkgaGFiaXR1YWxs eSBkaXNsaWtlIDMuLCBidXQgcmV2aWV3aW5nIHRoZSByZXN0IG9mIHRoaXMgc2VyaWVzIG1pZ2h0 Cm1ha2UgbWUgb3ZlcnJpZGUgdGhhdCBkaXNsaWtlLgoKCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fClhlbi1kZXZlbCBtYWlsaW5nIGxpc3QKWGVuLWRldmVs QGxpc3RzLnhlbnByb2plY3Qub3JnCmh0dHBzOi8vbGlzdHMueGVucHJvamVjdC5vcmcvbWFpbG1h bi9saXN0aW5mby94ZW4tZGV2ZWw= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95EC0C35640 for ; Fri, 21 Feb 2020 07:38:59 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5FA6C20656 for ; Fri, 21 Feb 2020 07:38:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="dE8IUt6G" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5FA6C20656 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:53184 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j52tm-0007iQ-JN for qemu-devel@archiver.kernel.org; Fri, 21 Feb 2020 02:38:58 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:43989) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j52t7-0007Cg-HF for qemu-devel@nongnu.org; Fri, 21 Feb 2020 02:38:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j52t6-0007R4-9L for qemu-devel@nongnu.org; Fri, 21 Feb 2020 02:38:17 -0500 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:55543 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j52t6-0007NZ-5h for qemu-devel@nongnu.org; Fri, 21 Feb 2020 02:38:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582270695; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ivlYN+I1MiRVaAJX3T1ltBTxmac4Df8VdwXtfcMODnw=; b=dE8IUt6GAbMgFh7ay9eCIIEC+89He5yXdB3yTVpr47UwS2STt6wpiCVoE4AptsKbSV0PCa /PsUvc5zNXprQkZa6/PVVzssRKzJF7Ly1JB69EKjN/M0lnQ1PZbUHWfGbpj+IWULokpcqs F5ak5KUHo75WY5zHq1Lm7TpeAn/ED9E= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-63-Uj8oUS1wOMeD0qif6IMjEA-1; Fri, 21 Feb 2020 02:38:11 -0500 X-MC-Unique: Uj8oUS1wOMeD0qif6IMjEA-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A2DF88018C0; Fri, 21 Feb 2020 07:38:09 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-116-129.ams2.redhat.com [10.36.116.129]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9B9EF388; Fri, 21 Feb 2020 07:38:03 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 12D6D11386A6; Fri, 21 Feb 2020 08:38:02 +0100 (CET) From: Markus Armbruster To: Vladimir Sementsov-Ogievskiy Subject: Re: [PATCH v7 01/11] qapi/error: add (Error **errp) cleaning APIs References: <20200131130118.1716-1-vsementsov@virtuozzo.com> <20200131130118.1716-2-vsementsov@virtuozzo.com> Date: Fri, 21 Feb 2020 08:38:02 +0100 In-Reply-To: <20200131130118.1716-2-vsementsov@virtuozzo.com> (Vladimir Sementsov-Ogievskiy's message of "Fri, 31 Jan 2020 16:01:08 +0300") Message-ID: <87d0a88k6d.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.81 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Stefano Stabellini , Michael Roth , qemu-block@nongnu.org, Paul Durrant , Laszlo Ersek , qemu-devel@nongnu.org, armbru@redhat.com, Greg Kurz , Gerd Hoffmann , Stefan Hajnoczi , Anthony Perard , xen-devel@lists.xenproject.org, Max Reitz , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Stefan Berger Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Vladimir Sementsov-Ogievskiy writes: > Add functions to clean Error **errp: call corresponding Error *err > cleaning function an set pointer to NULL. > > New functions: > error_free_errp > error_report_errp > warn_report_errp > > Signed-off-by: Vladimir Sementsov-Ogievskiy > Reviewed-by: Greg Kurz > Reviewed-by: Eric Blake > --- > > CC: Eric Blake > CC: Kevin Wolf > CC: Max Reitz > CC: Greg Kurz > CC: Stefano Stabellini > CC: Anthony Perard > CC: Paul Durrant > CC: Stefan Hajnoczi > CC: "Philippe Mathieu-Daud=C3=A9" > CC: Laszlo Ersek > CC: Gerd Hoffmann > CC: Stefan Berger > CC: Markus Armbruster > CC: Michael Roth > CC: qemu-block@nongnu.org > CC: xen-devel@lists.xenproject.org > > include/qapi/error.h | 26 ++++++++++++++++++++++++++ > 1 file changed, 26 insertions(+) > > diff --git a/include/qapi/error.h b/include/qapi/error.h > index ad5b6e896d..d34987148d 100644 > --- a/include/qapi/error.h > +++ b/include/qapi/error.h > @@ -309,6 +309,32 @@ void warn_reportf_err(Error *err, const char *fmt, .= ..) > void error_reportf_err(Error *err, const char *fmt, ...) > GCC_FMT_ATTR(2, 3); > =20 > +/* > + * Functions to clean Error **errp: call corresponding Error *err cleani= ng > + * function, then set pointer to NULL. > + */ > +static inline void error_free_errp(Error **errp) > +{ > + assert(errp && *errp); > + error_free(*errp); > + *errp =3D NULL; > +} > + > +static inline void error_report_errp(Error **errp) > +{ > + assert(errp && *errp); > + error_report_err(*errp); > + *errp =3D NULL; > +} > + > +static inline void warn_report_errp(Error **errp) > +{ > + assert(errp && *errp); > + warn_report_err(*errp); > + *errp =3D NULL; > +} > + > + > /* > * Just like error_setg(), except you get to specify the error class. > * Note: use of error classes other than ERROR_CLASS_GENERIC_ERROR is These appear to be unused apart from the Coccinelle script in PATCH 03. They are used in the full "[RFC v5 000/126] error: auto propagated local_err" series. Options: 1. Pick a few more patches into this part I series, so these guys come with users. 2. Punt this patch to the first part that has users, along with the part of the Coccinelle script that deals with them. 3. Do nothing: accept the functions without users. I habitually dislike 3., but reviewing the rest of this series might make me override that dislike.