From: Thomas Gleixner <tglx@linutronix.de>
To: Evan Green <evgreen@chromium.org>
Cc: Rajat Jain <rajatja@google.com>,
Bjorn Helgaas <bhelgaas@google.com>,
linux-pci <linux-pci@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
x86@kernel.org, Marc Zyngier <maz@kernel.org>
Subject: Re: [PATCH V2] x86/apic/msi: Plug non-maskable MSI affinity race
Date: Fri, 31 Jan 2020 22:45:35 +0100 [thread overview]
Message-ID: <87d0azuwow.fsf@nanos.tec.linutronix.de> (raw)
In-Reply-To: <CAE=gft4cGYL7jHLqcGCU9J_efHs5dd+QyP8NfW5iSZCoi-SVOg@mail.gmail.com>
Evan Green <evgreen@chromium.org> writes:
> On Fri, Jan 31, 2020 at 6:27 AM Thomas Gleixner <tglx@linutronix.de> wrote:
>> #1 is uninteresting and has no unintended side effects. #2 and #3 might
>> expose issues in device driver interrupt handlers which are not prepared to
>> handle a spurious interrupt correctly. This not a regression, it's just
>> exposing something which was already broken as spurious interrupts can
>> happen for a lot of reasons and all driver handlers need to be able to deal
>> with them.
>>
>> Reported-by: Evan Green <evgreen@chromium.org>
>> Debugged-by: Evan Green <evgreen@chromium.org> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
>
> Heh, thanks for the credit.
Thanks for the detective work and the persistance to convince me!
> Something weird happened on this line with your signoff, though.
Yeah. No idea how I fatfingered that.
> I've been running this on my system for a few hours with no issues
> (normal repro in <1 minute). So,
>
> Tested-by: Evan Green <evgreen@chromium.org>
Thanks for confirmation!
tglx
next prev parent reply other threads:[~2020-01-31 21:45 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-18 0:25 [PATCH v2] PCI/MSI: Avoid torn updates to MSI pairs Evan Green
2020-01-22 11:25 ` Rajat Jain
2020-01-22 18:00 ` Evan Green
2020-01-23 8:49 ` Thomas Gleixner
2020-01-23 18:16 ` Thomas Gleixner
[not found] ` <CAE=gft6YiM5S1A7iJYJTd5zmaAa8=nhLE3B94JtWa+XW-qVSqQ@mail.gmail.com>
2020-01-23 22:59 ` Evan Green
2020-01-24 0:29 ` Evan Green
2020-01-24 14:34 ` Thomas Gleixner
2020-01-24 21:53 ` Evan Green
2020-01-24 22:50 ` Thomas Gleixner
2020-01-28 14:38 ` Thomas Gleixner
2020-01-28 22:22 ` Evan Green
2020-01-28 22:48 ` Thomas Gleixner
2020-01-29 18:00 ` Evan Green
2020-01-29 21:00 ` Thomas Gleixner
2020-01-29 22:53 ` Evan Green
2020-01-29 23:16 ` Thomas Gleixner
2020-01-29 23:48 ` Evan Green
2020-01-31 11:27 ` [PATCH] x86/apic/msi: Plug non-maskable MSI affinity race Thomas Gleixner
2020-01-31 14:26 ` [PATCH V2] " Thomas Gleixner
2020-01-31 20:32 ` Evan Green
2020-01-31 21:45 ` Thomas Gleixner [this message]
2020-02-01 8:36 ` [tip: x86/urgent] " tip-bot2 for Thomas Gleixner
[not found] ` <20200205144509.7004C21D7D@mail.kernel.org>
2020-02-05 14:58 ` [PATCH] " Thomas Gleixner
2020-02-05 20:18 ` Sasha Levin
2020-01-24 0:50 ` [PATCH v2] PCI/MSI: Avoid torn updates to MSI pairs Thomas Gleixner
2020-01-25 18:32 ` Jacob Pan
2020-01-26 8:09 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d0azuwow.fsf@nanos.tec.linutronix.de \
--to=tglx@linutronix.de \
--cc=bhelgaas@google.com \
--cc=evgreen@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=maz@kernel.org \
--cc=rajatja@google.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.