From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69C85C2D0DB for ; Wed, 22 Jan 2020 14:40:04 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 462D021835 for ; Wed, 22 Jan 2020 14:40:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 462D021835 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AECAD6F560; Wed, 22 Jan 2020 14:40:03 +0000 (UTC) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id 694C86F560 for ; Wed, 22 Jan 2020 14:40:02 +0000 (UTC) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Jan 2020 06:40:01 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,350,1574150400"; d="scan'208";a="222050928" Received: from gaia.fi.intel.com ([10.237.72.192]) by fmsmga008.fm.intel.com with ESMTP; 22 Jan 2020 06:40:01 -0800 Received: by gaia.fi.intel.com (Postfix, from userid 1000) id 387885C1DD9; Wed, 22 Jan 2020 16:39:19 +0200 (EET) From: Mika Kuoppala To: Chris Wilson , intel-gfx@lists.freedesktop.org In-Reply-To: <20200122124154.483444-1-chris@chris-wilson.co.uk> References: <20200122124154.483444-1-chris@chris-wilson.co.uk> Date: Wed, 22 Jan 2020 16:39:19 +0200 Message-ID: <87d0bbpnc8.fsf@gaia.fi.intel.com> MIME-Version: 1.0 Subject: Re: [Intel-gfx] [PATCH] drm/i915/gt: Include a tell-tale for engine parking X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Chris Wilson writes: > We have two trace messages that rely on the function name for > distinction. However, if gcc inlines the function, the two traces end up > with the same function name and are indistinguishable. Add a different > message to each to clarify which one we hit, i.e. which phase of engine > parking we are processing. > > Signed-off-by: Chris Wilson > --- > drivers/gpu/drm/i915/gt/intel_engine_pm.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/gt/intel_engine_pm.c b/drivers/gpu/drm/i915/gt/intel_engine_pm.c > index ea90ab3e396e..b6cf284e3a2d 100644 > --- a/drivers/gpu/drm/i915/gt/intel_engine_pm.c > +++ b/drivers/gpu/drm/i915/gt/intel_engine_pm.c > @@ -112,7 +112,7 @@ __queue_and_release_pm(struct i915_request *rq, > { > struct intel_gt_timelines *timelines = &engine->gt->timelines; > > - ENGINE_TRACE(engine, "\n"); > + ENGINE_TRACE(engine, "parking\n"); > > /* > * We have to serialise all potential retirement paths with our > @@ -249,7 +249,7 @@ static int __engine_park(struct intel_wakeref *wf) > if (!switch_to_kernel_context(engine)) > return -EBUSY; > > - ENGINE_TRACE(engine, "\n"); > + ENGINE_TRACE(engine, "parked\n"); Reading the functions, the exact spots are a mystery for me still as of why in these exact lines. Like the 'parked' would mean it is parked already, which it seems not to. However, what comes to the commit message and to immediate problem and fixing it, Reviewed-by: Mika Kuoppala > > call_idle_barriers(engine); /* cleanup after wedging */ > > -- > 2.25.0 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx