All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@intel.com>
To: Lyude Paul <lyude@redhat.com>, intel-gfx@lists.freedesktop.org
Cc: AceLan Kao <acelan.kao@canonical.com>
Subject: Re: [Intel-gfx] [PATCH v2 5/5] drm/i915: Force DPCD backlight mode on X1 Extreme 2nd Gen 4K AMOLED panel
Date: Thu, 16 Jan 2020 13:24:56 +0200	[thread overview]
Message-ID: <87d0bjk5iv.fsf@intel.com> (raw)
In-Reply-To: <5bb57d7b4cd05ec6832cc113addc81d0c8e79d7b.camel@redhat.com>

On Wed, 15 Jan 2020, Lyude Paul <lyude@redhat.com> wrote:
> sigh… so I just went through the correspondence with the vendor I mentioned
> and unfortunately the answer is still unclear. It looks like that for some of
> these panels there might actually be some bits in the EDID (!?!?) that are
> supposed to correspond to the backlight interface. weird. on top of that I'm
> not even sure if these EDID bits are actually standard. Interestingly enough
> it seems like they're also intending for some of their panels to be able to be
> used in both PWM and DPCD mode, and will eventually drop the PWM
> compatibility.
>
> Note this vendor isn't Lenovo, so I'm assuming that's probably why pwm mode
> doesn't work at all on this X1 extreme.
>
> That being said all I've seen are systems that don't specify this correctly in
> the vbt but do in the dpcd, so I'm going to go ahead and change this patch
> series over to using the dpcd by default instead. If this actually breaks any
> systems out there we can change the default behavior later. I will do a respin
> of the series asap (will have it on the list today or tommorrow, will merge
> after CI gives the OK).

Don't worry, nothing about displays really surprises me anymore.

I'm fine with the idea of trying to use the DPCD alone to enable aux
backlight. We need to try to make this work out of the box, without
module parameters.

Just make sure it's reasonably easy to revert in case issues do arise...

BR,
Jani.


-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2020-01-16 11:25 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-14 14:01 [Intel-gfx] [PATCH v2 0/5] drm/i915: eDP DPCD aux backlight fixes Jani Nikula
2020-01-14 14:01 ` [Intel-gfx] [PATCH v2 1/5] drm/i915: Fix eDP DPCD aux max backlight calculations Jani Nikula
2020-01-14 14:01 ` [Intel-gfx] [PATCH v2 2/5] drm/i915: Assume 100% brightness when not in DPCD control mode Jani Nikula
2020-01-14 14:01 ` [Intel-gfx] [PATCH v2 3/5] drm/i915: Fix DPCD register order in intel_dp_aux_enable_backlight() Jani Nikula
2020-01-14 14:01 ` [Intel-gfx] [PATCH v2 4/5] drm/i915: Auto detect DPCD backlight support by default Jani Nikula
2020-01-14 14:01 ` [Intel-gfx] [PATCH v2 5/5] drm/i915: Force DPCD backlight mode on X1 Extreme 2nd Gen 4K AMOLED panel Jani Nikula
2020-01-14 23:36   ` Lyude Paul
2020-01-15  8:32     ` Jani Nikula
2020-01-15 23:36       ` Lyude Paul
2020-01-16 11:24         ` Jani Nikula [this message]
2020-01-14 14:56 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: eDP DPCD aux backlight fixes (rev5) Patchwork
2020-01-14 14:56 ` [Intel-gfx] ✗ Fi.CI.BUILD: warning " Patchwork
2020-01-16 17:35 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d0bjk5iv.fsf@intel.com \
    --to=jani.nikula@intel.com \
    --cc=acelan.kao@canonical.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=lyude@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.