From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Cc: matthew.auld@intel.com
Subject: Re: [Intel-gfx] [PATCH 3/6] drm/i915/gt: Leave RING_BB_STATE to default value
Date: Mon, 30 Dec 2019 18:18:02 +0200 [thread overview]
Message-ID: <87d0c5rdmt.fsf@gaia.fi.intel.com> (raw)
In-Reply-To: <20191230160112.3838434-3-chris@chris-wilson.co.uk>
Chris Wilson <chris@chris-wilson.co.uk> writes:
> Do not reset RING_BB_STATE, leaving it to the default state value. This
> prevents bdw/bsw from getting confused when executing batches from the
> GGTT.
Happily setting up ro registers through ctx image, stamped my me...
Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
> drivers/gpu/drm/i915/gt/intel_lrc.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_lrc.c b/drivers/gpu/drm/i915/gt/intel_lrc.c
> index f0618e6aabd5..2bf6dc6d528d 100644
> --- a/drivers/gpu/drm/i915/gt/intel_lrc.c
> +++ b/drivers/gpu/drm/i915/gt/intel_lrc.c
> @@ -3982,7 +3982,6 @@ static void init_common_reg_state(u32 * const regs,
> regs[CTX_CONTEXT_CONTROL] = ctl;
>
> regs[CTX_RING_CTL] = RING_CTL_SIZE(ring->size) | RING_VALID;
> - regs[CTX_BB_STATE] = RING_BB_PPGTT;
> }
>
> static void init_wa_bb_reg_state(u32 * const regs,
> --
> 2.25.0.rc0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-12-30 16:18 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-30 16:01 [Intel-gfx] [PATCH 1/6] drm/i915/selftests: Flush the context worker Chris Wilson
2019-12-30 16:01 ` [Intel-gfx] [PATCH 2/6] drm/i915/gt: Clear LRC image inline Chris Wilson
2019-12-30 16:01 ` [Intel-gfx] [PATCH 3/6] drm/i915/gt: Leave RING_BB_STATE to default value Chris Wilson
2019-12-30 16:13 ` Chris Wilson
2019-12-30 16:18 ` Mika Kuoppala [this message]
2019-12-30 16:01 ` [Intel-gfx] [PATCH 4/6] drm/i915/gt: Ignore stale context state upon resume Chris Wilson
2019-12-30 16:14 ` Chris Wilson
2019-12-30 16:01 ` [Intel-gfx] [PATCH 5/6] drm/i915/gt: Discard stale context state from across idling Chris Wilson
2019-12-30 16:26 ` Chris Wilson
2019-12-30 16:30 ` Mika Kuoppala
2019-12-30 16:36 ` Chris Wilson
2019-12-30 16:01 ` [Intel-gfx] [PATCH 6/6] drm/i915/gt: Always poison the kernel_context image before unparking Chris Wilson
2019-12-30 16:23 ` Mika Kuoppala
2019-12-30 16:25 ` Chris Wilson
2019-12-30 16:03 ` [Intel-gfx] [PATCH 1/6] drm/i915/selftests: Flush the context worker Mika Kuoppala
2019-12-30 16:53 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/6] " Patchwork
2019-12-30 17:08 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d0c5rdmt.fsf@gaia.fi.intel.com \
--to=mika.kuoppala@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=matthew.auld@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.