From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Date: Thu, 28 Nov 2019 09:22:23 +0000 Subject: Re: [PATCH 13/13] samples: vfio-mdev: constify fb ops Message-Id: <87d0dcnynk.fsf@intel.com> List-Id: References: <20191127182940.GM406127@phenom.ffwll.local> In-Reply-To: <20191127182940.GM406127@phenom.ffwll.local> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Daniel Vetter Cc: kvm@vger.kernel.org, linux-fbdev@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Kirti Wankhede On Wed, 27 Nov 2019, Daniel Vetter wrote: > On Wed, Nov 27, 2019 at 06:32:09PM +0200, Jani Nikula wrote: >> Now that the fbops member of struct fb_info is const, we can star making >> the ops const as well. >> >> Cc: Kirti Wankhede >> Cc: kvm@vger.kernel.org >> Signed-off-by: Jani Nikula > > You've missed at least drivers/staging/fbtft in your search. I guess you > need to do a full make allyesconfig on x86/arm and arm64 (the latter > because some stupid drivers only compile there, not on arm, don't ask). > Still misses a pile of mips/ppc only stuff and maybe the sparcs and > alphas, but should be good enough. fbtft dynamically allocates the fbops, for whatever reason. There were others like that too. Some of the drivers modify the fbops runtime to choose different hooks for different configurations. Can't change them all anyway. Facilitating making the fbops const is one thing (patches 1-8), but I'm not really sure I want to sign up for exhaustively moving fbops to rodata on anything beyond drivers/gpu/drm. It's not like I leave stuff broken. Besides I am trying to cover all the low hanging fruit where I can simply add the "const" and be done with it. BR, Jani. > > With that done, on the remaining patches: > > Reviewed-by: Daniel Vetter > >> --- >> samples/vfio-mdev/mdpy-fb.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/samples/vfio-mdev/mdpy-fb.c b/samples/vfio-mdev/mdpy-fb.c >> index 2719bb259653..21dbf63d6e41 100644 >> --- a/samples/vfio-mdev/mdpy-fb.c >> +++ b/samples/vfio-mdev/mdpy-fb.c >> @@ -86,7 +86,7 @@ static void mdpy_fb_destroy(struct fb_info *info) >> iounmap(info->screen_base); >> } >> >> -static struct fb_ops mdpy_fb_ops = { >> +static const struct fb_ops mdpy_fb_ops = { >> .owner = THIS_MODULE, >> .fb_destroy = mdpy_fb_destroy, >> .fb_setcolreg = mdpy_fb_setcolreg, >> -- >> 2.20.1 >> >> _______________________________________________ >> dri-devel mailing list >> dri-devel@lists.freedesktop.org >> https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Jani Nikula, Intel Open Source Graphics Center From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH 13/13] samples: vfio-mdev: constify fb ops Date: Thu, 28 Nov 2019 11:22:23 +0200 Message-ID: <87d0dcnynk.fsf@intel.com> References: <20191127182940.GM406127@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20191127182940.GM406127@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter Cc: kvm@vger.kernel.org, linux-fbdev@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Kirti Wankhede List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCAyNyBOb3YgMjAxOSwgRGFuaWVsIFZldHRlciA8ZGFuaWVsQGZmd2xsLmNoPiB3cm90 ZToKPiBPbiBXZWQsIE5vdiAyNywgMjAxOSBhdCAwNjozMjowOVBNICswMjAwLCBKYW5pIE5pa3Vs YSB3cm90ZToKPj4gTm93IHRoYXQgdGhlIGZib3BzIG1lbWJlciBvZiBzdHJ1Y3QgZmJfaW5mbyBp cyBjb25zdCwgd2UgY2FuIHN0YXIgbWFraW5nCj4+IHRoZSBvcHMgY29uc3QgYXMgd2VsbC4KPj4g Cj4+IENjOiBLaXJ0aSBXYW5raGVkZSA8a3dhbmtoZWRlQG52aWRpYS5jb20+Cj4+IENjOiBrdm1A dmdlci5rZXJuZWwub3JnCj4+IFNpZ25lZC1vZmYtYnk6IEphbmkgTmlrdWxhIDxqYW5pLm5pa3Vs YUBpbnRlbC5jb20+Cj4KPiBZb3UndmUgbWlzc2VkIGF0IGxlYXN0IGRyaXZlcnMvc3RhZ2luZy9m YnRmdCBpbiB5b3VyIHNlYXJjaC4gSSBndWVzcyB5b3UKPiBuZWVkIHRvIGRvIGEgZnVsbCBtYWtl IGFsbHllc2NvbmZpZyBvbiB4ODYvYXJtIGFuZCBhcm02NCAodGhlIGxhdHRlcgo+IGJlY2F1c2Ug c29tZSBzdHVwaWQgZHJpdmVycyBvbmx5IGNvbXBpbGUgdGhlcmUsIG5vdCBvbiBhcm0sIGRvbid0 IGFzaykuCj4gU3RpbGwgbWlzc2VzIGEgcGlsZSBvZiBtaXBzL3BwYyBvbmx5IHN0dWZmIGFuZCBt YXliZSB0aGUgc3BhcmNzIGFuZAo+IGFscGhhcywgYnV0IHNob3VsZCBiZSBnb29kIGVub3VnaC4K CmZidGZ0IGR5bmFtaWNhbGx5IGFsbG9jYXRlcyB0aGUgZmJvcHMsIGZvciB3aGF0ZXZlciByZWFz b24uIFRoZXJlIHdlcmUKb3RoZXJzIGxpa2UgdGhhdCB0b28uIFNvbWUgb2YgdGhlIGRyaXZlcnMg bW9kaWZ5IHRoZSBmYm9wcyBydW50aW1lIHRvCmNob29zZSBkaWZmZXJlbnQgaG9va3MgZm9yIGRp ZmZlcmVudCBjb25maWd1cmF0aW9ucy4gQ2FuJ3QgY2hhbmdlIHRoZW0KYWxsIGFueXdheS4KCkZh Y2lsaXRhdGluZyBtYWtpbmcgdGhlIGZib3BzIGNvbnN0IGlzIG9uZSB0aGluZyAocGF0Y2hlcyAx LTgpLCBidXQgSSdtCm5vdCByZWFsbHkgc3VyZSBJIHdhbnQgdG8gc2lnbiB1cCBmb3IgZXhoYXVz dGl2ZWx5IG1vdmluZyBmYm9wcyB0bwpyb2RhdGEgb24gYW55dGhpbmcgYmV5b25kIGRyaXZlcnMv Z3B1L2RybS4gSXQncyBub3QgbGlrZSBJIGxlYXZlIHN0dWZmCmJyb2tlbi4gQmVzaWRlcyBJIGFt IHRyeWluZyB0byBjb3ZlciBhbGwgdGhlIGxvdyBoYW5naW5nIGZydWl0IHdoZXJlIEkKY2FuIHNp bXBseSBhZGQgdGhlICJjb25zdCIgYW5kIGJlIGRvbmUgd2l0aCBpdC4KCkJSLApKYW5pLgoKPgo+ IFdpdGggdGhhdCBkb25lLCBvbiB0aGUgcmVtYWluaW5nIHBhdGNoZXM6Cj4KPiBSZXZpZXdlZC1i eTogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBmZndsbC5jaD4KPgo+PiAtLS0KPj4gIHNh bXBsZXMvdmZpby1tZGV2L21kcHktZmIuYyB8IDIgKy0KPj4gIDEgZmlsZSBjaGFuZ2VkLCAxIGlu c2VydGlvbigrKSwgMSBkZWxldGlvbigtKQo+PiAKPj4gZGlmZiAtLWdpdCBhL3NhbXBsZXMvdmZp by1tZGV2L21kcHktZmIuYyBiL3NhbXBsZXMvdmZpby1tZGV2L21kcHktZmIuYwo+PiBpbmRleCAy NzE5YmIyNTk2NTMuLjIxZGJmNjNkNmU0MSAxMDA2NDQKPj4gLS0tIGEvc2FtcGxlcy92ZmlvLW1k ZXYvbWRweS1mYi5jCj4+ICsrKyBiL3NhbXBsZXMvdmZpby1tZGV2L21kcHktZmIuYwo+PiBAQCAt ODYsNyArODYsNyBAQCBzdGF0aWMgdm9pZCBtZHB5X2ZiX2Rlc3Ryb3koc3RydWN0IGZiX2luZm8g KmluZm8pCj4+ICAJCWlvdW5tYXAoaW5mby0+c2NyZWVuX2Jhc2UpOwo+PiAgfQo+PiAgCj4+IC1z dGF0aWMgc3RydWN0IGZiX29wcyBtZHB5X2ZiX29wcyA9IHsKPj4gK3N0YXRpYyBjb25zdCBzdHJ1 Y3QgZmJfb3BzIG1kcHlfZmJfb3BzID0gewo+PiAgCS5vd25lcgkJPSBUSElTX01PRFVMRSwKPj4g IAkuZmJfZGVzdHJveQk9IG1kcHlfZmJfZGVzdHJveSwKPj4gIAkuZmJfc2V0Y29scmVnCT0gbWRw eV9mYl9zZXRjb2xyZWcsCj4+IC0tIAo+PiAyLjIwLjEKPj4gCj4+IF9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4+IGRyaS1kZXZlbCBtYWlsaW5nIGxpc3QK Pj4gZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+PiBodHRwczovL2xpc3RzLmZyZWVk ZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAoKLS0gCkphbmkgTmlrdWxhLCBJ bnRlbCBPcGVuIFNvdXJjZSBHcmFwaGljcyBDZW50ZXIKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxA bGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxt YW4vbGlzdGluZm8vZHJpLWRldmVs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84DE5C432C0 for ; Thu, 28 Nov 2019 09:22:34 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 642A1216F4 for ; Thu, 28 Nov 2019 09:22:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 642A1216F4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C70B0891AC; Thu, 28 Nov 2019 09:22:31 +0000 (UTC) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id AA7656E03E; Thu, 28 Nov 2019 09:22:29 +0000 (UTC) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Nov 2019 01:22:29 -0800 X-IronPort-AV: E=Sophos;i="5.69,253,1571727600"; d="scan'208";a="203380662" Received: from jnikula-mobl3.fi.intel.com (HELO localhost) ([10.237.66.161]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Nov 2019 01:22:26 -0800 From: Jani Nikula To: Daniel Vetter In-Reply-To: <20191127182940.GM406127@phenom.ffwll.local> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20191127182940.GM406127@phenom.ffwll.local> Date: Thu, 28 Nov 2019 11:22:23 +0200 Message-ID: <87d0dcnynk.fsf@intel.com> MIME-Version: 1.0 Subject: Re: [Intel-gfx] [PATCH 13/13] samples: vfio-mdev: constify fb ops X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kvm@vger.kernel.org, linux-fbdev@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Kirti Wankhede Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Message-ID: <20191128092223.VfA6L4bvBrJyfjIGtuoE_tJIK7nJWGgvILozPbykKuA@z> T24gV2VkLCAyNyBOb3YgMjAxOSwgRGFuaWVsIFZldHRlciA8ZGFuaWVsQGZmd2xsLmNoPiB3cm90 ZToKPiBPbiBXZWQsIE5vdiAyNywgMjAxOSBhdCAwNjozMjowOVBNICswMjAwLCBKYW5pIE5pa3Vs YSB3cm90ZToKPj4gTm93IHRoYXQgdGhlIGZib3BzIG1lbWJlciBvZiBzdHJ1Y3QgZmJfaW5mbyBp cyBjb25zdCwgd2UgY2FuIHN0YXIgbWFraW5nCj4+IHRoZSBvcHMgY29uc3QgYXMgd2VsbC4KPj4g Cj4+IENjOiBLaXJ0aSBXYW5raGVkZSA8a3dhbmtoZWRlQG52aWRpYS5jb20+Cj4+IENjOiBrdm1A dmdlci5rZXJuZWwub3JnCj4+IFNpZ25lZC1vZmYtYnk6IEphbmkgTmlrdWxhIDxqYW5pLm5pa3Vs YUBpbnRlbC5jb20+Cj4KPiBZb3UndmUgbWlzc2VkIGF0IGxlYXN0IGRyaXZlcnMvc3RhZ2luZy9m YnRmdCBpbiB5b3VyIHNlYXJjaC4gSSBndWVzcyB5b3UKPiBuZWVkIHRvIGRvIGEgZnVsbCBtYWtl IGFsbHllc2NvbmZpZyBvbiB4ODYvYXJtIGFuZCBhcm02NCAodGhlIGxhdHRlcgo+IGJlY2F1c2Ug c29tZSBzdHVwaWQgZHJpdmVycyBvbmx5IGNvbXBpbGUgdGhlcmUsIG5vdCBvbiBhcm0sIGRvbid0 IGFzaykuCj4gU3RpbGwgbWlzc2VzIGEgcGlsZSBvZiBtaXBzL3BwYyBvbmx5IHN0dWZmIGFuZCBt YXliZSB0aGUgc3BhcmNzIGFuZAo+IGFscGhhcywgYnV0IHNob3VsZCBiZSBnb29kIGVub3VnaC4K CmZidGZ0IGR5bmFtaWNhbGx5IGFsbG9jYXRlcyB0aGUgZmJvcHMsIGZvciB3aGF0ZXZlciByZWFz b24uIFRoZXJlIHdlcmUKb3RoZXJzIGxpa2UgdGhhdCB0b28uIFNvbWUgb2YgdGhlIGRyaXZlcnMg bW9kaWZ5IHRoZSBmYm9wcyBydW50aW1lIHRvCmNob29zZSBkaWZmZXJlbnQgaG9va3MgZm9yIGRp ZmZlcmVudCBjb25maWd1cmF0aW9ucy4gQ2FuJ3QgY2hhbmdlIHRoZW0KYWxsIGFueXdheS4KCkZh Y2lsaXRhdGluZyBtYWtpbmcgdGhlIGZib3BzIGNvbnN0IGlzIG9uZSB0aGluZyAocGF0Y2hlcyAx LTgpLCBidXQgSSdtCm5vdCByZWFsbHkgc3VyZSBJIHdhbnQgdG8gc2lnbiB1cCBmb3IgZXhoYXVz dGl2ZWx5IG1vdmluZyBmYm9wcyB0bwpyb2RhdGEgb24gYW55dGhpbmcgYmV5b25kIGRyaXZlcnMv Z3B1L2RybS4gSXQncyBub3QgbGlrZSBJIGxlYXZlIHN0dWZmCmJyb2tlbi4gQmVzaWRlcyBJIGFt IHRyeWluZyB0byBjb3ZlciBhbGwgdGhlIGxvdyBoYW5naW5nIGZydWl0IHdoZXJlIEkKY2FuIHNp bXBseSBhZGQgdGhlICJjb25zdCIgYW5kIGJlIGRvbmUgd2l0aCBpdC4KCkJSLApKYW5pLgoKPgo+ IFdpdGggdGhhdCBkb25lLCBvbiB0aGUgcmVtYWluaW5nIHBhdGNoZXM6Cj4KPiBSZXZpZXdlZC1i eTogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBmZndsbC5jaD4KPgo+PiAtLS0KPj4gIHNh bXBsZXMvdmZpby1tZGV2L21kcHktZmIuYyB8IDIgKy0KPj4gIDEgZmlsZSBjaGFuZ2VkLCAxIGlu c2VydGlvbigrKSwgMSBkZWxldGlvbigtKQo+PiAKPj4gZGlmZiAtLWdpdCBhL3NhbXBsZXMvdmZp by1tZGV2L21kcHktZmIuYyBiL3NhbXBsZXMvdmZpby1tZGV2L21kcHktZmIuYwo+PiBpbmRleCAy NzE5YmIyNTk2NTMuLjIxZGJmNjNkNmU0MSAxMDA2NDQKPj4gLS0tIGEvc2FtcGxlcy92ZmlvLW1k ZXYvbWRweS1mYi5jCj4+ICsrKyBiL3NhbXBsZXMvdmZpby1tZGV2L21kcHktZmIuYwo+PiBAQCAt ODYsNyArODYsNyBAQCBzdGF0aWMgdm9pZCBtZHB5X2ZiX2Rlc3Ryb3koc3RydWN0IGZiX2luZm8g KmluZm8pCj4+ICAJCWlvdW5tYXAoaW5mby0+c2NyZWVuX2Jhc2UpOwo+PiAgfQo+PiAgCj4+IC1z dGF0aWMgc3RydWN0IGZiX29wcyBtZHB5X2ZiX29wcyA9IHsKPj4gK3N0YXRpYyBjb25zdCBzdHJ1 Y3QgZmJfb3BzIG1kcHlfZmJfb3BzID0gewo+PiAgCS5vd25lcgkJPSBUSElTX01PRFVMRSwKPj4g IAkuZmJfZGVzdHJveQk9IG1kcHlfZmJfZGVzdHJveSwKPj4gIAkuZmJfc2V0Y29scmVnCT0gbWRw eV9mYl9zZXRjb2xyZWcsCj4+IC0tIAo+PiAyLjIwLjEKPj4gCj4+IF9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4+IGRyaS1kZXZlbCBtYWlsaW5nIGxpc3QK Pj4gZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+PiBodHRwczovL2xpc3RzLmZyZWVk ZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAoKLS0gCkphbmkgTmlrdWxhLCBJ bnRlbCBPcGVuIFNvdXJjZSBHcmFwaGljcyBDZW50ZXIKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhA bGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxt YW4vbGlzdGluZm8vaW50ZWwtZ2Z4 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F2B5C432C0 for ; Thu, 28 Nov 2019 09:22:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6BF14216F4 for ; Thu, 28 Nov 2019 09:22:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726747AbfK1JW3 (ORCPT ); Thu, 28 Nov 2019 04:22:29 -0500 Received: from mga05.intel.com ([192.55.52.43]:31911 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726143AbfK1JW3 (ORCPT ); Thu, 28 Nov 2019 04:22:29 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Nov 2019 01:22:29 -0800 X-IronPort-AV: E=Sophos;i="5.69,253,1571727600"; d="scan'208";a="203380662" Received: from jnikula-mobl3.fi.intel.com (HELO localhost) ([10.237.66.161]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Nov 2019 01:22:26 -0800 From: Jani Nikula To: Daniel Vetter Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, Kirti Wankhede , kvm@vger.kernel.org Subject: Re: [PATCH 13/13] samples: vfio-mdev: constify fb ops In-Reply-To: <20191127182940.GM406127@phenom.ffwll.local> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20191127182940.GM406127@phenom.ffwll.local> Date: Thu, 28 Nov 2019 11:22:23 +0200 Message-ID: <87d0dcnynk.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Wed, 27 Nov 2019, Daniel Vetter wrote: > On Wed, Nov 27, 2019 at 06:32:09PM +0200, Jani Nikula wrote: >> Now that the fbops member of struct fb_info is const, we can star making >> the ops const as well. >> >> Cc: Kirti Wankhede >> Cc: kvm@vger.kernel.org >> Signed-off-by: Jani Nikula > > You've missed at least drivers/staging/fbtft in your search. I guess you > need to do a full make allyesconfig on x86/arm and arm64 (the latter > because some stupid drivers only compile there, not on arm, don't ask). > Still misses a pile of mips/ppc only stuff and maybe the sparcs and > alphas, but should be good enough. fbtft dynamically allocates the fbops, for whatever reason. There were others like that too. Some of the drivers modify the fbops runtime to choose different hooks for different configurations. Can't change them all anyway. Facilitating making the fbops const is one thing (patches 1-8), but I'm not really sure I want to sign up for exhaustively moving fbops to rodata on anything beyond drivers/gpu/drm. It's not like I leave stuff broken. Besides I am trying to cover all the low hanging fruit where I can simply add the "const" and be done with it. BR, Jani. > > With that done, on the remaining patches: > > Reviewed-by: Daniel Vetter > >> --- >> samples/vfio-mdev/mdpy-fb.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/samples/vfio-mdev/mdpy-fb.c b/samples/vfio-mdev/mdpy-fb.c >> index 2719bb259653..21dbf63d6e41 100644 >> --- a/samples/vfio-mdev/mdpy-fb.c >> +++ b/samples/vfio-mdev/mdpy-fb.c >> @@ -86,7 +86,7 @@ static void mdpy_fb_destroy(struct fb_info *info) >> iounmap(info->screen_base); >> } >> >> -static struct fb_ops mdpy_fb_ops = { >> +static const struct fb_ops mdpy_fb_ops = { >> .owner = THIS_MODULE, >> .fb_destroy = mdpy_fb_destroy, >> .fb_setcolreg = mdpy_fb_setcolreg, >> -- >> 2.20.1 >> >> _______________________________________________ >> dri-devel mailing list >> dri-devel@lists.freedesktop.org >> https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Jani Nikula, Intel Open Source Graphics Center