From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85109CA9EC2 for ; Tue, 29 Oct 2019 08:10:09 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 67E7820663 for ; Tue, 29 Oct 2019 08:10:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="p3g8QkgK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 67E7820663 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=free.fr Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 3087B21C9; Tue, 29 Oct 2019 09:09:16 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 3087B21C9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1572336606; bh=CUvjfMqTLBJ6ukBjrsurVyNz8Rp6C1mj38T6Jd/cJpY=; h=From:To:References:Date:In-Reply-To:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=p3g8QkgK6p+jMvzAO6l4gN9ZRmcrx+6ooCa4DJpH4vbrWtT+ak9zumLgJe66Tw/O3 QlArRg2jdmS9ckGn9tVPwjZS3d7yKw3fzCatHQX/UNiDTWyHojF9BFlE+CV7AjSl1E BOHjwOvbgJsF8+4UDQZysj/FTkZ+APhilHZ1GtYk= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id C27DFF8015A; Tue, 29 Oct 2019 09:09:15 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 2FA8EF80361; Mon, 28 Oct 2019 20:14:28 +0100 (CET) Received: from smtp.smtpout.orange.fr (smtp09.smtpout.orange.fr [80.12.242.131]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id A1FECF8011D for ; Mon, 28 Oct 2019 20:14:25 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz A1FECF8011D Received: from belgarion ([90.55.204.252]) by mwinf5d17 with ME id K7EJ2100B5TFNlm037EJ4o; Mon, 28 Oct 2019 20:14:24 +0100 X-ME-Helo: belgarion X-ME-Auth: amFyem1pay5yb2JlcnRAb3JhbmdlLmZy X-ME-Date: Mon, 28 Oct 2019 20:14:24 +0100 X-ME-IP: 90.55.204.252 From: Robert Jarzmik To: Arnd Bergmann , Russell King References: <20191018154052.1276506-1-arnd@arndb.de> <20191018154201.1276638-5-arnd@arndb.de> X-URL: http://belgarath.falguerolles.org/ Date: Mon, 28 Oct 2019 20:14:18 +0100 In-Reply-To: <20191018154201.1276638-5-arnd@arndb.de> (Arnd Bergmann's message of "Fri, 18 Oct 2019 17:41:20 +0200") Message-ID: <87d0egof79.fsf@belgarion.home> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/26 (gnu/linux) MIME-Version: 1.0 X-Mailman-Approved-At: Tue, 29 Oct 2019 09:09:14 +0100 Cc: Ulf Hansson , linux-usb@vger.kernel.org, Viresh Kumar , Michael Turquette , Alexandre Belloni , Dominik Brodowski , linux-mtd@lists.infradead.org, Pavel Machek , linux-clk@vger.kernel.org, linux-leds@vger.kernel.org, linux-rtc@vger.kernel.org, linux-input@vger.kernel.org, Linus Walleij , Guenter Roeck , linux-watchdog@vger.kernel.org, alsa-devel@alsa-project.org, linux-pm@vger.kernel.org, Haojian Zhuang , Mark Brown , Jacek Anaszewski , linux-fbdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Stephen Boyd , Greg Kroah-Hartman , dri-devel@lists.freedesktop.org, Dmitry Torokhov , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, Daniel Mack Subject: Re: [alsa-devel] [PATCH 05/46] ARM: pxa: split up mach/hardware.h X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Arnd Bergmann writes: > The mach/hardware.h is included in lots of places, and it provides > three different things on pxa: > > - the cpu_is_pxa* macros > - an indirect inclusion of mach/addr-map.h > - the __REG() and io_pv2() helper macros > > Split it up into separate and mach/pxa-regs.h > headers, then change all the files that use mach/hardware.h to > include the exact set of those three headers that they actually > need, allowing for further more targeted cleanup. > > linux/soc/pxa/cpu.h can remain permanently exported and is now in > a global location along with similar headers. pxa-regs.h and > addr-map.h are only used in a very small number of drivers now > and can be moved to arch/arm/mach-pxa/ directly when those drivers > are to pass the necessary data as resources. For the pxa part, that looks fine to me. I'd like to focus a bit of Russell's attention to the sa11xx part (reminder in [1]), and more specifically : - the change to drivers/pcmcia/soc_common.c - the change to drivers/pcmcia/sa1111_generic.c I must admit my knowledge of PCMCIA is relatively poor, and even if the patch looks harmless, one never knows if Assebet will ever by same after ... Cheers. -- Robert [1] Extract of the patch for Russell's scrutiny > diff --git a/drivers/pcmcia/sa1111_generic.c b/drivers/pcmcia/sa1111_generic.c > index 11783410223b..2f556fa37c43 100644 > --- a/drivers/pcmcia/sa1111_generic.c > +++ b/drivers/pcmcia/sa1111_generic.c > @@ -17,7 +17,6 @@ > > #include > > -#include > #include > #include > #include ... zip ... > diff --git a/drivers/pcmcia/soc_common.c b/drivers/pcmcia/soc_common.c > index 3a8c84bb174d..9276a628473d 100644 > --- a/drivers/pcmcia/soc_common.c > +++ b/drivers/pcmcia/soc_common.c > @@ -47,8 +47,6 @@ > #include > #include > > -#include > - > #include "soc_common.h" > > static irqreturn_t soc_common_pcmcia_interrupt(int irq, void *dev); _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97734CA9EC3 for ; Mon, 28 Oct 2019 19:14:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7AFE921835 for ; Mon, 28 Oct 2019 19:14:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730159AbfJ1TOb (ORCPT ); Mon, 28 Oct 2019 15:14:31 -0400 Received: from smtp09.smtpout.orange.fr ([80.12.242.131]:59522 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729995AbfJ1TO0 (ORCPT ); Mon, 28 Oct 2019 15:14:26 -0400 Received: from belgarion ([90.55.204.252]) by mwinf5d17 with ME id K7EJ2100B5TFNlm037EJ4o; Mon, 28 Oct 2019 20:14:24 +0100 X-ME-Helo: belgarion X-ME-Auth: amFyem1pay5yb2JlcnRAb3JhbmdlLmZy X-ME-Date: Mon, 28 Oct 2019 20:14:24 +0100 X-ME-IP: 90.55.204.252 From: Robert Jarzmik To: Arnd Bergmann , Russell King Cc: Daniel Mack , Haojian Zhuang , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Linus Walleij , Michael Turquette , Stephen Boyd , Viresh Kumar , Dmitry Torokhov , Jacek Anaszewski , Pavel Machek , Ulf Hansson , Dominik Brodowski , Alexandre Belloni , Greg Kroah-Hartman , Guenter Roeck , Mark Brown , linux-clk@vger.kernel.org, linux-pm@vger.kernel.org, linux-input@vger.kernel.org, linux-leds@vger.kernel.org, linux-mmc@vger.kernel.org, linux-mtd@lists.infradead.org, linux-rtc@vger.kernel.org, linux-usb@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-watchdog@vger.kernel.org, alsa-devel@alsa-project.org Subject: Re: [PATCH 05/46] ARM: pxa: split up mach/hardware.h References: <20191018154052.1276506-1-arnd@arndb.de> <20191018154201.1276638-5-arnd@arndb.de> X-URL: http://belgarath.falguerolles.org/ Date: Mon, 28 Oct 2019 20:14:18 +0100 In-Reply-To: <20191018154201.1276638-5-arnd@arndb.de> (Arnd Bergmann's message of "Fri, 18 Oct 2019 17:41:20 +0200") Message-ID: <87d0egof79.fsf@belgarion.home> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/26 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org Arnd Bergmann writes: > The mach/hardware.h is included in lots of places, and it provides > three different things on pxa: > > - the cpu_is_pxa* macros > - an indirect inclusion of mach/addr-map.h > - the __REG() and io_pv2() helper macros > > Split it up into separate and mach/pxa-regs.h > headers, then change all the files that use mach/hardware.h to > include the exact set of those three headers that they actually > need, allowing for further more targeted cleanup. > > linux/soc/pxa/cpu.h can remain permanently exported and is now in > a global location along with similar headers. pxa-regs.h and > addr-map.h are only used in a very small number of drivers now > and can be moved to arch/arm/mach-pxa/ directly when those drivers > are to pass the necessary data as resources. For the pxa part, that looks fine to me. I'd like to focus a bit of Russell's attention to the sa11xx part (reminder in [1]), and more specifically : - the change to drivers/pcmcia/soc_common.c - the change to drivers/pcmcia/sa1111_generic.c I must admit my knowledge of PCMCIA is relatively poor, and even if the patch looks harmless, one never knows if Assebet will ever by same after ... Cheers. -- Robert [1] Extract of the patch for Russell's scrutiny > diff --git a/drivers/pcmcia/sa1111_generic.c b/drivers/pcmcia/sa1111_generic.c > index 11783410223b..2f556fa37c43 100644 > --- a/drivers/pcmcia/sa1111_generic.c > +++ b/drivers/pcmcia/sa1111_generic.c > @@ -17,7 +17,6 @@ > > #include > > -#include > #include > #include > #include ... zip ... > diff --git a/drivers/pcmcia/soc_common.c b/drivers/pcmcia/soc_common.c > index 3a8c84bb174d..9276a628473d 100644 > --- a/drivers/pcmcia/soc_common.c > +++ b/drivers/pcmcia/soc_common.c > @@ -47,8 +47,6 @@ > #include > #include > > -#include > - > #include "soc_common.h" > > static irqreturn_t soc_common_pcmcia_interrupt(int irq, void *dev); From mboxrd@z Thu Jan 1 00:00:00 1970 From: Robert Jarzmik Date: Mon, 28 Oct 2019 19:14:18 +0000 Subject: Re: [PATCH 05/46] ARM: pxa: split up mach/hardware.h Message-Id: <87d0egof79.fsf@belgarion.home> List-Id: References: <20191018154052.1276506-1-arnd@arndb.de> <20191018154201.1276638-5-arnd@arndb.de> In-Reply-To: <20191018154201.1276638-5-arnd@arndb.de> (Arnd Bergmann's message of "Fri, 18 Oct 2019 17:41:20 +0200") MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Arnd Bergmann , Russell King Cc: Ulf Hansson , linux-usb@vger.kernel.org, Viresh Kumar , Michael Turquette , Alexandre Belloni , Dominik Brodowski , linux-mtd@lists.infradead.org, Pavel Machek , linux-clk@vger.kernel.org, linux-leds@vger.kernel.org, linux-rtc@vger.kernel.org, linux-input@vger.kernel.org, Linus Walleij , Guenter Roeck , linux-watchdog@vger.kernel.org, alsa-devel@alsa-project.org, linux-pm@vger.kernel.org, Haojian Zhuang , Mark Brown , Jacek Anaszewski , linux-fbdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Stephen Boyd , Greg Kroah-Hartman , dri-devel@lists.freedesktop.org, Dmitry Torokhov , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, Daniel Mack Arnd Bergmann writes: > The mach/hardware.h is included in lots of places, and it provides > three different things on pxa: > > - the cpu_is_pxa* macros > - an indirect inclusion of mach/addr-map.h > - the __REG() and io_pv2() helper macros > > Split it up into separate and mach/pxa-regs.h > headers, then change all the files that use mach/hardware.h to > include the exact set of those three headers that they actually > need, allowing for further more targeted cleanup. > > linux/soc/pxa/cpu.h can remain permanently exported and is now in > a global location along with similar headers. pxa-regs.h and > addr-map.h are only used in a very small number of drivers now > and can be moved to arch/arm/mach-pxa/ directly when those drivers > are to pass the necessary data as resources. For the pxa part, that looks fine to me. I'd like to focus a bit of Russell's attention to the sa11xx part (reminder in [1]), and more specifically : - the change to drivers/pcmcia/soc_common.c - the change to drivers/pcmcia/sa1111_generic.c I must admit my knowledge of PCMCIA is relatively poor, and even if the patch looks harmless, one never knows if Assebet will ever by same after ... Cheers. -- Robert [1] Extract of the patch for Russell's scrutiny > diff --git a/drivers/pcmcia/sa1111_generic.c b/drivers/pcmcia/sa1111_generic.c > index 11783410223b..2f556fa37c43 100644 > --- a/drivers/pcmcia/sa1111_generic.c > +++ b/drivers/pcmcia/sa1111_generic.c > @@ -17,7 +17,6 @@ > > #include > > -#include > #include > #include > #include ... zip ... > diff --git a/drivers/pcmcia/soc_common.c b/drivers/pcmcia/soc_common.c > index 3a8c84bb174d..9276a628473d 100644 > --- a/drivers/pcmcia/soc_common.c > +++ b/drivers/pcmcia/soc_common.c > @@ -47,8 +47,6 @@ > #include > #include > > -#include > - > #include "soc_common.h" > > static irqreturn_t soc_common_pcmcia_interrupt(int irq, void *dev); From mboxrd@z Thu Jan 1 00:00:00 1970 From: Robert Jarzmik Subject: Re: [PATCH 05/46] ARM: pxa: split up mach/hardware.h Date: Mon, 28 Oct 2019 20:14:18 +0100 Message-ID: <87d0egof79.fsf@belgarion.home> References: <20191018154052.1276506-1-arnd@arndb.de> <20191018154201.1276638-5-arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: <20191018154201.1276638-5-arnd@arndb.de> (Arnd Bergmann's message of "Fri, 18 Oct 2019 17:41:20 +0200") Sender: linux-kernel-owner@vger.kernel.org To: Arnd Bergmann , Russell King Cc: Daniel Mack , Haojian Zhuang , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Linus Walleij , Michael Turquette , Stephen Boyd , Viresh Kumar , Dmitry Torokhov , Jacek Anaszewski , Pavel Machek , Ulf Hansson , Dominik Brodowski , Alexandre Belloni , Greg Kroah-Hartman , Guenter Roeck , Mark Brown , linux-clk@vger.kernel.org, linux-pm@vger.kernel.org, linux-input@vger.kernel.org List-Id: linux-mmc@vger.kernel.org Arnd Bergmann writes: > The mach/hardware.h is included in lots of places, and it provides > three different things on pxa: > > - the cpu_is_pxa* macros > - an indirect inclusion of mach/addr-map.h > - the __REG() and io_pv2() helper macros > > Split it up into separate and mach/pxa-regs.h > headers, then change all the files that use mach/hardware.h to > include the exact set of those three headers that they actually > need, allowing for further more targeted cleanup. > > linux/soc/pxa/cpu.h can remain permanently exported and is now in > a global location along with similar headers. pxa-regs.h and > addr-map.h are only used in a very small number of drivers now > and can be moved to arch/arm/mach-pxa/ directly when those drivers > are to pass the necessary data as resources. For the pxa part, that looks fine to me. I'd like to focus a bit of Russell's attention to the sa11xx part (reminder in [1]), and more specifically : - the change to drivers/pcmcia/soc_common.c - the change to drivers/pcmcia/sa1111_generic.c I must admit my knowledge of PCMCIA is relatively poor, and even if the patch looks harmless, one never knows if Assebet will ever by same after ... Cheers. -- Robert [1] Extract of the patch for Russell's scrutiny > diff --git a/drivers/pcmcia/sa1111_generic.c b/drivers/pcmcia/sa1111_generic.c > index 11783410223b..2f556fa37c43 100644 > --- a/drivers/pcmcia/sa1111_generic.c > +++ b/drivers/pcmcia/sa1111_generic.c > @@ -17,7 +17,6 @@ > > #include > > -#include > #include > #include > #include ... zip ... > diff --git a/drivers/pcmcia/soc_common.c b/drivers/pcmcia/soc_common.c > index 3a8c84bb174d..9276a628473d 100644 > --- a/drivers/pcmcia/soc_common.c > +++ b/drivers/pcmcia/soc_common.c > @@ -47,8 +47,6 @@ > #include > #include > > -#include > - > #include "soc_common.h" > > static irqreturn_t soc_common_pcmcia_interrupt(int irq, void *dev); From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E34BECA9EC0 for ; Mon, 28 Oct 2019 19:14:54 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BDE23214B2 for ; Mon, 28 Oct 2019 19:14:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="AfUF9+KQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BDE23214B2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=free.fr Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:In-Reply-To: Date:References:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2e6PpIFqpeyoh0mBBfe5JzhcASdl/IKnDu9nQ8WYzSk=; b=AfUF9+KQ+szejf lA8uT3RthkCJfoG9SiuZDTUb/wg0Ru2Rp4d12yBtCohTBXD2f+FLDDr7GgBtG//VWVpA7IYWRMAa5 SA8bac+bySz8FRH0GYY5WiiJhgi2Ou+bVAf5ZyiZ5t4aNZDRmOOflo3qZwkM5jEPRa8QzZz74LHs1 TszhJFdcclt9Dh6NfbI22FKWspvvSrU8FOADQADhXcJ9L9/UevOrur3ONxsK0E8O7RdJZI0NxGmfk VUXZK/QO/TFZvGGZzCuaDg/D5T5jkvDrHOaDO3UjaTvL/N51zGvn2Rqq85qc+XMHH6ONNTkv6KVrq 3ABKZgwbSYTDFzcCqd9w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iPATO-0004P9-U1; Mon, 28 Oct 2019 19:14:38 +0000 Received: from smtp09.smtpout.orange.fr ([80.12.242.131] helo=smtp.smtpout.orange.fr) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iPATC-0004Ep-RO for linux-mtd@lists.infradead.org; Mon, 28 Oct 2019 19:14:28 +0000 Received: from belgarion ([90.55.204.252]) by mwinf5d17 with ME id K7EJ2100B5TFNlm037EJ4o; Mon, 28 Oct 2019 20:14:24 +0100 X-ME-Helo: belgarion X-ME-Auth: amFyem1pay5yb2JlcnRAb3JhbmdlLmZy X-ME-Date: Mon, 28 Oct 2019 20:14:24 +0100 X-ME-IP: 90.55.204.252 From: Robert Jarzmik To: Arnd Bergmann , Russell King Subject: Re: [PATCH 05/46] ARM: pxa: split up mach/hardware.h References: <20191018154052.1276506-1-arnd@arndb.de> <20191018154201.1276638-5-arnd@arndb.de> X-URL: http://belgarath.falguerolles.org/ Date: Mon, 28 Oct 2019 20:14:18 +0100 In-Reply-To: <20191018154201.1276638-5-arnd@arndb.de> (Arnd Bergmann's message of "Fri, 18 Oct 2019 17:41:20 +0200") Message-ID: <87d0egof79.fsf@belgarion.home> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/26 (gnu/linux) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191028_121427_165479_B8ED4371 X-CRM114-Status: GOOD ( 22.72 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ulf Hansson , linux-usb@vger.kernel.org, Viresh Kumar , Michael Turquette , Alexandre Belloni , Dominik Brodowski , linux-mtd@lists.infradead.org, Pavel Machek , linux-clk@vger.kernel.org, linux-leds@vger.kernel.org, linux-rtc@vger.kernel.org, linux-input@vger.kernel.org, Linus Walleij , Guenter Roeck , linux-watchdog@vger.kernel.org, alsa-devel@alsa-project.org, linux-pm@vger.kernel.org, Haojian Zhuang , Mark Brown , Jacek Anaszewski , linux-fbdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Stephen Boyd , Greg Kroah-Hartman , dri-devel@lists.freedesktop.org, Dmitry Torokhov , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, Daniel Mack Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org Arnd Bergmann writes: > The mach/hardware.h is included in lots of places, and it provides > three different things on pxa: > > - the cpu_is_pxa* macros > - an indirect inclusion of mach/addr-map.h > - the __REG() and io_pv2() helper macros > > Split it up into separate and mach/pxa-regs.h > headers, then change all the files that use mach/hardware.h to > include the exact set of those three headers that they actually > need, allowing for further more targeted cleanup. > > linux/soc/pxa/cpu.h can remain permanently exported and is now in > a global location along with similar headers. pxa-regs.h and > addr-map.h are only used in a very small number of drivers now > and can be moved to arch/arm/mach-pxa/ directly when those drivers > are to pass the necessary data as resources. For the pxa part, that looks fine to me. I'd like to focus a bit of Russell's attention to the sa11xx part (reminder in [1]), and more specifically : - the change to drivers/pcmcia/soc_common.c - the change to drivers/pcmcia/sa1111_generic.c I must admit my knowledge of PCMCIA is relatively poor, and even if the patch looks harmless, one never knows if Assebet will ever by same after ... Cheers. -- Robert [1] Extract of the patch for Russell's scrutiny > diff --git a/drivers/pcmcia/sa1111_generic.c b/drivers/pcmcia/sa1111_generic.c > index 11783410223b..2f556fa37c43 100644 > --- a/drivers/pcmcia/sa1111_generic.c > +++ b/drivers/pcmcia/sa1111_generic.c > @@ -17,7 +17,6 @@ > > #include > > -#include > #include > #include > #include ... zip ... > diff --git a/drivers/pcmcia/soc_common.c b/drivers/pcmcia/soc_common.c > index 3a8c84bb174d..9276a628473d 100644 > --- a/drivers/pcmcia/soc_common.c > +++ b/drivers/pcmcia/soc_common.c > @@ -47,8 +47,6 @@ > #include > #include > > -#include > - > #include "soc_common.h" > > static irqreturn_t soc_common_pcmcia_interrupt(int irq, void *dev); ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D30BDCA9EC2 for ; Mon, 28 Oct 2019 19:14:30 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AD55521721 for ; Mon, 28 Oct 2019 19:14:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="sgNQdVdc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AD55521721 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=free.fr Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:In-Reply-To: Date:References:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=BAIfFdqjXfWKnYLHp7JmbKrWG9TpE+XEWliB4Y+nALI=; b=sgNQdVdc29MNyI KB76cUIW72rqJ13yCnaibpmfCoPo78nrhVc+bsicnvIaWoOAztu+VCyWt/o8RYqvEwqQ8DD0k/KiI 3Jp5Du2OHp0dJAtboih769GaqlcNhN+HufYyec0xLMLVPXbg6Bt8Nrv58P7sJYlAuPwZFQa7SXteW TQmoDwJcCdQ1gNCmaCPEL9uw4dNHC+4FxiXLD4+mef1B54xA+rc59+zzHS+wrU7lg5m2NlNUsMdo6 4gv8vgMntrzqq87X+l/pND3q4OAlKkhKt/0d5Y7SsO5j2jBZfxpQ9f2b9bluX8ZfZ4bUXeIo9pPBQ Kid/oOZia2l1TmDKTg4Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iPATG-0004GK-9p; Mon, 28 Oct 2019 19:14:30 +0000 Received: from smtp09.smtpout.orange.fr ([80.12.242.131] helo=smtp.smtpout.orange.fr) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iPATC-0004Eq-RO for linux-arm-kernel@lists.infradead.org; Mon, 28 Oct 2019 19:14:28 +0000 Received: from belgarion ([90.55.204.252]) by mwinf5d17 with ME id K7EJ2100B5TFNlm037EJ4o; Mon, 28 Oct 2019 20:14:24 +0100 X-ME-Helo: belgarion X-ME-Auth: amFyem1pay5yb2JlcnRAb3JhbmdlLmZy X-ME-Date: Mon, 28 Oct 2019 20:14:24 +0100 X-ME-IP: 90.55.204.252 From: Robert Jarzmik To: Arnd Bergmann , Russell King Subject: Re: [PATCH 05/46] ARM: pxa: split up mach/hardware.h References: <20191018154052.1276506-1-arnd@arndb.de> <20191018154201.1276638-5-arnd@arndb.de> X-URL: http://belgarath.falguerolles.org/ Date: Mon, 28 Oct 2019 20:14:18 +0100 In-Reply-To: <20191018154201.1276638-5-arnd@arndb.de> (Arnd Bergmann's message of "Fri, 18 Oct 2019 17:41:20 +0200") Message-ID: <87d0egof79.fsf@belgarion.home> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/26 (gnu/linux) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191028_121427_165598_6AE7C65D X-CRM114-Status: GOOD ( 23.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ulf Hansson , linux-usb@vger.kernel.org, Viresh Kumar , Michael Turquette , Alexandre Belloni , Dominik Brodowski , linux-mtd@lists.infradead.org, Pavel Machek , linux-clk@vger.kernel.org, linux-leds@vger.kernel.org, linux-rtc@vger.kernel.org, linux-input@vger.kernel.org, Linus Walleij , Guenter Roeck , linux-watchdog@vger.kernel.org, alsa-devel@alsa-project.org, linux-pm@vger.kernel.org, Haojian Zhuang , Mark Brown , Jacek Anaszewski , linux-fbdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Stephen Boyd , Greg Kroah-Hartman , dri-devel@lists.freedesktop.org, Dmitry Torokhov , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, Daniel Mack Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Arnd Bergmann writes: > The mach/hardware.h is included in lots of places, and it provides > three different things on pxa: > > - the cpu_is_pxa* macros > - an indirect inclusion of mach/addr-map.h > - the __REG() and io_pv2() helper macros > > Split it up into separate and mach/pxa-regs.h > headers, then change all the files that use mach/hardware.h to > include the exact set of those three headers that they actually > need, allowing for further more targeted cleanup. > > linux/soc/pxa/cpu.h can remain permanently exported and is now in > a global location along with similar headers. pxa-regs.h and > addr-map.h are only used in a very small number of drivers now > and can be moved to arch/arm/mach-pxa/ directly when those drivers > are to pass the necessary data as resources. For the pxa part, that looks fine to me. I'd like to focus a bit of Russell's attention to the sa11xx part (reminder in [1]), and more specifically : - the change to drivers/pcmcia/soc_common.c - the change to drivers/pcmcia/sa1111_generic.c I must admit my knowledge of PCMCIA is relatively poor, and even if the patch looks harmless, one never knows if Assebet will ever by same after ... Cheers. -- Robert [1] Extract of the patch for Russell's scrutiny > diff --git a/drivers/pcmcia/sa1111_generic.c b/drivers/pcmcia/sa1111_generic.c > index 11783410223b..2f556fa37c43 100644 > --- a/drivers/pcmcia/sa1111_generic.c > +++ b/drivers/pcmcia/sa1111_generic.c > @@ -17,7 +17,6 @@ > > #include > > -#include > #include > #include > #include ... zip ... > diff --git a/drivers/pcmcia/soc_common.c b/drivers/pcmcia/soc_common.c > index 3a8c84bb174d..9276a628473d 100644 > --- a/drivers/pcmcia/soc_common.c > +++ b/drivers/pcmcia/soc_common.c > @@ -47,8 +47,6 @@ > #include > #include > > -#include > - > #include "soc_common.h" > > static irqreturn_t soc_common_pcmcia_interrupt(int irq, void *dev); _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel