[Buildroot] [PATCH v3 1/2] package/python-kiwisolver: new package

[Esben Haabendal <esben@geanix.com>]

Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:

> Hello,
>
> On Tue, 17 Sep 2019 10:50:33 +0200
> Esben Haabendal <esben@geanix.com> wrote:
>
>> +config BR2_PACKAGE_PYTHON_KIWISOLVER
>> +	bool "python-kiwisolver"
>> +	depends on BR2_INSTALL_LIBSTDCPP
>> +	depends on BR2_PACKAGE_PYTHON || BR2_PACKAGE_PYTHON
>
> a dependency on python || python is not very useful, especially since
> anyway this Config.in is already included in a python || python3
> condition.

Ah.  Both did I make a typo in v3, and what I wanted to do did not make
any difference.  The first lesson of today :)

>
>> diff --git a/package/python-kiwisolver/python-kiwisolver.mk b/package/python-kiwisolver/python-kiwisolver.mk
>> new file mode 100644
>> index 000000000000..96019fc29328
>> --- /dev/null
>> +++ b/package/python-kiwisolver/python-kiwisolver.mk
>> @@ -0,0 +1,7 @@
>
> You forgot our completely useless, but absolutely mandatory and lovely
> comment header that we have in all packages.

I will try to remember next time :)

> I fixed both issues and applied to master. Thanks!

Thanks.

/Esben