From: Felipe Balbi <balbi@kernel.org>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
linux-usb@vger.kernel.org
Cc: Guido Kiener <guido@kiener-muenchen.de>,
Alan Stern <stern@rowland.harvard.edu>
Subject: Re: [PATCH 1/2] usb: gadget: net2280: Move all "ll" registers in one structure
Date: Wed, 28 Aug 2019 14:02:42 +0300 [thread overview]
Message-ID: <87d0gpwo19.fsf@gmail.com> (raw)
In-Reply-To: <d2f02109e718a6578d91467e6a4d522819be7a23.camel@kernel.crashing.org>
[-- Attachment #1: Type: text/plain, Size: 1210 bytes --]
Hi,
Benjamin Herrenschmidt <benh@kernel.crashing.org> writes:
> On Wed, 2019-08-28 at 13:09 +0300, Felipe Balbi wrote:
>> Hi,
>>
>> Benjamin Herrenschmidt <benh@kernel.crashing.org> writes:
>>
>> > The split into multiple structures of the "ll" register bank is
>> > impractical. It makes it hard to add ll_lfps_timers_2 which is
>> > at offset 0x794, which is outside of the existing "lfps" structure
>> > and would require us to add yet another one.
>> >
>> > Instead, move all the "ll" registers into a single usb338x_ll_regs
>> > structure, and add ll_lfps_timers_2 while at it. It will be used
>> > in a subsequent patch.
>> >
>> > Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
>>
>> I tried applying your patches but it resulted in build break. Can you
>> collect all the dependencies and send a single series? I'm applying on
>> top of my testing/next branch.
>
> You mean the 2 net2280 patches ? Or something else ?
>
> What break did you get ? It's just one series of 2 patches.... I'll try
> rebasing them against your branch tomorrow.
allmodconfig broke with missing fields in whatever structure. I didn't
dig too much, sorry.
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2019-08-28 11:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-23 3:15 [PATCH 1/2] usb: gadget: net2280: Move all "ll" registers in one structure Benjamin Herrenschmidt
2019-08-28 10:09 ` Felipe Balbi
2019-08-28 10:55 ` Benjamin Herrenschmidt
2019-08-28 11:02 ` Felipe Balbi [this message]
2019-08-28 12:34 ` guido
-- strict thread matches above, loose matches on Subject: below --
2019-08-23 3:15 Herrenschmidt, Benjamin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d0gpwo19.fsf@gmail.com \
--to=balbi@kernel.org \
--cc=benh@kernel.crashing.org \
--cc=guido@kiener-muenchen.de \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.