Re: [PATCH for v5.2] iwlwifi: mvm: disable TX-AMSDU on older NICs

[Kalle Valo <kvalo@codeaurora.org>]

Luca Coelho <luca@coelho.fi> writes:

> On Wed, 2019-07-03 at 11:10 +0300, Luca Coelho wrote:
>> From: Johannes Berg <johannes.berg@intel.com>
>> 
>> On older NICs, we occasionally see issues with A-MSDU support,
>> where the commands in the FIFO get confused and then we see an
>> assert EDC because the next command in the FIFO isn't TX.
>> 
>> We've tried to isolate this issue and understand where it comes
>> from, but haven't found any errors in building the A-MSDU in
>> software.
>> 
>> At least for now, disable A-MSDU support on older hardware so
>> that users can use it again without fearing the assert.
>> 
>> This fixes https://bugzilla.kernel.org/show_bug.cgi?id=203315.
>> 
>> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
>> Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
>> ---
>
> Hi Dave,
>
> This is an important fix for a bug that has been reported by several
> users in bugzilla (and elsewhere).  It fixes FW crashes that disrupt
> throughput and connectivity in general in very popular devices (Intel's
> WiFi 7000 and 8000 series).
>
> I know it's a bit late for v5.2, but if possible, it would be great to
> take this.  Kalle is on vacation, so we agreed that I would send it
> directly to you.

Acked-by: Kalle Valo <kvalo@codeaurora.org>

-- 
Kalle Valo