From: Vagrant Cascadian <vagrant@debian.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Revert "fdt: Fix FIT header verification in mkimage and conduct same checks as bootm"
Date: Tue, 09 Apr 2019 11:04:12 -0700 [thread overview]
Message-ID: <87d0lv838j.fsf@ponder> (raw)
In-Reply-To: <CAEjdKLUo2b5PDYft8tuc06__k9q+XeOB64h_0_p1Y_GTn7hKZA@mail.gmail.com>
FTR, using updated email addresses for agraf and sjg.
On 2019-04-09, Jordan Hand wrote:
> On Mon, Apr 8, 2019 at 9:54 PM Vagrant Cascadian <vagrant@debian.org> wrote:
>>
>> This reverts commit d32aa3cae44e618048ff7f378577d44f9b6d6dcc.
>>
>> This breaks the "list_image" test in tests/image/test-imagetools.sh,
>> where mkimage and dumpimage are expected to have the same output:
>>
>> Listing image contents...
>> # debian/build/tools/tools/mkimage -l linux.itb
>> debian/build/tools/tools/mkimage: verify_header failed for Default Image support with exit code -9
>>
>> Obviously, blindly reverting this patch may not the best way forward,
>
> I'll take a look at this today and see if there's a simple way forward
> without reverting
Thanks!
>> but the same verify_header failed message occurs also with some
>> real-world .itb files, such as that used on the pinebook. So it's not
>
> Would you be able to point me to any .its files that fail this check
> in the real world.
The one created by: board/sunxi/mksunxi_fit_atf.sh
I haven't confirmed, but I would guess possibly also:
arch/arm/mach-rockchip/make_fit_atf.py
If needed, I can try to get some actual .its/.itb files to work with.
> Also are you seeing failures while creating the image from its as well
> with real world images (mkimage -l its itb) or only when listing the
> header with -l?
It *seems* to create the images just fine; apparently only when listing
them. The output of "dumpimage -l" and "mkimage -l" used to be the same,
and "dumpimage -l" still works fine.
live well,
vagrant
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 227 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190409/2f93d3fe/attachment.sig>
prev parent reply other threads:[~2019-04-09 18:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-09 4:54 [U-Boot] [PATCH] Revert "fdt: Fix FIT header verification in mkimage and conduct same checks as bootm" Vagrant Cascadian
2019-04-09 16:38 ` Jordan Hand
2019-04-09 17:47 ` Jordan Hand
2019-04-09 18:04 ` Vagrant Cascadian [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d0lv838j.fsf@ponder \
--to=vagrant@debian.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.