From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Anholt Subject: Re: [PATCH 1/4] drm/v3d: Add a note about OOM vs FRDONE, which may be racing on v3.3. Date: Fri, 22 Mar 2019 14:32:44 -0700 Message-ID: <87d0mi388z.fsf@anholt.net> References: <20190313235211.28995-1-eric@anholt.net> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Dave Emett Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Thomas Spurden List-Id: dri-devel@lists.freedesktop.org --=-=-= Content-Type: text/plain Dave Emett writes: > On Wed, 13 Mar 2019 at 23:52, Eric Anholt wrote: >> >> We deref v3d->bin_job in the work handler, but v3d->bin_job doesn't >> actually hold a ref on the job. >> >> Signed-off-by: Eric Anholt > Reviewed-by: Dave Emett > >> --- >> drivers/gpu/drm/v3d/v3d_irq.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/v3d/v3d_irq.c b/drivers/gpu/drm/v3d/v3d_irq.c >> index b4d6ae81186d..a09442ec7297 100644 >> --- a/drivers/gpu/drm/v3d/v3d_irq.c >> +++ b/drivers/gpu/drm/v3d/v3d_irq.c >> @@ -87,7 +87,8 @@ v3d_irq(int irq, void *arg) >> if (intsts & V3D_INT_OUTOMEM) { >> /* Note that the OOM status is edge signaled, so the >> * interrupt won't happen again until the we actually >> - * add more memory. >> + * add more memory. Also, as of V3D 4.1, FRDONE won't >> + * be reported until any OOM state has been cleared. > Strictly speaking it's FLDONE for bins. Fixed, thanks. I'm applying the first 2 of the series for now. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAlyVVH0ACgkQtdYpNtH8 nuiD/hAAnqi/pyh5g+qPMyvsPFptn5iGmBRB0XTvEFlsIw9yb/NGc+PGjGlISymi W5VLmYxN+beMCG5LKZriIWre3x5nyuAWvxfUbh8WdlmV1ieB7apqLoDwfI0Y78MP yzAw013nPLEV5ghuC6s4fUcJn+OttXFPnyrzXwTu4ro4UKApfV5/rSvQRSKmpkJ+ l372h38SgW86FWi51mvlAh62U03O1UuFZMeBIvhAzgJUCngfgEH2Q9v2F75YQrhG fSWnkuIEMqMb+2dM1tEkVpqt4gBJ5OHNlYfJNycNU+qIYbT6CaVdGhzRhwNsG6rH FbKY1fYVvBaAhc5A2SRokig+Zu548+iFZjK5V7FHR168VUfEC1NrCt0ujEE3BD62 gvJrc6/tNHqGecGP0Y2DaW11TqPEnPoAc4YWTJ66asQ80gwO/R+opfVuzLp1bM98 zYPixTI99mp2PSaLmgSQkCxCKJTUiS0yklgGf/Cq1aOn+KnaBtf6d9l0MRjPxXIu QbuLlIHPxdoj6bkNeV50mqoAdQLIdF6hTexLrsu/ZyXaWnB7a+0IvV6taUSJe4RS pa3oeVO8wAeDS8FywTLGV5one4y7lpuhsu20zvFRF2BGBCrUhnSgCUZmnI4siLVo RMswNVqzCaw8Ew3U17dCXqs25IKEskDeuG5jI7IwiwN0jP9BrUo= =fGyR -----END PGP SIGNATURE----- --=-=-=--