From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jani Nikula <jani.nikula@intel.com>
Subject: Re: [PATCH 2/2] drm/i915/dp: use single point of truth
 for PPS divisor register
Date: Fri, 08 Mar 2019 13:35:23 +0200
Message-ID: <87d0n17g5g.fsf@intel.com>
References: <20190305135215.29862-1-jani.nikula@intel.com>
 <20190305135215.29862-2-jani.nikula@intel.com>
 <20190305202254.GS10303@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga12.intel.com (mga12.intel.com [192.55.52.136])
 by gabe.freedesktop.org (Postfix) with ESMTPS id ECDC889385
 for <intel-gfx@lists.freedesktop.org>; Fri,  8 Mar 2019 11:35:25 +0000 (UTC)
In-Reply-To: <20190305202254.GS10303@intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gVHVlLCAwNSBNYXIgMjAxOSwgUm9kcmlnbyBWaXZpIDxyb2RyaWdvLnZpdmlAaW50ZWwuY29t
PiB3cm90ZToKPiBPbiBUdWUsIE1hciAwNSwgMjAxOSBhdCAwMzo1MjoxNVBNICswMjAwLCBKYW5p
IE5pa3VsYSB3cm90ZToKPj4gU2V0IHBwX2RpdiBmaWVsZCBvZiBzdHJ1Y3QgcHBzX3JlZ2lzdGVy
cyB0byBJTlZBTElEX01NSU9fUkVHIHdoZW4gdGhlCj4+IHJlZ2lzdGVyIGlzbid0IHRoZXJlLCBh
bmQgdXNlIGk5MTVfbW1pb19yZWdfdmFsaWQoKSBpbnN0ZWFkIG9mIHJlcGVhdGluZwo+PiB0aGUg
Y29uZGl0aW9uIGFsbCBvdmVyIHRoZSBwbGFjZS4KPj4gCj4+IFVzZSBJTlZBTElEX01NSU9fUkVH
IGV4cGxpY2l0bHkgZm9yIGRvY3VtZW50YXRpb24gcHVycG9zZXMsIGV2ZW4gaWYgdGhlCj4+IHZh
bHVlIGlzIHVuY2hhbmdlZCBmcm9tIDAuCj4KPiBncmVhdCBjbGVhbiB1cC4gVGhhbmtzIGZvciB0
aGF0Lgo+Cj4KPiBSZXZpZXdlZC1ieTogUm9kcmlnbyBWaXZpIDxyb2RyaWdvLnZpdmlAaW50ZWwu
Y29tPgoKVGhhbmtzIGZvciB0aGUgcmV2aWV3cywgcHVzaGVkIHRvIGRpbnEuCgpCUiwKSmFuaS4K
Cj4KPgo+Cj4+IAo+PiBDYzogUm9kcmlnbyBWaXZpIDxyb2RyaWdvLnZpdmlAaW50ZWwuY29tPgo+
PiBDYzogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPj4g
U2lnbmVkLW9mZi1ieTogSmFuaSBOaWt1bGEgPGphbmkubmlrdWxhQGludGVsLmNvbT4KPj4gLS0t
Cj4+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jIHwgNzMgKysrKysrKysrKysrKysr
KysrLS0tLS0tLS0tLS0tLS0tCj4+ICAxIGZpbGUgY2hhbmdlZCwgMzkgaW5zZXJ0aW9ucygrKSwg
MzQgZGVsZXRpb25zKC0pCj4+IAo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUv
aW50ZWxfZHAuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMKPj4gaW5kZXggZTBm
NDIxZTc2MzA1Li5mNDBiMzM0MmQ4MmEgMTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9p
OTE1L2ludGVsX2RwLmMKPj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYwo+
PiBAQCAtOTQ5LDggKzk0OSwxMiBAQCBzdGF0aWMgdm9pZCBpbnRlbF9wcHNfZ2V0X3JlZ2lzdGVy
cyhzdHJ1Y3QgaW50ZWxfZHAgKmludGVsX2RwLAo+PiAgCXJlZ3MtPnBwX3N0YXQgPSBQUF9TVEFU
VVMocHBzX2lkeCk7Cj4+ICAJcmVncy0+cHBfb24gPSBQUF9PTl9ERUxBWVMocHBzX2lkeCk7Cj4+
ICAJcmVncy0+cHBfb2ZmID0gUFBfT0ZGX0RFTEFZUyhwcHNfaWR4KTsKPj4gLQlpZiAoIUlTX0dF
TjlfTFAoZGV2X3ByaXYpICYmICFIQVNfUENIX0NOUChkZXZfcHJpdikgJiYKPj4gLQkgICAgIUhB
U19QQ0hfSUNQKGRldl9wcml2KSkKPj4gKwo+PiArCS8qIEN5Y2xlIGRlbGF5IG1vdmVkIGZyb20g
UFBfRElWSVNPUiB0byBQUF9DT05UUk9MICovCj4+ICsJaWYgKElTX0dFTjlfTFAoZGV2X3ByaXYp
IHx8IEhBU19QQ0hfQ05QKGRldl9wcml2KSB8fAo+PiArCSAgICBIQVNfUENIX0lDUChkZXZfcHJp
dikpCj4+ICsJCXJlZ3MtPnBwX2RpdiA9IElOVkFMSURfTU1JT19SRUc7Cj4+ICsJZWxzZQo+PiAg
CQlyZWdzLT5wcF9kaXYgPSBQUF9ESVZJU09SKHBwc19pZHgpOwo+PiAgfQo+PiAgCj4+IEBAIC02
NDIwLDcgKzY0MjQsNyBAQCBzdGF0aWMgdm9pZAo+PiAgaW50ZWxfcHBzX3JlYWRvdXRfaHdfc3Rh
dGUoc3RydWN0IGludGVsX2RwICppbnRlbF9kcCwgc3RydWN0IGVkcF9wb3dlcl9zZXEgKnNlcSkK
Pj4gIHsKPj4gIAlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSBkcF90b19pOTE1
KGludGVsX2RwKTsKPj4gLQl1MzIgcHBfb24sIHBwX29mZiwgcHBfZGl2ID0gMCwgcHBfY3RsID0g
MDsKPj4gKwl1MzIgcHBfb24sIHBwX29mZiwgcHBfY3RsOwo+PiAgCXN0cnVjdCBwcHNfcmVnaXN0
ZXJzIHJlZ3M7Cj4+ICAKPj4gIAlpbnRlbF9wcHNfZ2V0X3JlZ2lzdGVycyhpbnRlbF9kcCwgJnJl
Z3MpOwo+PiBAQCAtNjQzMywxMCArNjQzNyw2IEBAIGludGVsX3Bwc19yZWFkb3V0X2h3X3N0YXRl
KHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHAsIHN0cnVjdCBlZHBfcG93ZXJfc2VxICpzZXEpCj4+
ICAKPj4gIAlwcF9vbiA9IEk5MTVfUkVBRChyZWdzLnBwX29uKTsKPj4gIAlwcF9vZmYgPSBJOTE1
X1JFQUQocmVncy5wcF9vZmYpOwo+PiAtCWlmICghSVNfR0VOOV9MUChkZXZfcHJpdikgJiYgIUhB
U19QQ0hfQ05QKGRldl9wcml2KSAmJgo+PiAtCSAgICAhSEFTX1BDSF9JQ1AoZGV2X3ByaXYpKSB7
Cj4+IC0JCXBwX2RpdiA9IEk5MTVfUkVBRChyZWdzLnBwX2Rpdik7Cj4+IC0JfQo+PiAgCj4+ICAJ
LyogUHVsbCB0aW1pbmcgdmFsdWVzIG91dCBvZiByZWdpc3RlcnMgKi8KPj4gIAlzZXEtPnQxX3Qz
ID0gKHBwX29uICYgUEFORUxfUE9XRVJfVVBfREVMQVlfTUFTSykgPj4KPj4gQEAgLTY0NTEsMTMg
KzY0NTEsMTcgQEAgaW50ZWxfcHBzX3JlYWRvdXRfaHdfc3RhdGUoc3RydWN0IGludGVsX2RwICpp
bnRlbF9kcCwgc3RydWN0IGVkcF9wb3dlcl9zZXEgKnNlcSkKPj4gIAlzZXEtPnQxMCA9IChwcF9v
ZmYgJiBQQU5FTF9QT1dFUl9ET1dOX0RFTEFZX01BU0spID4+Cj4+ICAJCSAgIFBBTkVMX1BPV0VS
X0RPV05fREVMQVlfU0hJRlQ7Cj4+ICAKPj4gLQlpZiAoSVNfR0VOOV9MUChkZXZfcHJpdikgfHwg
SEFTX1BDSF9DTlAoZGV2X3ByaXYpIHx8Cj4+IC0JICAgIEhBU19QQ0hfSUNQKGRldl9wcml2KSkg
ewo+PiArCWlmIChpOTE1X21taW9fcmVnX3ZhbGlkKHJlZ3MucHBfZGl2KSkgewo+PiArCQl1MzIg
cHBfZGl2Owo+PiArCj4+ICsJCXBwX2RpdiA9IEk5MTVfUkVBRChyZWdzLnBwX2Rpdik7Cj4+ICsK
Pj4gKwkJc2VxLT50MTFfdDEyID0gKChwcF9kaXYgJiBQQU5FTF9QT1dFUl9DWUNMRV9ERUxBWV9N
QVNLKSA+Pgo+PiArCQkJCVBBTkVMX1BPV0VSX0NZQ0xFX0RFTEFZX1NISUZUKSAqIDEwMDA7Cj4+
ICsKPj4gKwl9IGVsc2Ugewo+PiAgCQlzZXEtPnQxMV90MTIgPSAoKHBwX2N0bCAmIEJYVF9QT1dF
Ul9DWUNMRV9ERUxBWV9NQVNLKSA+Pgo+PiAgCQkJCUJYVF9QT1dFUl9DWUNMRV9ERUxBWV9TSElG
VCkgKiAxMDAwOwo+PiAtCX0gZWxzZSB7Cj4+IC0JCXNlcS0+dDExX3QxMiA9ICgocHBfZGl2ICYg
UEFORUxfUE9XRVJfQ1lDTEVfREVMQVlfTUFTSykgPj4KPj4gLQkJICAgICAgIFBBTkVMX1BPV0VS
X0NZQ0xFX0RFTEFZX1NISUZUKSAqIDEwMDA7Cj4+ICAJfQo+PiAgfQo+PiAgCj4+IEBAIC02NTgy
LDcgKzY1ODYsNyBAQCBpbnRlbF9kcF9pbml0X3BhbmVsX3Bvd2VyX3NlcXVlbmNlcl9yZWdpc3Rl
cnMoc3RydWN0IGludGVsX2RwICppbnRlbF9kcCwKPj4gIAkJCQkJICAgICAgYm9vbCBmb3JjZV9k
aXNhYmxlX3ZkZCkKPj4gIHsKPj4gIAlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYg
PSBkcF90b19pOTE1KGludGVsX2RwKTsKPj4gLQl1MzIgcHBfb24sIHBwX29mZiwgcHBfZGl2LCBw
b3J0X3NlbCA9IDA7Cj4+ICsJdTMyIHBwX29uLCBwcF9vZmYsIHBvcnRfc2VsID0gMDsKPj4gIAlp
bnQgZGl2ID0gZGV2X3ByaXYtPnJhd2Nsa19mcmVxIC8gMTAwMDsKPj4gIAlzdHJ1Y3QgcHBzX3Jl
Z2lzdGVycyByZWdzOwo+PiAgCWVudW0gcG9ydCBwb3J0ID0gZHBfdG9fZGlnX3BvcnQoaW50ZWxf
ZHApLT5iYXNlLnBvcnQ7Cj4+IEBAIC02NjIxLDE5ICs2NjI1LDYgQEAgaW50ZWxfZHBfaW5pdF9w
YW5lbF9wb3dlcl9zZXF1ZW5jZXJfcmVnaXN0ZXJzKHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHAs
Cj4+ICAJCShzZXEtPnQ4IDw8IFBBTkVMX0xJR0hUX09OX0RFTEFZX1NISUZUKTsKPj4gIAlwcF9v
ZmYgPSAoc2VxLT50OSA8PCBQQU5FTF9MSUdIVF9PRkZfREVMQVlfU0hJRlQpIHwKPj4gIAkJIChz
ZXEtPnQxMCA8PCBQQU5FTF9QT1dFUl9ET1dOX0RFTEFZX1NISUZUKTsKPj4gLQkvKiBDb21wdXRl
IHRoZSBkaXZpc29yIGZvciB0aGUgcHAgY2xvY2ssIHNpbXBseSBtYXRjaCB0aGUgQnNwZWMKPj4g
LQkgKiBmb3JtdWxhLiAqLwo+PiAtCWlmIChJU19HRU45X0xQKGRldl9wcml2KSB8fCBIQVNfUENI
X0NOUChkZXZfcHJpdikgfHwKPj4gLQkgICAgSEFTX1BDSF9JQ1AoZGV2X3ByaXYpKSB7Cj4+IC0J
CXBwX2RpdiA9IEk5MTVfUkVBRChyZWdzLnBwX2N0cmwpOwo+PiAtCQlwcF9kaXYgJj0gfkJYVF9Q
T1dFUl9DWUNMRV9ERUxBWV9NQVNLOwo+PiAtCQlwcF9kaXYgfD0gKERJVl9ST1VORF9VUChzZXEt
PnQxMV90MTIsIDEwMDApCj4+IC0JCQkJPDwgQlhUX1BPV0VSX0NZQ0xFX0RFTEFZX1NISUZUKTsK
Pj4gLQl9IGVsc2Ugewo+PiAtCQlwcF9kaXYgPSAoKDEwMCAqIGRpdikvMiAtIDEpIDw8IFBQX1JF
RkVSRU5DRV9ESVZJREVSX1NISUZUOwo+PiAtCQlwcF9kaXYgfD0gKERJVl9ST1VORF9VUChzZXEt
PnQxMV90MTIsIDEwMDApCj4+IC0JCQkJPDwgUEFORUxfUE9XRVJfQ1lDTEVfREVMQVlfU0hJRlQp
Owo+PiAtCX0KPj4gIAo+PiAgCS8qIEhhc3dlbGwgZG9lc24ndCBoYXZlIGFueSBwb3J0IHNlbGVj
dGlvbiBiaXRzIGZvciB0aGUgcGFuZWwKPj4gIAkgKiBwb3dlciBzZXF1ZW5jZXIgYW55IG1vcmUu
ICovCj4+IEBAIC02NjYwLDE5ICs2NjUxLDMzIEBAIGludGVsX2RwX2luaXRfcGFuZWxfcG93ZXJf
c2VxdWVuY2VyX3JlZ2lzdGVycyhzdHJ1Y3QgaW50ZWxfZHAgKmludGVsX2RwLAo+PiAgCj4+ICAJ
STkxNV9XUklURShyZWdzLnBwX29uLCBwcF9vbik7Cj4+ICAJSTkxNV9XUklURShyZWdzLnBwX29m
ZiwgcHBfb2ZmKTsKPj4gLQlpZiAoSVNfR0VOOV9MUChkZXZfcHJpdikgfHwgSEFTX1BDSF9DTlAo
ZGV2X3ByaXYpIHx8Cj4+IC0JICAgIEhBU19QQ0hfSUNQKGRldl9wcml2KSkKPj4gLQkJSTkxNV9X
UklURShyZWdzLnBwX2N0cmwsIHBwX2Rpdik7Cj4+IC0JZWxzZQo+PiArCj4+ICsJLyoKPj4gKwkg
KiBDb21wdXRlIHRoZSBkaXZpc29yIGZvciB0aGUgcHAgY2xvY2ssIHNpbXBseSBtYXRjaCB0aGUg
QnNwZWMgZm9ybXVsYS4KPj4gKwkgKi8KPj4gKwlpZiAoaTkxNV9tbWlvX3JlZ192YWxpZChyZWdz
LnBwX2RpdikpIHsKPj4gKwkJdTMyIHBwX2RpdjsKPj4gKwo+PiArCQlwcF9kaXYgPSAoKDEwMCAq
IGRpdikgLyAyIC0gMSkgPDwgUFBfUkVGRVJFTkNFX0RJVklERVJfU0hJRlQ7Cj4+ICsJCXBwX2Rp
diB8PSAoRElWX1JPVU5EX1VQKHNlcS0+dDExX3QxMiwgMTAwMCkgPDwKPj4gKwkJCSAgIFBBTkVM
X1BPV0VSX0NZQ0xFX0RFTEFZX1NISUZUKTsKPj4gIAkJSTkxNV9XUklURShyZWdzLnBwX2Rpdiwg
cHBfZGl2KTsKPj4gKwl9IGVsc2Ugewo+PiArCQl1MzIgcHBfY3RsOwo+PiArCj4+ICsJCXBwX2N0
bCA9IEk5MTVfUkVBRChyZWdzLnBwX2N0cmwpOwo+PiArCQlwcF9jdGwgJj0gfkJYVF9QT1dFUl9D
WUNMRV9ERUxBWV9NQVNLOwo+PiArCQlwcF9jdGwgfD0gKERJVl9ST1VORF9VUChzZXEtPnQxMV90
MTIsIDEwMDApIDw8Cj4+ICsJCQkgICBCWFRfUE9XRVJfQ1lDTEVfREVMQVlfU0hJRlQpOwo+PiAr
CQlJOTE1X1dSSVRFKHJlZ3MucHBfY3RybCwgcHBfY3RsKTsKPj4gKwl9Cj4+ICAKPj4gIAlEUk1f
REVCVUdfS01TKCJwYW5lbCBwb3dlciBzZXF1ZW5jZXIgcmVnaXN0ZXIgc2V0dGluZ3M6IFBQX09O
ICUjeCwgUFBfT0ZGICUjeCwgUFBfRElWICUjeFxuIiwKPj4gIAkJICAgICAgSTkxNV9SRUFEKHJl
Z3MucHBfb24pLAo+PiAgCQkgICAgICBJOTE1X1JFQUQocmVncy5wcF9vZmYpLAo+PiAtCQkgICAg
ICAoSVNfR0VOOV9MUChkZXZfcHJpdikgfHwgSEFTX1BDSF9DTlAoZGV2X3ByaXYpICB8fAo+PiAt
CQkgICAgICAgSEFTX1BDSF9JQ1AoZGV2X3ByaXYpKSA/Cj4+IC0JCSAgICAgIChJOTE1X1JFQUQo
cmVncy5wcF9jdHJsKSAmIEJYVF9QT1dFUl9DWUNMRV9ERUxBWV9NQVNLKSA6Cj4+IC0JCSAgICAg
IEk5MTVfUkVBRChyZWdzLnBwX2RpdikpOwo+PiArCQkgICAgICBpOTE1X21taW9fcmVnX3ZhbGlk
KHJlZ3MucHBfZGl2KSA/Cj4+ICsJCSAgICAgIEk5MTVfUkVBRChyZWdzLnBwX2RpdikgOgo+PiAr
CQkgICAgICAoSTkxNV9SRUFEKHJlZ3MucHBfY3RybCkgJiBCWFRfUE9XRVJfQ1lDTEVfREVMQVlf
TUFTSykpOwo+PiAgfQo+PiAgCj4+ICBzdGF0aWMgdm9pZCBpbnRlbF9kcF9wcHNfaW5pdChzdHJ1
Y3QgaW50ZWxfZHAgKmludGVsX2RwKQo+PiAtLSAKPj4gMi4yMC4xCj4+IAoKLS0gCkphbmkgTmlr
dWxhLCBJbnRlbCBPcGVuIFNvdXJjZSBHcmFwaGljcyBDZW50ZXIKX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRl
bC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3Jn
L21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4