From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail.toke.dk ([52.28.52.200]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gwrwb-0005bQ-D0 for ath10k@lists.infradead.org; Thu, 21 Feb 2019 17:15:35 +0000 From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= Subject: Re: [PATCH v2 2/2] ath10k: Set sk_pacing_shift to 6 for 11AC WiFi chips In-Reply-To: <587631dd-f96a-999a-d61d-e5df5796766f@candelatech.com> References: <1533724802-30944-1-git-send-email-wgong@codeaurora.org> <1533724802-30944-3-git-send-email-wgong@codeaurora.org> <87sh3pdtpg.fsf@toke.dk> <87mutue4y8.fsf@toke.dk> <1535967508.3437.31.camel@sipsolutions.net> <87in3m25uu.fsf@toke.dk> <1535975240.3437.61.camel@sipsolutions.net> <878t4i1z74.fsf@toke.dk> <871sa7ylmi.fsf@toke.dk> <87r2c1i1vj.fsf@toke.dk> <871s41nmvx.fsf@kamboji.qca.qualcomm.com> <87ftshhzby.fsf@toke.dk> <587631dd-f96a-999a-d61d-e5df5796766f@candelatech.com> Date: Thu, 21 Feb 2019 18:15:30 +0100 Message-ID: <87d0nlhxl9.fsf@toke.dk> MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Ben Greear , Kalle Valo Cc: Kan Yan , wgong@qti.qualcomm.com, linux-wireless@vger.kernel.org, ath10k@lists.infradead.org, Grant Grundler , wgong@codeaurora.org, Johannes Berg QmVuIEdyZWVhciA8Z3JlZWFyYkBjYW5kZWxhdGVjaC5jb20+IHdyaXRlczoKCj4gT24gMi8yMS8x OSA4OjM3IEFNLCBUb2tlIEjDuGlsYW5kLUrDuHJnZW5zZW4gd3JvdGU6Cj4+IEJlbiBHcmVlYXIg PGdyZWVhcmJAY2FuZGVsYXRlY2guY29tPiB3cml0ZXM6Cj4+IAo+Pj4gT24gMi8yMS8xOSA4OjEw IEFNLCBLYWxsZSBWYWxvIHdyb3RlOgo+Pj4+IFRva2UgSMO4aWxhbmQtSsO4cmdlbnNlbiA8dG9r ZUB0b2tlLmRrPiB3cml0ZXM6Cj4+Pj4KPj4+Pj4gR3JhbnQgR3J1bmRsZXIgPGdydW5kbGVyQGdv b2dsZS5jb20+IHdyaXRlczoKPj4+Pj4KPj4+Pj4+IE9uIFRodSwgU2VwIDYsIDIwMTggYXQgMzox OCBBTSBUb2tlIEjDuGlsYW5kLUrDuHJnZW5zZW4gPHRva2VAdG9rZS5kaz4gd3JvdGU6Cj4+Pj4+ Pj4KPj4+Pj4+PiBHcmFudCBHcnVuZGxlciA8Z3J1bmRsZXJAZ29vZ2xlLmNvbT4gd3JpdGVzOgo+ Pj4+Pj4+Cj4+Pj4+Pj4+PiBBbmQsIHdlbGwsIEdyYW50J3MgZGF0YSBpcyBmcm9tIGEgc2luZ2xl IHRlc3QgaW4gYSBub2lzeQo+Pj4+Pj4+Pj4gZW52aXJvbm1lbnQgd2hlcmUgdGhlIHRpbWUgc2Vy aWVzIGdyYXBoIHNob3dzIHRoYXQgdGhyb3VnaHB1dCBpcyBhbGwgb3Zlcgo+Pj4+Pj4+Pj4gdGhl IHBsYWNlIGZvciB0aGUgZHVyYXRpb24gb2YgdGhlIHRlc3Q7IHNvIGl0J3MgaGFyZCB0byBkcmF3 IHNvbGlkCj4+Pj4+Pj4+PiBjb25jbHVzaW9ucyBmcm9tIChmb3IgaW5zdGFuY2UsIGZvciB0aGUg NS1zdHJlYW0gdGVzdCwgdGhlIGF2ZXJhZ2UKPj4+Pj4+Pj4+IHRocm91Z2hwdXQgZm9yIDYgaXMg MzMxIGFuZCAzNzkgTWJwcyBmb3IgdGhlIHR3byByZXBldGl0aW9ucywgYW5kIGZvciA3Cj4+Pj4+ Pj4+PiBpdCdzIDMyNiBhbmQgMzcxIE1icHMpIC4gVW5mb3J0dW5hdGVseSBJIGRvbid0IGhhdmUg dGhlIHNhbWUgaGFyZHdhcmUKPj4+Pj4+Pj4+IHVzZWQgaW4gdGhpcyB0ZXN0LCBzbyBJIGNhbid0 IGdvIHZlcmlmeSBpdCBteXNlbGY7IHNvIHRoZSBvbmx5IHRoaW5nIEkKPj4+Pj4+Pj4+IGNhbiBk byBpcyBncnVtYmxlIGFib3V0IGl0IGhlcmUuLi4gOikKPj4+Pj4+Pj4KPj4+Pj4+Pj4gSXQncyBh IGZhaXIgY29tcGxhaW50IGFuZCBJIGFncmVlIHdpdGggaXQuIE15IGNvdW50ZXIgYXJndW1lbnQg aXMgdGhlCj4+Pj4+Pj4+IG9wcG9zaXRlIGlzIHRydWUgdG9vOiBtb3N0IGlkZWFsIGJlbmNobWFy a3MgZG9uJ3QgbWVhc3VyZSB3aGF0IG1vc3QKPj4+Pj4+Pj4gdXNlcnMgc2VlLiBXaGlsZSB0aGUg ZGF0YSB3Z29uZyBwcm92aWRlZCBhcmUgd2F5IG1vcmUgbm9pc3kgdGhhbiBJCj4+Pj4+Pj4+IGxp a2UsIG15IG92ZXJhbGwgImNvbmZpZGVuY2UiIGluIHRoZSAiY29uY2x1c2lvbiIgSSBvZmZlcmVk IGlzIHN0aWxsCj4+Pj4+Pj4+IHBvc2l0aXZlLgo+Pj4+Pj4+Cj4+Pj4+Pj4gUmlnaHQuIEkgZ3Vl c3MgSSB3b3VsZCBqdXN0IHByZWZlciBhIHNsaWdodGx5IG1vcmUgY29tcHJlaGVuc2l2ZQo+Pj4+ Pj4+IGV2YWx1YXRpb24gdG8gYmFzZSBhIDR4IGluY3JlYXNlIGluIGJ1ZmZlciBzaXplIG9uLi4u Cj4+Pj4+Pgo+Pj4+Pj4gS2FsbGUsIGlzIHRoaXMgd2h5IHlvdSBkaWRuJ3QgYWNjZXB0IHRoaXMg cGF0Y2g/IE90aGVyIHJlYXNvbnM/Cj4+Pj4+Pgo+Pj4+Pj4gVG9rZSwgd2hhdCBlbHNlIHdvdWxk IHlvdSBsaWtlIHRvIHNlZSBldmFsdWF0ZWQ/Cj4+Pj4+Pgo+Pj4+Pj4gSSBnZW5lcmFsbHkgd2Fu dCB0byBzZWUgdGhyZWUgdGhpbmdzIG1lYXN1cmVkIHdoZW4gImJlbmNobWFya2luZyIKPj4+Pj4+ IHRlY2hub2xvZ2llczogdGhyb3VnaHB1dCwgbGF0ZW5jeSwgY3B1IHV0aWxpemF0aW9uCj4+Pj4+ PiBXZSd2ZSBjb3ZlcmVkIHRob3NlIHRocmVlIEkgdGhpbmsgInJlYXNvbmFibHkiLgo+Pj4+Pgo+ Pj4+PiBIbW0sIGdvaW5nIGJhY2sgYW5kIGxvb2tpbmcgYXQgdGhpcyAoSSdkIGNvbXBsZXRlbHkg Zm9yZ290dGVuIGFib3V0IHRoaXMKPj4+Pj4gcGF0Y2gpLCBJIHRoaW5rIEkgaGFkIHR3byBtYWlu IGNvbmNlcm5zOgo+Pj4+Pgo+Pj4+PiAxLiBXaGF0IGhhcHBlbnMgaW4gYSBkZWdyYWRlZCBzaWdu YWwgc2l0dWF0aW9uLCB3aGVyZSB0aGUgdGhyb3VnaHB1dCBpcwo+Pj4+PiAgICAgIGxpbWl0ZWQg YnkgdGhlIHNpZ25hbCBjb25kaXRpb25zLCBvciBieSBjb250ZW50aW9uIHdpdGggb3RoZXIgZGV2 aWNlcy4KPj4+Pj4gICAgICBCb3RoIG9mIHRoZXNlIGhhcHBlbiByZWd1bGFybHksIGFuZCBJIHdv cnJ5IHRoYXQgbGF0ZW5jeSB3aWxsIGJlCj4+Pj4+ICAgICAgYmFkbHkgYWZmZWN0ZWQgdW5kZXIg dGhvc2UgY29uZGl0aW9ucy4KPj4+Pj4KPj4+Pj4gMi4gV2hhdCBoYXBwZW5zIHdpdGggb2xkIGhh cmR3YXJlIHRoYXQgaGFzIHdvcnNlIGJ1ZmZlciBtYW5hZ2VtZW50IGluCj4+Pj4+ICAgICAgdGhl IGRyaXZlci0+ZmlybXdhcmUgcGF0aCAoZXNwZWNpYWxseSBkcml2ZXJzIHdpdGhvdXQgcHVzaC9w dWxsIG1vZGUKPj4+Pj4gICAgICBzdXBwb3J0KT8gRm9yIHRoZXNlLCB0aGUgbG93ZXItbGV2ZWwg cXVldWVpbmcgc3RydWN0dXJlIGlzIGxlc3MKPj4+Pj4gICAgICBlZmZlY3RpdmUgYXQgY29udHJv bGxpbmcgcXVldWVpbmcgbGF0ZW5jeS4KPj4+Pgo+Pj4+IERvIG5vdGUgdGhhdCB0aGlzIHBhdGNo IGNoYW5nZXMgYmVoYXZpb3VyIF9vbmx5XyBmb3IgUUNBNjE3NCBhbmQgUUNBOTM3Nwo+Pj4+IFBD SSBkZXZpY2VzLCB3aGljaCBJSVJDIGRvIG5vdCBldmVuIHN1cHBvcnQgcHVzaC9wdWxsIG1vZGUu IEFsbCB0aGUKPj4+PiByZXN0LCBpbmNsdWRpbmcgUUNBOTg4WCBhbmQgUUNBOTk4NCBhcmUgdW5h ZmZlY3RlZC4KPj4+Cj4+PiBKdXN0IGFzIGEgbm90ZSwgYXQgbGVhc3Qga2VybmVscyBzdWNoIGFz IDQuMTQud2hhdGV2ZXIgcGVyZm9ybSBwb29ybHkgd2hlbgo+Pj4gcnVubmluZyBhdGgxMGsgb24g OTk4NCB3aGVuIGFjdGluZyBhcyBUQ1AgZW5kcG9pbnRzLiAgVGhpcyBtYWtlcyB0aGVtIG5vdAo+ Pj4gcmVhbGx5IHVzYWJsZSBmb3Igc3R1ZmYgbGlrZSBzZXJ2aW5nIHZpZGVvIHRvIGxvdHMgb2Yg Y2xpZW50cy4KPj4+Cj4+PiBUd2Vha2luZyBUQ1AgKEkgZG8gaXQgYSBiaXQgZGlmZmVyZW50bHks IGJ1dCBlaXRoZXIgd2F5KSBjYW4gc2lnbmlmaWNhbnRseQo+Pj4gaW1wcm92ZSBwZXJmb3JtYW5j ZS4KPj4gCj4+IERpZmZlcmVudGx5IGhvdz8gRGlkIHlvdSBoYXZlIHRvIGRvIG1vcmUgdGhhbiBm aWRkbGUgd2l0aCB0aGUgcGFjaW5nX3NoaWZ0Pwo+Cj4gVGhpcyBvbmUsIG9yIGEgc2xpZ2h0bHkg dHdlYWtlZCB2ZXJzaW9uIHRoYXQgYXBwbGllcyB0byBkaWZmZXJlbnQga2VybmVsczoKPgo+IGh0 dHBzOi8vZ2l0aHViLmNvbS9ncmVlYXJiL2xpbnV4LWN0LTQuMTYvY29tbWl0LzNlMTRlODQ5MWE1 YjMxY2U5OTRmYjI3NTIzNDcxNDVlNmFiN2VhZjUKClJpZ2h0OyBidXQgdGhlIGN1cnJlbnQgbWFj ODAyMTEgZGVmYXVsdCAocGFjaW5nIHNoaWZ0IDgpIGNvcnJlc3BvbmRzIHRvCnNldHRpbmcgeW91 ciBzeXNjdGwgdG8gNC4uLgoKPj4+IFJlY2VudGx5IEkgaGVscGVkIGEgdXNlciB0aGF0IGNvdWxk IGdldCBiYXJlbHkgNzAgc3RhdGlvbnMgc3RyZWFtaW5nCj4+PiBhdCAxTWJwcyBvbiBzdG9jayBr ZXJuZWwgKHVzaW5nIG9uZSB3YXZlMSBvbiAyLjQsIG9uZSB3YXZlLTIgb24gNUdoeiksCj4+PiBh bmQgd2UgZ290IDExMCB3b3JraW5nIHdpdGggYSB0d2Vha2VkIFRDUCBzdGFjay4gVGhlc2Ugd2Vy ZSAvbgo+Pj4gc3RhdGlvbnMgdG9vLgo+Pj4KPj4+IEkgdGhpbmsgaXQgaXMgbGFtZSB0aGF0IGl0 IF9zdGlsbF8gcmVxdWlyZXMgb3V0IG9mIHRyZWUgcGF0Y2hlcyB0bwo+Pj4gbWFrZSBUQ1Agd29y ayB3ZWxsIG9uIGF0aDEway4uLmV2ZW4gaWYgeW91IHdhbnQgdG8gZGVmYXVsdCB0byBjdXJyZW50 Cj4+PiBiZWhhdmlvdXIsIHlvdSBzaG91bGQgYWxsb3cgdXNlcnMgdG8gdHdlYWsgaXQgdG8gd29y ayB3aXRoIHRoZWlyIHVzZQo+Pj4gY2FzZS4KPj4gCj4+IFdlbGwgaWYgVENQIGlzIGJyb2tlbiB0 byB0aGUgcG9pbnQgb2YgYmVpbmcgdW51c2FibGUgSSBkbyB0aGluayB3ZQo+PiBzaG91bGQgZml4 IGl0OyBidXQgSSB0aGluayAianVzdCBwcm92aWRlIGEgY29uZmlndXJhdGlvbiBrbm9iIiBzaG91 bGQgYmUKPj4gdGhlIGxhc3QgcmVzb3J0Li4uCj4KPiBTbywgaXQgaGFzIGJlZW4gYnJva2VuIGZv ciB5ZWFycywgYW5kIHdhaXRpbmcgZm9yIGEgcGVyZmVjdCBzb2x1dGlvbgo+IGhhcyBub3QgZ290 dGVuIHRoZSBwcm9ibGVtIGZpeGVkLgoKV2VsbCwgdGhlIGN1cnJlbnQgZGVmYXVsdCBzaG91bGQg YXQgbGVhc3QgYmUgY2xvc2VyIHRvIHNvbWV0aGluZyB0aGF0CndvcmtzIHdlbGwuCgpJIGRvIHRo aW5rIEkgbWF5IGhhdmUgZXJyZWQgb24gdGhlIHdyb25nIHNpZGUgb2YgdGhlIG9wdGltdW0gd2hl biBJCnN1Ym1pdHRlZCB0aGUgb3JpZ2luYWwgcGF0Y2ggdG8gc2V0IHRoZSBkZWZhdWx0IHRvIDg7 IHRoYXQgc2hvdWxkCnByb2JhYmx5IGhhdmUgYmVlbiA3IChpLmUuLCA4IG1zOyB0aGUgb3B0aW11 bSBpbiB0aGUgZXZhbHVhdGlvbiB3ZSBkaWQKd2FzIGFyb3VuZCA2IG1zLCB3aGljaCBpcyBzYWRs eSBub3QgYSBwb3dlciBvZiB0d28pLiBNYXliZSBjaGFuZ2luZyB0aGF0CmRlZmF1bHQgaXMgYWN0 dWFsbHkgYmV0dGVyIHRoYW4gaGF2aW5nIHRvIHJlZG8gdGhlIHRlc3RpbmcgZm9yIGFsbCB0aGUK ZGlmZmVyZW50IGRldmljZXMgYXMgd2UncmUgZGlzY3Vzc2luZyBpbiB0aGUgY29udGV4dCBvZiB0 aGlzIHBhdGNoLgpNYXliZSBJIHNob3VsZCBqdXN0IHNlbmQgYSBwYXRjaCB0byBkbyB0aGF0Li4u CgotVG9rZQoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K YXRoMTBrIG1haWxpbmcgbGlzdAphdGgxMGtAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlz dHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2F0aDEwawo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97155C43381 for ; Thu, 21 Feb 2019 17:15:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 667002083B for ; Thu, 21 Feb 2019 17:15:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=toke.dk header.i=@toke.dk header.b="k4UZdcJE" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728482AbfBURPd (ORCPT ); Thu, 21 Feb 2019 12:15:33 -0500 Received: from mail.toke.dk ([52.28.52.200]:55595 "EHLO mail.toke.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725823AbfBURPc (ORCPT ); Thu, 21 Feb 2019 12:15:32 -0500 From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=toke.dk; s=20161023; t=1550769330; bh=xgRMWZapN7RJybSL4nbf7WBoCk7TUo1gpMSKkfCA0x4=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=k4UZdcJESt78uB2WMj8Xg1xAmvmRb+1IOPTc1zezN1yEVYy/EItLpoNxcFZJyAcTM +Mya/8e0z4PaG/A6csPbJH0y92DaUTwcbSPqmLLaPzAdyDakZWpOlEeoeug1BE+aqi oWsUzCeiNm0mymh33CaMYlR2G7ehuj/dhEYxgpTCgjEjJivawLX8rrlYcHnggYBAGm kFVcshUux+sXNRocv52FOCxZ39LA7Mn+C6Te6Vp0/ennNQTbTDqpWy6emct/CKVMtb thHNujrBYJOWdiMhnK6fHQtBXSE7jpRfLMNEgF5mSF4FAHHJNJrdSp3j4lqhuA/SU0 hkIZAqSrcK8fw== To: Ben Greear , Kalle Valo Cc: Grant Grundler , Kan Yan , linux-wireless@vger.kernel.org, Johannes Berg , wgong@qti.qualcomm.com, ath10k@lists.infradead.org, wgong@codeaurora.org Subject: Re: [PATCH v2 2/2] ath10k: Set sk_pacing_shift to 6 for 11AC WiFi chips In-Reply-To: <587631dd-f96a-999a-d61d-e5df5796766f@candelatech.com> References: <1533724802-30944-1-git-send-email-wgong@codeaurora.org> <1533724802-30944-3-git-send-email-wgong@codeaurora.org> <87sh3pdtpg.fsf@toke.dk> <87mutue4y8.fsf@toke.dk> <1535967508.3437.31.camel@sipsolutions.net> <87in3m25uu.fsf@toke.dk> <1535975240.3437.61.camel@sipsolutions.net> <878t4i1z74.fsf@toke.dk> <871sa7ylmi.fsf@toke.dk> <87r2c1i1vj.fsf@toke.dk> <871s41nmvx.fsf@kamboji.qca.qualcomm.com> <87ftshhzby.fsf@toke.dk> <587631dd-f96a-999a-d61d-e5df5796766f@candelatech.com> Date: Thu, 21 Feb 2019 18:15:30 +0100 X-Clacks-Overhead: GNU Terry Pratchett Message-ID: <87d0nlhxl9.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Ben Greear writes: > On 2/21/19 8:37 AM, Toke H=C3=B8iland-J=C3=B8rgensen wrote: >> Ben Greear writes: >>=20 >>> On 2/21/19 8:10 AM, Kalle Valo wrote: >>>> Toke H=C3=B8iland-J=C3=B8rgensen writes: >>>> >>>>> Grant Grundler writes: >>>>> >>>>>> On Thu, Sep 6, 2018 at 3:18 AM Toke H=C3=B8iland-J=C3=B8rgensen wrote: >>>>>>> >>>>>>> Grant Grundler writes: >>>>>>> >>>>>>>>> And, well, Grant's data is from a single test in a noisy >>>>>>>>> environment where the time series graph shows that throughput is = all over >>>>>>>>> the place for the duration of the test; so it's hard to draw solid >>>>>>>>> conclusions from (for instance, for the 5-stream test, the average >>>>>>>>> throughput for 6 is 331 and 379 Mbps for the two repetitions, and= for 7 >>>>>>>>> it's 326 and 371 Mbps) . Unfortunately I don't have the same hard= ware >>>>>>>>> used in this test, so I can't go verify it myself; so the only th= ing I >>>>>>>>> can do is grumble about it here... :) >>>>>>>> >>>>>>>> It's a fair complaint and I agree with it. My counter argument is = the >>>>>>>> opposite is true too: most ideal benchmarks don't measure what most >>>>>>>> users see. While the data wgong provided are way more noisy than I >>>>>>>> like, my overall "confidence" in the "conclusion" I offered is sti= ll >>>>>>>> positive. >>>>>>> >>>>>>> Right. I guess I would just prefer a slightly more comprehensive >>>>>>> evaluation to base a 4x increase in buffer size on... >>>>>> >>>>>> Kalle, is this why you didn't accept this patch? Other reasons? >>>>>> >>>>>> Toke, what else would you like to see evaluated? >>>>>> >>>>>> I generally want to see three things measured when "benchmarking" >>>>>> technologies: throughput, latency, cpu utilization >>>>>> We've covered those three I think "reasonably". >>>>> >>>>> Hmm, going back and looking at this (I'd completely forgotten about t= his >>>>> patch), I think I had two main concerns: >>>>> >>>>> 1. What happens in a degraded signal situation, where the throughput = is >>>>> limited by the signal conditions, or by contention with other de= vices. >>>>> Both of these happen regularly, and I worry that latency will be >>>>> badly affected under those conditions. >>>>> >>>>> 2. What happens with old hardware that has worse buffer management in >>>>> the driver->firmware path (especially drivers without push/pull = mode >>>>> support)? For these, the lower-level queueing structure is less >>>>> effective at controlling queueing latency. >>>> >>>> Do note that this patch changes behaviour _only_ for QCA6174 and QCA93= 77 >>>> PCI devices, which IIRC do not even support push/pull mode. All the >>>> rest, including QCA988X and QCA9984 are unaffected. >>> >>> Just as a note, at least kernels such as 4.14.whatever perform poorly w= hen >>> running ath10k on 9984 when acting as TCP endpoints. This makes them n= ot >>> really usable for stuff like serving video to lots of clients. >>> >>> Tweaking TCP (I do it a bit differently, but either way) can significan= tly >>> improve performance. >>=20 >> Differently how? Did you have to do more than fiddle with the pacing_shi= ft? > > This one, or a slightly tweaked version that applies to different kernels: > > https://github.com/greearb/linux-ct-4.16/commit/3e14e8491a5b31ce994fb2752= 347145e6ab7eaf5 Right; but the current mac80211 default (pacing shift 8) corresponds to setting your sysctl to 4... >>> Recently I helped a user that could get barely 70 stations streaming >>> at 1Mbps on stock kernel (using one wave1 on 2.4, one wave-2 on 5Ghz), >>> and we got 110 working with a tweaked TCP stack. These were /n >>> stations too. >>> >>> I think it is lame that it _still_ requires out of tree patches to >>> make TCP work well on ath10k...even if you want to default to current >>> behaviour, you should allow users to tweak it to work with their use >>> case. >>=20 >> Well if TCP is broken to the point of being unusable I do think we >> should fix it; but I think "just provide a configuration knob" should be >> the last resort... > > So, it has been broken for years, and waiting for a perfect solution > has not gotten the problem fixed. Well, the current default should at least be closer to something that works well. I do think I may have erred on the wrong side of the optimum when I submitted the original patch to set the default to 8; that should probably have been 7 (i.e., 8 ms; the optimum in the evaluation we did was around 6 ms, which is sadly not a power of two). Maybe changing that default is actually better than having to redo the testing for all the different devices as we're discussing in the context of this patch. Maybe I should just send a patch to do that... -Toke