From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:59223) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gqeZS-0002CM-2y for qemu-devel@nongnu.org; Mon, 04 Feb 2019 08:45:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gqeZR-0000Nl-6B for qemu-devel@nongnu.org; Mon, 04 Feb 2019 08:45:58 -0500 From: Markus Armbruster References: <1548942405-760115-1-git-send-email-andrey.shinkevich@virtuozzo.com> <1548942405-760115-3-git-send-email-andrey.shinkevich@virtuozzo.com> <87pnsbxsi7.fsf@dusky.pond.sub.org> <20190204094621.GB5855@linux.fritz.box> Date: Mon, 04 Feb 2019 14:45:49 +0100 In-Reply-To: <20190204094621.GB5855@linux.fritz.box> (Kevin Wolf's message of "Mon, 4 Feb 2019 10:46:21 +0100") Message-ID: <87d0o7psz6.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH v11 2/3] qemu-img info lists bitmap directory entries List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: fam@euphon.net, vsementsov@virtuozzo.com, qemu-block@nongnu.org, qemu-devel@nongnu.org, mreitz@redhat.com, den@openvz.org, Andrey Shinkevich , jsnow@redhat.com Kevin Wolf writes: > Am 01.02.2019 um 19:39 hat Markus Armbruster geschrieben: >> Andrey Shinkevich writes: >> >> > In the 'Format specific information' section of the 'qemu-img info' >> > command output, the supplemental information about existing QCOW2 >> > bitmaps will be shown, such as a bitmap name, flags and granularity: >> > >> > image: /vz/vmprivate/VM1/harddisk.hdd >> > file format: qcow2 >> > virtual size: 64G (68719476736 bytes) >> > disk size: 3.0M >> > cluster_size: 1048576 >> > Format specific information: >> > compat: 1.1 >> > lazy refcounts: true >> > bitmaps: >> > [0]: >> > flags: >> > [0]: in-use >> > [1]: auto >> > name: back-up1 >> > unknown flags: 4 >> > granularity: 65536 >> > [1]: >> > flags: >> > [0]: in-use >> > [1]: auto >> > name: back-up2 >> > unknown flags: 8 >> > granularity: 65536 >> > refcount bits: 16 >> > corrupt: false >> > >> > Signed-off-by: Andrey Shinkevich >> > --- >> [...] >> > diff --git a/qapi/block-core.json b/qapi/block-core.json >> > index 91685be..271e0df 100644 >> > --- a/qapi/block-core.json >> > +++ b/qapi/block-core.json >> > @@ -69,6 +69,8 @@ >> > # @encrypt: details about encryption parameters; only set if image >> > # is encrypted (since 2.10) >> > # >> > +# @bitmaps: A list of qcow2 bitmap details (since 4.0) >> > +# >> > # Since: 1.7 >> > ## >> > { 'struct': 'ImageInfoSpecificQCow2', >> > @@ -77,7 +79,8 @@ >> > '*lazy-refcounts': 'bool', >> > '*corrupt': 'bool', >> > 'refcount-bits': 'int', >> > - '*encrypt': 'ImageInfoSpecificQCow2Encryption' >> > + '*encrypt': 'ImageInfoSpecificQCow2Encryption', >> > + '*bitmaps': ['Qcow2BitmapInfo'] >> > } } >> > >> > ## >> > @@ -454,6 +457,41 @@ >> > 'status': 'DirtyBitmapStatus'} } >> > >> > ## >> > +# @Qcow2BitmapInfoFlags: >> > +# >> > +# An enumeration of flags that a bitmap can report to the user. >> > +# >> > +# @in-use: The bitmap was not saved correctly and may be inconsistent. >> >> I doubt the casual reader could guess the meaning from the name. What >> about @dirty? > > Feels like overloading the word "dirty" in the context of "dirty > bitmaps". This might easily lead to misinterpretation as "this bitmap > marks some clusters as dirty" rather than "this bitmap might be > inconsistent". Call it @possibly-inconsistent then?