From mboxrd@z Thu Jan 1 00:00:00 1970 From: Felipe Balbi Subject: Re: [PATCH 12/18] fotg210-udc: remove a bogus dma_sync_single_for_device call Date: Fri, 01 Feb 2019 15:19:41 +0200 Message-ID: <87d0obodci.fsf@linux.intel.com> References: <20190201084801.10983-1-hch@lst.de> <20190201084801.10983-13-hch@lst.de> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Return-path: In-Reply-To: <20190201084801.10983-13-hch@lst.de> Sender: linux-kernel-owner@vger.kernel.org To: Christoph Hellwig , John Crispin , Vinod Koul , Dmitry Tarnyagin , Nicolas Ferre , Sudip Mukherjee , linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, netdev@vger.kernel.org, linux-usb@vger.kernel.org, linux-fbdev@vger.kernel.org, alsa-devel@alsa-project.org Cc: iommu@lists.linux-foundation.org List-Id: alsa-devel@alsa-project.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Christoph Hellwig writes: > dma_map_single already transfers ownership to the device. > > Signed-off-by: Christoph Hellwig Do you want me to take the USB bits or will you take the entire series? In case you're taking the entire series: Acked-by: Felipe Balbi > --- > drivers/usb/gadget/udc/fotg210-udc.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/usb/gadget/udc/fotg210-udc.c b/drivers/usb/gadget/ud= c/fotg210-udc.c > index bc6abaea907d..fe9cf415f2f1 100644 > --- a/drivers/usb/gadget/udc/fotg210-udc.c > +++ b/drivers/usb/gadget/udc/fotg210-udc.c > @@ -356,10 +356,6 @@ static void fotg210_start_dma(struct fotg210_ep *ep, > return; > } >=20=20 > - dma_sync_single_for_device(NULL, d, length, > - ep->dir_in ? DMA_TO_DEVICE : > - DMA_FROM_DEVICE); > - > fotg210_enable_dma(ep, d, length); >=20=20 > /* check if dma is done */ > --=20 > 2.20.1 > =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEElLzh7wn96CXwjh2IzL64meEamQYFAlxUR24ACgkQzL64meEa mQahHA//UqW4f00GsiqzttL+A0YT71T+D9qtJhSfF7M0knMpZzdyOqcirQVm3TRT tpK0gC37IQGcT8NcrX75EtASdv/SBDJKhi5H1bCOEc5H00YxYUvujAdut+D25tJi SzfffbgIDcmkdit869qdzHmH565AGYZY6RG0lPoIS+7o1EGlO4AMM7RfF0y84VmY 46M4Ch6WtjDVuFAEUhHdZi9Q4hXxT46Kz6gKyzB/aB5h1OGxeHpUl5HUkF0jZmts E6m3SZb/vUrfQINJ69erIJH4qqap0TbQ509i0M1cx9X1TYiI/ou4C8bSk/8895K0 Js67kpVD/OXAyTmf/nVl4rtkhuDugyfEC+2bGUohpICCVd9ubg85B/1Yi/qQafYs sOt7bISdGgLiiSAxw9FWtVlezCW/8xuyC4hn0knkoAd9iIOO1LhfdNvfz0PPaVeW JnmCbx6syBAwlaEFem/M4uxp0Lq02WggiTNtTTUJw78N/MAl3CzDyyvRF0K1VpIR eGT71Gcrge3Utw8G8Tm0rzlBJntsXh7PLD63ga6nwirPxtq3ScPh3yjjdODRjc62 T4dch1AT9BSKqqbFeQuMaeEV5ml3SJF3+DvIQ3LRz22lP65oSPHYvmdWHYOXW++W FGuEo7SIciykLAFxBDq4MjuIqn5uMMERmOqGGElHqdZsQE+0SVg= =byNX -----END PGP SIGNATURE----- --=-=-=-- From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [12/18] fotg210-udc: remove a bogus dma_sync_single_for_device call From: Felipe Balbi Message-Id: <87d0obodci.fsf@linux.intel.com> Date: Fri, 01 Feb 2019 15:19:41 +0200 To: Christoph Hellwig , John Crispin , Vinod Koul , Dmitry Tarnyagin , Nicolas Ferre , Sudip Mukherjee , linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, netdev@vger.kernel.org, linux-usb@vger.kernel.org, linux-fbdev@vger.kernel.org, alsa-devel@alsa-project.org Cc: iommu@lists.linux-foundation.org List-ID: Q2hyaXN0b3BoIEhlbGx3aWcgPGhjaEBsc3QuZGU+IHdyaXRlczoKCj4gZG1hX21hcF9zaW5nbGUg YWxyZWFkeSB0cmFuc2ZlcnMgb3duZXJzaGlwIHRvIHRoZSBkZXZpY2UuCj4KPiBTaWduZWQtb2Zm LWJ5OiBDaHJpc3RvcGggSGVsbHdpZyA8aGNoQGxzdC5kZT4KCkRvIHlvdSB3YW50IG1lIHRvIHRh a2UgdGhlIFVTQiBiaXRzIG9yIHdpbGwgeW91IHRha2UgdGhlIGVudGlyZSBzZXJpZXM/CkluIGNh c2UgeW91J3JlIHRha2luZyB0aGUgZW50aXJlIHNlcmllczoKCkFja2VkLWJ5OiBGZWxpcGUgQmFs YmkgPGZlbGlwZS5iYWxiaUBsaW51eC5pbnRlbC5jb20+Cgo+IC0tLQo+ICBkcml2ZXJzL3VzYi9n YWRnZXQvdWRjL2ZvdGcyMTAtdWRjLmMgfCA0IC0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDQgZGVs ZXRpb25zKC0pCj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy91c2IvZ2FkZ2V0L3VkYy9mb3RnMjEw LXVkYy5jIGIvZHJpdmVycy91c2IvZ2FkZ2V0L3VkYy9mb3RnMjEwLXVkYy5jCj4gaW5kZXggYmM2 YWJhZWE5MDdkLi5mZTljZjQxNWYyZjEgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy91c2IvZ2FkZ2V0 L3VkYy9mb3RnMjEwLXVkYy5jCj4gKysrIGIvZHJpdmVycy91c2IvZ2FkZ2V0L3VkYy9mb3RnMjEw LXVkYy5jCj4gQEAgLTM1NiwxMCArMzU2LDYgQEAgc3RhdGljIHZvaWQgZm90ZzIxMF9zdGFydF9k bWEoc3RydWN0IGZvdGcyMTBfZXAgKmVwLAo+ICAJCXJldHVybjsKPiAgCX0KPiAgCj4gLQlkbWFf c3luY19zaW5nbGVfZm9yX2RldmljZShOVUxMLCBkLCBsZW5ndGgsCj4gLQkJCQkgICBlcC0+ZGly X2luID8gRE1BX1RPX0RFVklDRSA6Cj4gLQkJCQkJRE1BX0ZST01fREVWSUNFKTsKPiAtCj4gIAlm b3RnMjEwX2VuYWJsZV9kbWEoZXAsIGQsIGxlbmd0aCk7Cj4gIAo+ICAJLyogY2hlY2sgaWYgZG1h IGlzIGRvbmUgKi8KPiAtLSAKPiAyLjIwLjEKPgo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: Felipe Balbi Date: Fri, 01 Feb 2019 13:19:41 +0000 Subject: Re: [PATCH 12/18] fotg210-udc: remove a bogus dma_sync_single_for_device call Message-Id: <87d0obodci.fsf@linux.intel.com> MIME-Version: 1 Content-Type: multipart/mixed; boundary="=-=-=" List-Id: References: <20190201084801.10983-1-hch@lst.de> <20190201084801.10983-13-hch@lst.de> In-Reply-To: <20190201084801.10983-13-hch@lst.de> To: Christoph Hellwig , John Crispin , Vinod Koul , Dmitry Tarnyagin , Nicolas Ferre , Sudip Mukherjee , linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, netdev@vger.kernel.org, linux-usb@vger.kernel.org, linux-fbdev@vger.kernel.org, alsa-devel@alsa-project.org Cc: iommu@lists.linux-foundation.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Christoph Hellwig writes: > dma_map_single already transfers ownership to the device. > > Signed-off-by: Christoph Hellwig Do you want me to take the USB bits or will you take the entire series? In case you're taking the entire series: Acked-by: Felipe Balbi > --- > drivers/usb/gadget/udc/fotg210-udc.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/usb/gadget/udc/fotg210-udc.c b/drivers/usb/gadget/ud= c/fotg210-udc.c > index bc6abaea907d..fe9cf415f2f1 100644 > --- a/drivers/usb/gadget/udc/fotg210-udc.c > +++ b/drivers/usb/gadget/udc/fotg210-udc.c > @@ -356,10 +356,6 @@ static void fotg210_start_dma(struct fotg210_ep *ep, > return; > } >=20=20 > - dma_sync_single_for_device(NULL, d, length, > - ep->dir_in ? DMA_TO_DEVICE : > - DMA_FROM_DEVICE); > - > fotg210_enable_dma(ep, d, length); >=20=20 > /* check if dma is done */ > --=20 > 2.20.1 > =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEElLzh7wn96CXwjh2IzL64meEamQYFAlxUR24ACgkQzL64meEa mQahHA//UqW4f00GsiqzttL+A0YT71T+D9qtJhSfF7M0knMpZzdyOqcirQVm3TRT tpK0gC37IQGcT8NcrX75EtASdv/SBDJKhi5H1bCOEc5H00YxYUvujAdut+D25tJi SzfffbgIDcmkdit869qdzHmH565AGYZY6RG0lPoIS+7o1EGlO4AMM7RfF0y84VmY 46M4Ch6WtjDVuFAEUhHdZi9Q4hXxT46Kz6gKyzB/aB5h1OGxeHpUl5HUkF0jZmts E6m3SZb/vUrfQINJ69erIJH4qqap0TbQ509i0M1cx9X1TYiI/ou4C8bSk/8895K0 Js67kpVD/OXAyTmf/nVl4rtkhuDugyfEC+2bGUohpICCVd9ubg85B/1Yi/qQafYs sOt7bISdGgLiiSAxw9FWtVlezCW/8xuyC4hn0knkoAd9iIOO1LhfdNvfz0PPaVeW JnmCbx6syBAwlaEFem/M4uxp0Lq02WggiTNtTTUJw78N/MAl3CzDyyvRF0K1VpIR eGT71Gcrge3Utw8G8Tm0rzlBJntsXh7PLD63ga6nwirPxtq3ScPh3yjjdODRjc62 T4dch1AT9BSKqqbFeQuMaeEV5ml3SJF3+DvIQ3LRz22lP65oSPHYvmdWHYOXW++W FGuEo7SIciykLAFxBDq4MjuIqn5uMMERmOqGGElHqdZsQE+0SVg= =byNX -----END PGP SIGNATURE----- --=-=-=--