From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [v4 2/4] drm/i915/icl: Add icl pipe degamma and gamma support Date: Thu, 27 Dec 2018 10:18:07 +0200 Message-ID: <87d0pnwfgg.fsf@intel.com> References: <1545335981-2338-1-git-send-email-uma.shankar@intel.com> <1545335981-2338-3-git-send-email-uma.shankar@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1C7F06E21C for ; Thu, 27 Dec 2018 08:17:44 +0000 (UTC) In-Reply-To: <1545335981-2338-3-git-send-email-uma.shankar@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Uma Shankar , intel-gfx@lists.freedesktop.org Cc: ville.syrjala@intel.com, maarten.lankhorst@intel.com List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCAyMSBEZWMgMjAxOCwgVW1hIFNoYW5rYXIgPHVtYS5zaGFua2FyQGludGVsLmNvbT4g d3JvdGU6Cj4gQWRkIHN1cHBvcnQgZm9yIGljbCBwaXBlIGRlZ2FtbWEgYW5kIGdhbW1hLgo+Cj4g djI6IFJlbW92ZWQgYSBQT1NUSU5HX1JFQUQgYW5kIGNvcnJlY3RlZCB0aGUgQml0Cj4gRGVmaW5p dGlvbiBhcyBwZXIgTWFhcnRlbidzIGNvbW1lbnRzLgo+Cj4gdjM6IEFkZHJlc3NlZCBNYXR0J3Mg cmV2aWV3IGNvbW1lbnRzLiBSZW1vdmVkIHJtdyBwYXR0ZXJucwo+IGFzIHN1Z2dlc3RlZCBieSBN YXR0Lgo+Cj4gdjQ6IEZpeGVkIE1hdHQncyByZXZpZXcgY29tbWVudHMuCj4KPiBTaWduZWQtb2Zm LWJ5OiBVbWEgU2hhbmthciA8dW1hLnNoYW5rYXJAaW50ZWwuY29tPgo+IC0tLQo+ICBkcml2ZXJz L2dwdS9kcm0vaTkxNS9pOTE1X3JlZy5oICAgIHwgIDMgKysKPiAgZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfY29sb3IuYyB8IDY3ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrCj4gIDIgZmlsZXMgY2hhbmdlZCwgNzAgaW5zZXJ0aW9ucygrKQo+Cj4gZGlmZiAtLWdpdCBh L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcmVnLmggYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p OTE1X3JlZy5oCj4gaW5kZXggMDJhZjliNS4uMTg1MmMzMyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pOTE1X3JlZy5oCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkx NV9yZWcuaAo+IEBAIC03MDkyLDYgKzcwOTIsOSBAQCBlbnVtIHsKPiAgI2RlZmluZSBHQU1NQV9N T0RFX01PREVfMTJCSVQJKDIgPDwgMCkKPiAgI2RlZmluZSBHQU1NQV9NT0RFX01PREVfU1BMSVQJ KDMgPDwgMCkKPiAgCj4gKyNkZWZpbmUJUFJFX0NTQ19HQU1NQV9FTkFCTEUJKDEgPDwgMzEpCj4g KyNkZWZpbmUJUE9TVF9DU0NfR0FNTUFfRU5BQkxFCSgxIDw8IDMwKQoKUGxlYXNlIHJlYWQgdGhl IGJpZyBjb21tZW50IG5lYXIgdGhlIHRvcCBvZiB0aGlzIGZpbGUgYWJvdXQgd2hlcmUgdG8KcGxh Y2UgcmVnaXN0ZXIgY29udGVudCBtYWNyb3MsIG9yZGVyaW5nLCBpbmRlbnRhdGlvbiwgc3BhY2lu ZywgZXRjLgoKQlIsCkphbmkuCgo+ICsKPiAgLyogRE1DL0NTUiAqLwo+ICAjZGVmaW5lIENTUl9Q Uk9HUkFNKGkpCQlfTU1JTygweDgwMDAwICsgKGkpICogNCkKPiAgI2RlZmluZSBDU1JfU1NQX0JB U0VfQUREUl9HRU45CTB4MDAwMDJGQzAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfY29sb3IuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2NvbG9yLmMKPiBp bmRleCBmMzJlNGE3Li5lNzJkOGQ2IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX2NvbG9yLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9jb2xvci5j Cj4gQEAgLTUzNCw2ICs1MzQsNzEgQEAgc3RhdGljIHZvaWQgZ2xrX2xvYWRfbHV0cyhzdHJ1Y3Qg aW50ZWxfY3J0Y19zdGF0ZSAqY3J0Y19zdGF0ZSkKPiAgCVBPU1RJTkdfUkVBRChHQU1NQV9NT0RF KHBpcGUpKTsKPiAgfQo+ICAKPiArc3RhdGljIHZvaWQgaWNsX2xvYWRfZGVnYW1tYV9sdXQoc3Ry dWN0IGludGVsX2NydGNfc3RhdGUgKmNydGNfc3RhdGUpCj4gK3sKPiArCXN0cnVjdCBkcm1fZGV2 aWNlICpkZXYgPSBjcnRjX3N0YXRlLT5iYXNlLmNydGMtPmRldjsKPiArCXN0cnVjdCBkcm1faTkx NV9wcml2YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUoZGV2KTsKPiArCWVudW0gcGlwZSBwaXBlID0g dG9faW50ZWxfY3J0YyhjcnRjX3N0YXRlLT5iYXNlLmNydGMpLT5waXBlOwo+ICsJY29uc3QgdWlu dDMyX3QgbHV0X3NpemUgPSBJTlRFTF9JTkZPKGRldl9wcml2KS0+Y29sb3IuZGVnYW1tYV9sdXRf c2l6ZTsKPiArCXVpbnQzMl90IGk7Cj4gKwo+ICsJLyoKPiArCSAqIFdoZW4gc2V0dGluZyB0aGUg YXV0by1pbmNyZW1lbnQgYml0LCB0aGUgaGFyZHdhcmUgc2VlbXMgdG8KPiArCSAqIGlnbm9yZSB0 aGUgaW5kZXggYml0cywgc28gd2UgbmVlZCB0byByZXNldCBpdCB0byBpbmRleCAwCj4gKwkgKiBz ZXBhcmF0ZWx5Lgo+ICsJICovCj4gKwlJOTE1X1dSSVRFKFBSRV9DU0NfR0FNQ19JTkRFWChwaXBl KSwgMCk7Cj4gKwlJOTE1X1dSSVRFKFBSRV9DU0NfR0FNQ19JTkRFWChwaXBlKSwgUFJFX0NTQ19H QU1DX0FVVE9fSU5DUkVNRU5UKTsKPiArCj4gKwlpZiAoY3J0Y19zdGF0ZS0+YmFzZS5kZWdhbW1h X2x1dCkgewo+ICsJCXN0cnVjdCBkcm1fY29sb3JfbHV0ICpsdXQgPSBjcnRjX3N0YXRlLT5iYXNl LmRlZ2FtbWFfbHV0LT5kYXRhOwo+ICsKPiArCQlmb3IgKGkgPSAwOyBpIDwgbHV0X3NpemU7IGkr Kykgewo+ICsJCQkvKgo+ICsJCQkgKiBGaXJzdCAzMyBlbnRyaWVzIHJlcHJlc2VudCByYW5nZSBm cm9tIDAgdG8gMS4wCj4gKwkJCSAqIDM0dGggYW5kIDM1dGggZW50cnkgd2lsbCByZXByZXNlbnQg ZXh0ZW5kZWQgcmFuZ2UKPiArCQkJICogaW5wdXRzIDMuMCBhbmQgNy4wIHJlc3BlY3RpdmVseSwg Y3VycmVudGx5IGNsYW1wZWQKPiArCQkJICogYXQgMS4wLiBTaW5jZSB0aGUgcHJlY2lzaW9uIGlz IDE2Yml0LCB0aGUgdXNlciB2YWx1ZQo+ICsJCQkgKiBjYW4gYmUgZGlyZWN0bHkgZmlsbGVkIHRv IHJlZ2lzdGVyLgo+ICsJCQkgKiBUb0RvOiBFeHRlbmQgdG8gbWF4IDcuMC4KPiArCQkJICovCj4g KwkJCUk5MTVfV1JJVEUoUFJFX0NTQ19HQU1DX0RBVEEocGlwZSksIGx1dFtpXS5yZWQpOwo+ICsJ CX0KPiArCX0gZWxzZSB7Cj4gKwkJLyogbG9hZCBhIGxpbmVhciB0YWJsZS4gKi8KPiArCQlmb3Ig KGkgPSAwOyBpIDwgbHV0X3NpemU7IGkrKykgewo+ICsJCQl1aW50MzJfdCB2ID0gKGkgKiAoMSA8 PCAxNikpIC8gKGx1dF9zaXplIC0gMSk7Cj4gKwo+ICsJCQlJOTE1X1dSSVRFKFBSRV9DU0NfR0FN Q19EQVRBKHBpcGUpLCB2KTsKPiArCQl9Cj4gKwl9Cj4gKwo+ICsJLyogQ2xhbXAgdmFsdWVzID4g MS4wLiAqLwo+ICsJd2hpbGUgKGkrKyA8IDM1KQo+ICsJCUk5MTVfV1JJVEUoUFJFX0NTQ19HQU1D X0RBVEEocGlwZSksICgxIDw8IDE2KSk7Cj4gK30KPiArCj4gK3N0YXRpYyB2b2lkIGljbF9sb2Fk X2x1dHMoc3RydWN0IGludGVsX2NydGNfc3RhdGUgKmNydGNfc3RhdGUpCj4gK3sKPiArCXN0cnVj dCBkcm1fY3J0YyAqY3J0YyA9IGNydGNfc3RhdGUtPmJhc2UuY3J0YzsKPiArCXN0cnVjdCBkcm1f ZGV2aWNlICpkZXYgPSBjcnRjX3N0YXRlLT5iYXNlLmNydGMtPmRldjsKPiArCXN0cnVjdCBkcm1f aTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUoZGV2KTsKPiArCWVudW0gcGlwZSBwaXBl ID0gdG9faW50ZWxfY3J0YyhjcnRjKS0+cGlwZTsKPiArCXUzMiBnYW1tYV9tb2RlID0gMDsKPiAr Cj4gKwlpZiAoY3J0Y19zdGF0ZV9pc19sZWdhY3lfZ2FtbWEoY3J0Y19zdGF0ZSkpIHsKPiArCQlo YXN3ZWxsX2xvYWRfbHV0cyhjcnRjX3N0YXRlKTsKPiArCQlyZXR1cm47Cj4gKwl9Cj4gKwo+ICsJ aWNsX2xvYWRfZGVnYW1tYV9sdXQoY3J0Y19zdGF0ZSk7Cj4gKwliZHdfbG9hZF9nYW1tYV9sdXQo Y3J0Y19zdGF0ZSwgMCk7Cj4gKwo+ICsJZ2FtbWFfbW9kZSA9IEdBTU1BX01PREVfTU9ERV8xMEJJ VCB8IFBSRV9DU0NfR0FNTUFfRU5BQkxFCj4gKwkJCXwgUE9TVF9DU0NfR0FNTUFfRU5BQkxFOwo+ ICsJSTkxNV9XUklURShHQU1NQV9NT0RFKHBpcGUpLCBnYW1tYV9tb2RlKTsKPiArfQo+ICsKPiAg LyogTG9hZHMgdGhlIHBhbGV0dGUvZ2FtbWEgdW5pdCBmb3IgdGhlIENSVEMgb24gQ2hlcnJ5Vmll dy4gKi8KPiAgc3RhdGljIHZvaWQgY2hlcnJ5dmlld19sb2FkX2x1dHMoc3RydWN0IGludGVsX2Ny dGNfc3RhdGUgKmNydGNfc3RhdGUpCj4gIHsKPiBAQCAtNjQ5LDYgKzcxNCw4IEBAIHZvaWQgaW50 ZWxfY29sb3JfaW5pdChzdHJ1Y3QgaW50ZWxfY3J0YyAqY3J0YykKPiAgCX0gZWxzZSBpZiAoSVNf R0VNSU5JTEFLRShkZXZfcHJpdikgfHwgSVNfQ0FOTk9OTEFLRShkZXZfcHJpdikpIHsKPiAgCQlk ZXZfcHJpdi0+ZGlzcGxheS5sb2FkX2NzY19tYXRyaXggPSBpbGtfbG9hZF9jc2NfbWF0cml4Owo+ ICAJCWRldl9wcml2LT5kaXNwbGF5LmxvYWRfbHV0cyA9IGdsa19sb2FkX2x1dHM7Cj4gKwl9IGVs c2UgaWYgKElTX0lDRUxBS0UoZGV2X3ByaXYpKSB7Cj4gKwkJZGV2X3ByaXYtPmRpc3BsYXkubG9h ZF9sdXRzID0gaWNsX2xvYWRfbHV0czsKPiAgCX0gZWxzZSB7Cj4gIAkJZGV2X3ByaXYtPmRpc3Bs YXkubG9hZF9sdXRzID0gaTl4eF9sb2FkX2x1dHM7Cj4gIAl9CgotLSAKSmFuaSBOaWt1bGEsIElu dGVsIE9wZW4gU291cmNlIEdyYXBoaWNzIENlbnRlcgpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBs aXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1h bi9saXN0aW5mby9pbnRlbC1nZngK