Re: [Qemu-devel] [PATCH v3] qapi: add query-display-options command

[Markus Armbruster <armbru@redhat.com>]

Gerd Hoffmann <kraxel@redhat.com> writes:

>   Hi,
>
>> If it's not too much trouble, please tweak the commit message to be a
>> bit more explicit.  Perhaps:
>> 
>>     Add query-display-options command, which allows querying the qemu
>>     display configuration.  This isn't particularly useful, except it
>>     exposes QAPI type DisplayOptions in query-qmp-schema, so that
>>     libvirt can discover recently added -display parameter rendernode
>>     (commit d4dc4ab133b).  Works around lack of sufficiently powerful
>>     command line introspection.
>
> Done, pull req with this and other 3.1 fixes sent.
>
>> This should give me a fighting chance to remember deprecating the
>> command once we got sufficiently powerful command line introspection.
>
> I'm wondering how difficuilt it would be to add that when limiting that
> to the command line switches which already use qapi parsers (-blockdev
> and -display as far I know).  Might increase the motivation of others to
> help moving parsers from whatever they do today (QemuOpts, ...) to qapi
> to get introspection support ;)

I like the idea.  The clean way to do it would be a partial QAPIfication
of the command line.  I'm wary of partial "we'll finish this eventually"
conversions.  That said, the complete job may well be too large to
tackle in one go, giving us no choice.