Re: [PATCH 08/16] iwlwifi: trans: parse and store debug ini TLVs

[Kalle Valo <kvalo@codeaurora.org>]

Luca Coelho <luca@coelho.fi> writes:

> From: Sara Sharon <sara.sharon@intel.com>
>
> The new debug ini TLVs can be either packed into firmware
> binary or written in external file. Support loading them
> from both. Store the data per apply point. Apply point is
> a point during driver runtime, where the TLV becomes active.
> For example, a trigger of hardware error may be configured
> to collect a subset of data pre-alive, as a opposed to HW
> error that occurs after alive.
>
> Signed-off-by: Sara Sharon <sara.sharon@intel.com>
> Signed-off-by: Luca Coelho <luciano.coelho@intel.com>

[...]

> @@ -1749,6 +1762,10 @@ MODULE_PARM_DESC(lar_disable, "disable LAR functionality (default: N)");
>  module_param_named(uapsd_disable, iwlwifi_mod_params.uapsd_disable, uint, 0644);
>  MODULE_PARM_DESC(uapsd_disable,
>  		 "disable U-APSD functionality bitmap 1: BSS 2: P2P Client (default: 3)");
> +module_param_named(enable_ini, iwlwifi_mod_params.enable_ini,
> +		   bool, S_IRUGO | S_IWUSR);
> +MODULE_PARM_DESC(enable_ini,
> +		 "Enable debug INI TLV FW debug infrastructure (default: 0");

The commit log doesn't mention anything about the module parameter and
how/when it's supposed to be used, that would be nice to have.

-- 
Kalle Valo