All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: Alberto Garcia <berto@igalia.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] scripts: Remove check-qerror.sh
Date: Wed, 17 Oct 2018 19:25:32 +0200	[thread overview]
Message-ID: <87d0s8o583.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <20181017151738.20299-1-berto@igalia.com> (Alberto Garcia's message of "Wed, 17 Oct 2018 18:17:38 +0300")

Alberto Garcia <berto@igalia.com> writes:

> qerror.h contains leftovers from the now-defunct QError API.
>
> There's only a handful of string macros left, and no one is supposed
> to add anything else. The check-qerror.sh script was used to make sure
> that all definitions on the qerror.c and qerror.h files were sorted
> alphabetically. The former was removed three years ago, and the latter
> is now in a different location, so the script doesn't even work (as
> a matter of fact the alphabetical order was broken last time someone
> added a macro -also in 2015- and no one seemed to notice).
>
> There's no point in fixing this script so let's just remove it.
> The rogue macro is also moved to its correct location.
>
> Signed-off-by: Alberto Garcia <berto@igalia.com>

Reviewed-by: Markus Armbruster <armbru@redhat.com>

Queued, thanks!

      reply	other threads:[~2018-10-17 17:25 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-17 15:17 [Qemu-devel] [PATCH] scripts: Remove check-qerror.sh Alberto Garcia
2018-10-17 17:25 ` Markus Armbruster [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d0s8o583.fsf@dusky.pond.sub.org \
    --to=armbru@redhat.com \
    --cc=berto@igalia.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.