From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH] drm/i915: abstract and document register picking macros Date: Mon, 02 Jul 2018 17:44:13 +0300 Message-ID: <87d0w5r936.fsf@intel.com> References: <20180629102039.2435-1-jani.nikula@intel.com> <20180629143839.GE5309@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 89F348922A for ; Mon, 2 Jul 2018 14:44:29 +0000 (UTC) In-Reply-To: <20180629143839.GE5309@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Rodrigo Vivi Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCAyOSBKdW4gMjAxOCwgUm9kcmlnbyBWaXZpIDxyb2RyaWdvLnZpdmlAaW50ZWwuY29t PiB3cm90ZToKPiBPbiBGcmksIEp1biAyOSwgMjAxOCBhdCAwMToyMDozOVBNICswMzAwLCBKYW5p IE5pa3VsYSB3cm90ZToKPj4gVHJ5IHRvIGRlc2NyaWJlIHdoYXQgdGhlIHBpY2sgdmFyaWFudHMg ZG8sIGFuZCB3aGljaCB0byBwcmVmZXIuIE5vCj4+IGZ1bmN0aW9uYWwgY2hhbmdlcy4KPj4gCj4+ IFNpZ25lZC1vZmYtYnk6IEphbmkgTmlrdWxhIDxqYW5pLm5pa3VsYUBpbnRlbC5jb20+Cj4KPiBS ZXZpZXdlZC1ieTogUm9kcmlnbyBWaXZpIDxyb2RyaWdvLnZpdmlAaW50ZWwuY29tPgoKVGhhbmtz LCBwdXNoZWQuCgpCUiwKSmFuaS4KCj4KPj4gCj4+IC0tLQo+PiAKPj4gTGV0IHRoZSBuYW1pbmcg YmlrZXNoZWQgZmVzdCBiZWdpbiEKPj4gLS0tCj4+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1 X3JlZy5oIHwgMjggKysrKysrKysrKysrKysrKysrKysrKy0tLS0tLQo+PiAgMSBmaWxlIGNoYW5n ZWQsIDIyIGluc2VydGlvbnMoKyksIDYgZGVsZXRpb25zKC0pCj4+IAo+PiBkaWZmIC0tZ2l0IGEv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9yZWcuaCBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5 MTVfcmVnLmgKPj4gaW5kZXggYzMwY2ZjZDkwNzU0Li43ZGM3NzQ2ODI5MjIgMTAwNjQ0Cj4+IC0t LSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcmVnLmgKPj4gKysrIGIvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaTkxNV9yZWcuaAo+PiBAQCAtMTM5LDE5ICsxMzksMzUgQEAgc3RhdGljIGlubGlu ZSBib29sIGk5MTVfbW1pb19yZWdfdmFsaWQoaTkxNV9yZWdfdCByZWcpCj4+ICAJcmV0dXJuICFp OTE1X21taW9fcmVnX2VxdWFsKHJlZywgSU5WQUxJRF9NTUlPX1JFRyk7Cj4+ICB9Cj4+ICAKPj4g Ky8qCj4+ICsgKiBHaXZlbiB0aGUgZmlyc3QgdHdvIG51bWJlcnMgX19hIGFuZCBfX2Igb2YgYXJi aXRyYXJpbHkgbWFueSBldmVubHkgc3BhY2VkCj4+ICsgKiBudW1iZXJzLCBwaWNrIHRoZSAwLWJh c2VkIF9faW5kZXgndGggdmFsdWUuCj4+ICsgKgo+PiArICogQWx3YXlzIHByZWZlciB0aGlzIG92 ZXIgX1BJQ0soKSBpZiB0aGUgbnVtYmVycyBhcmUgZXZlbmx5IHNwYWNlZC4KPj4gKyAqLwo+PiAr I2RlZmluZSBfUElDS19FVkVOKF9faW5kZXgsIF9fYSwgX19iKSAoKF9fYSkgKyAoX19pbmRleCkg KiAoKF9fYikgLSAoX19hKSkpCj4+ICsKPj4gKy8qCj4+ICsgKiBHaXZlbiB0aGUgYXJiaXRyYXJ5 IG51bWJlcnMgaW4gdmFyYXJncywgcGljayB0aGUgMC1iYXNlZCBfX2luZGV4J3RoIG51bWJlci4K Pj4gKyAqCj4+ICsgKiBBbHdheXMgcHJlZmVyIF9QSUNLX0VWRU4oKSBvdmVyIHRoaXMgaWYgdGhl IG51bWJlcnMgYXJlIGV2ZW5seSBzcGFjZWQuCj4+ICsgKi8KPj4gICNkZWZpbmUgX1BJQ0soX19p bmRleCwgLi4uKSAoKChjb25zdCB1MzIgW10peyBfX1ZBX0FSR1NfXyB9KVtfX2luZGV4XSkKPj4g IAo+PiAtI2RlZmluZSBfUElQRShwaXBlLCBhLCBiKSAoKGEpICsgKHBpcGUpICogKChiKSAtIChh KSkpCj4+ICsvKgo+PiArICogTmFtZWQgaGVscGVyIHdyYXBwZXJzIGFyb3VuZCBfUElDS19FVkVO KCkgYW5kIF9QSUNLKCkuCj4+ICsgKi8KPj4gKyNkZWZpbmUgX1BJUEUocGlwZSwgYSwgYikgX1BJ Q0tfRVZFTihwaXBlLCBhLCBiKQo+PiAgI2RlZmluZSBfTU1JT19QSVBFKHBpcGUsIGEsIGIpIF9N TUlPKF9QSVBFKHBpcGUsIGEsIGIpKQo+PiAtI2RlZmluZSBfUExBTkUocGxhbmUsIGEsIGIpIF9Q SVBFKHBsYW5lLCBhLCBiKQo+PiArI2RlZmluZSBfUExBTkUocGxhbmUsIGEsIGIpIF9QSUNLX0VW RU4ocGxhbmUsIGEsIGIpCj4+ICAjZGVmaW5lIF9NTUlPX1BMQU5FKHBsYW5lLCBhLCBiKSBfTU1J T19QSVBFKHBsYW5lLCBhLCBiKQo+PiAtI2RlZmluZSBfVFJBTlModHJhbiwgYSwgYikgKChhKSAr ICh0cmFuKSAqICgoYikgLSAoYSkpKQo+PiArI2RlZmluZSBfVFJBTlModHJhbiwgYSwgYikgX1BJ Q0tfRVZFTih0cmFuLCBhLCBiKQo+PiAgI2RlZmluZSBfTU1JT19UUkFOUyh0cmFuLCBhLCBiKSBf TU1JTyhfVFJBTlModHJhbiwgYSwgYikpCj4+IC0jZGVmaW5lIF9QT1JUKHBvcnQsIGEsIGIpICgo YSkgKyAocG9ydCkgKiAoKGIpIC0gKGEpKSkKPj4gKyNkZWZpbmUgX1BPUlQocG9ydCwgYSwgYikg X1BJQ0tfRVZFTihwb3J0LCBhLCBiKQo+PiAgI2RlZmluZSBfTU1JT19QT1JUKHBvcnQsIGEsIGIp IF9NTUlPKF9QT1JUKHBvcnQsIGEsIGIpKQo+PiAgI2RlZmluZSBfTU1JT19QSVBFMyhwaXBlLCBh LCBiLCBjKSBfTU1JTyhfUElDSyhwaXBlLCBhLCBiLCBjKSkKPj4gICNkZWZpbmUgX01NSU9fUE9S VDMocGlwZSwgYSwgYiwgYykgX01NSU8oX1BJQ0socGlwZSwgYSwgYiwgYykpCj4+IC0jZGVmaW5l IF9QTEwocGxsLCBhLCBiKSAoKGEpICsgKHBsbCkgKiAoKGIpIC0gKGEpKSkKPj4gKyNkZWZpbmUg X1BMTChwbGwsIGEsIGIpIF9QSUNLX0VWRU4ocGxsLCBhLCBiKQo+PiAgI2RlZmluZSBfTU1JT19Q TEwocGxsLCBhLCBiKSBfTU1JTyhfUExMKHBsbCwgYSwgYikpCj4+ICAjZGVmaW5lIF9QSFkzKHBo eSwgLi4uKSBfUElDSyhwaHksIF9fVkFfQVJHU19fKQo+PiAgI2RlZmluZSBfTU1JT19QSFkzKHBo eSwgYSwgYiwgYykgX01NSU8oX1BIWTMocGh5LCBhLCBiLCBjKSkKPj4gQEAgLTY4NzQsNyArNjg5 MCw3IEBAIGVudW0gewo+PiAgI2RlZmluZSBfUFNfRUNDX1NUQVRfMkIgICAgIDB4NjhBRDAKPj4g ICNkZWZpbmUgX1BTX0VDQ19TVEFUXzFDICAgICAweDY5MUQwCj4+ICAKPj4gLSNkZWZpbmUgX0lE KGlkLCBhLCBiKSAoKGEpICsgKGlkKSAqICgoYikgLSAoYSkpKQo+PiArI2RlZmluZSBfSUQoaWQs IGEsIGIpIF9QSUNLX0VWRU4oaWQsIGEsIGIpCj4+ICAjZGVmaW5lIFNLTF9QU19DVFJMKHBpcGUs IGlkKSBfTU1JT19QSVBFKHBpcGUsICAgICAgICBcCj4+ICAJCQlfSUQoaWQsIF9QU18xQV9DVFJM LCBfUFNfMkFfQ1RSTCksICAgICAgIFwKPj4gIAkJCV9JRChpZCwgX1BTXzFCX0NUUkwsIF9QU18y Ql9DVFJMKSkKPj4gLS0gCj4+IDIuMTEuMAo+PiAKPj4gX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KPj4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+PiBJbnRl bC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Au b3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4CgotLSAKSmFuaSBOaWt1bGEsIEludGVsIE9w ZW4gU291cmNlIEdyYXBoaWNzIENlbnRlcgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5m cmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0 aW5mby9pbnRlbC1nZngK