From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH 5/6] backlight: Also nuke BL_CORE_DRIVER1 Date: Mon, 30 Apr 2018 13:24:16 +0300 Message-ID: <87d0yh9elr.fsf@intel.com> References: <20180425174253.4616-1-daniel.vetter@ffwll.ch> <20180425174253.4616-5-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 116916E106 for ; Mon, 30 Apr 2018 10:21:37 +0000 (UTC) In-Reply-To: <20180425174253.4616-5-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: DRI Development , LKML Cc: Jingoo Han , Daniel Vetter , Daniel Thompson , Lee Jones , Daniel Vetter List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCAyNSBBcHIgMjAxOCwgRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBmZndsbC5j aD4gd3JvdGU6Cj4gTm93IHRoYXQgdGhlIDMgZHJpdmVycyB1c2luZyB0aGlzIGFyZSBjbGVhbmVk IHVwIHdlIGNhbiBhbHNvIHJlbW92ZQo+IHRoaXMgZmluYWwgYml0IG9mIGNvbmZ1c2lvbiBvZiBs ZWFraW5nIGRyaXZlciBpbnRlcm5hbHMgaW50byB0aGUKPiBiYWNrbGlnaHQgcG93ZXIgaW50ZXJm YWNlLgo+Cj4gVGhlIGJhY2tsaWdodCBwb3dlciBpbnRlcmZhY2UgaXRzZWxmIGlzIHN0aWxsIGEg bWFzc2l2ZSBtZXNzLgo+Cj4gQ2M6IExlZSBKb25lcyA8bGVlLmpvbmVzQGxpbmFyby5vcmc+Cj4g Q2M6IERhbmllbCBUaG9tcHNvbiA8ZGFuaWVsLnRob21wc29uQGxpbmFyby5vcmc+Cj4gQ2M6IEpp bmdvbyBIYW4gPGppbmdvb2hhbjFAZ21haWwuY29tPgo+IEFja2VkLWJ5OiBEYW5pZWwgVGhvbXBz b24gPGRhbmllbC50aG9tcHNvbkBsaW5hcm8ub3JnPgo+IFNpZ25lZC1vZmYtYnk6IERhbmllbCBW ZXR0ZXIgPGRhbmllbC52ZXR0ZXJAaW50ZWwuY29tPgo+IC0tLQo+ICBpbmNsdWRlL2xpbnV4L2Jh Y2tsaWdodC5oIHwgMSAtCj4gIDEgZmlsZSBjaGFuZ2VkLCAxIGRlbGV0aW9uKC0pCj4KPiBkaWZm IC0tZ2l0IGEvaW5jbHVkZS9saW51eC9iYWNrbGlnaHQuaCBiL2luY2x1ZGUvbGludXgvYmFja2xp Z2h0LmgKPiBpbmRleCAxZGI2NzY2MmJmY2IuLjdmYmYwNTM5ZTE0YSAxMDA2NDQKPiAtLS0gYS9p bmNsdWRlL2xpbnV4L2JhY2tsaWdodC5oCj4gKysrIGIvaW5jbHVkZS9saW51eC9iYWNrbGlnaHQu aAo+IEBAIC04NCw3ICs4NCw2IEBAIHN0cnVjdCBiYWNrbGlnaHRfcHJvcGVydGllcyB7Cj4gIAo+ ICAjZGVmaW5lIEJMX0NPUkVfU1VTUEVOREVECSgxIDw8IDApCS8qIGJhY2tsaWdodCBpcyBzdXNw ZW5kZWQgKi8KPiAgI2RlZmluZSBCTF9DT1JFX0ZCQkxBTksJCSgxIDw8IDEpCS8qIGJhY2tsaWdo dCBpcyB1bmRlciBhbiBmYiBibGFuayBldmVudCAqLwo+IC0jZGVmaW5lIEJMX0NPUkVfRFJJVkVS MQkJKDEgPDwgMzEpCS8qIHJlc2VydmVkIGZvciBkcml2ZXIgc3BlY2lmaWMgdXNlICovCgpQbGVh c2UgYWxzbyByZW1vdmUgdGhlCgoJLyogVXBwZXIgNCBiaXRzIGFyZSByZXNlcnZlZCBmb3IgZHJp dmVyIGludGVybmFsIHVzZSAqLwoKY29tbWVudCBhIGZldyBsaW5lcyB1cCB0byBub3QgZ2l2ZSBh bnlvbmUgaWRlYXMuCgpXaXRoIHRoYXQsCgpSZXZpZXdlZC1ieTogSmFuaSBOaWt1bGEgPGphbmku bmlrdWxhQGludGVsLmNvbT4KCj4gIAo+ICB9OwoKLS0gCkphbmkgTmlrdWxhLCBJbnRlbCBPcGVu IFNvdXJjZSBUZWNobm9sb2d5IENlbnRlcgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5m cmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0 aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752534AbeD3KVh (ORCPT ); Mon, 30 Apr 2018 06:21:37 -0400 Received: from mga17.intel.com ([192.55.52.151]:60090 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751361AbeD3KVg (ORCPT ); Mon, 30 Apr 2018 06:21:36 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,346,1520924400"; d="scan'208";a="51102190" From: Jani Nikula To: Daniel Vetter , DRI Development , LKML Cc: Daniel Vetter , Daniel Vetter , Daniel Thompson , Lee Jones , Jingoo Han Subject: Re: [PATCH 5/6] backlight: Also nuke BL_CORE_DRIVER1 In-Reply-To: <20180425174253.4616-5-daniel.vetter@ffwll.ch> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20180425174253.4616-1-daniel.vetter@ffwll.ch> <20180425174253.4616-5-daniel.vetter@ffwll.ch> Date: Mon, 30 Apr 2018 13:24:16 +0300 Message-ID: <87d0yh9elr.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 25 Apr 2018, Daniel Vetter wrote: > Now that the 3 drivers using this are cleaned up we can also remove > this final bit of confusion of leaking driver internals into the > backlight power interface. > > The backlight power interface itself is still a massive mess. > > Cc: Lee Jones > Cc: Daniel Thompson > Cc: Jingoo Han > Acked-by: Daniel Thompson > Signed-off-by: Daniel Vetter > --- > include/linux/backlight.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/include/linux/backlight.h b/include/linux/backlight.h > index 1db67662bfcb..7fbf0539e14a 100644 > --- a/include/linux/backlight.h > +++ b/include/linux/backlight.h > @@ -84,7 +84,6 @@ struct backlight_properties { > > #define BL_CORE_SUSPENDED (1 << 0) /* backlight is suspended */ > #define BL_CORE_FBBLANK (1 << 1) /* backlight is under an fb blank event */ > -#define BL_CORE_DRIVER1 (1 << 31) /* reserved for driver specific use */ Please also remove the /* Upper 4 bits are reserved for driver internal use */ comment a few lines up to not give anyone ideas. With that, Reviewed-by: Jani Nikula > > }; -- Jani Nikula, Intel Open Source Technology Center