From mboxrd@z Thu Jan 1 00:00:00 1970 From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= Subject: Re: [PATCH net-next v3] Add Common Applications Kept Enhanced (cake) qdisc Date: Wed, 25 Apr 2018 20:46:12 +0200 Message-ID: <87d0yn5dl7.fsf@toke.dk> References: <20180425134249.21300-1-toke@toke.dk> <20180425.143948.235979083753006.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Cc: netdev@vger.kernel.org, cake@lists.bufferbloat.net, dave.taht@gmail.com To: David Miller Return-path: Received: from mail.toke.dk ([52.28.52.200]:40433 "EHLO mail.toke.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755917AbeDYSqP (ORCPT ); Wed, 25 Apr 2018 14:46:15 -0400 In-Reply-To: <20180425.143948.235979083753006.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-ID: David Miller writes: > From: Toke H=C3=B8iland-J=C3=B8rgensen > Date: Wed, 25 Apr 2018 15:42:48 +0200 > >> +static void *cake_zalloc(size_t sz) >> +{ >> + void *ptr =3D kzalloc(sz, GFP_KERNEL | __GFP_NOWARN); >> + >> + if (!ptr) >> + ptr =3D vzalloc(sz); >> + return ptr; >> +} > > This is just kvzalloc(sz, GFP_KERNEL | __GFP_NOWARN)? Ah yes; we actually fixed that before, but guess it got lost this time around. Will fix :) -Toke