From: "Alex Bennée" <alex.bennee@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Max Filippov <jcmvbkbc@gmail.com>,
qemu-devel <qemu-devel@nongnu.org>,
Laurent Vivier <laurent@vivier.eu>
Subject: Re: [Qemu-devel] [PATCH] linux-user: call cpu_copy under clone_lock
Date: Wed, 04 Apr 2018 13:52:09 +0100 [thread overview]
Message-ID: <87d0zfcex2.fsf@linaro.org> (raw)
In-Reply-To: <CAFEAcA_WJSoa0-3w7uKZo_zScPCM6qQCfyXiiU44OTV-w_0q+g@mail.gmail.com>
Peter Maydell <peter.maydell@linaro.org> writes:
> On 4 April 2018 at 11:27, Alex Bennée <alex.bennee@linaro.org> wrote:
>> I'm wondering if it should be doing more. After all start/end_exclusive
>> rely on the cpu list and that isn't updated on thread creation - and
>> without that a bunch of other things fail like ld/st exclusive after
>> your first new thread is spawned.
>
> I think that is handled because creating a new thread calls
> cpu_copy(), which creates a new CPU object, which adds itself
> to the CPU list in its realize function (same as for system
> emulation new CPU objects).
Ahh that makes sense - I missed it hidden behind the realize.
--
Alex Bennée
prev parent reply other threads:[~2018-04-04 12:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-30 13:35 [Qemu-devel] [PATCH] linux-user: call cpu_copy under clone_lock Max Filippov
2018-03-30 14:00 ` Laurent Vivier
2018-03-31 8:55 ` no-reply
2018-04-03 16:26 ` Alex Bennée
2018-04-03 17:11 ` Max Filippov
2018-04-04 10:27 ` Alex Bennée
2018-04-04 11:20 ` Peter Maydell
2018-04-04 12:52 ` Alex Bennée [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d0zfcex2.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=jcmvbkbc@gmail.com \
--cc=laurent@vivier.eu \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.