From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Kuoppala Subject: Re: [PATCH 1/7] drm/i915: Disable preemption and sleeping while using the punit sideband Date: Wed, 10 Jan 2018 15:45:27 +0200 Message-ID: <87d12hketk.fsf@gaia.fi.intel.com> References: <20180110125511.11127-1-chris@chris-wilson.co.uk> <20180110125511.11127-2-chris@chris-wilson.co.uk> <976e432a-b49e-0fd7-ce34-6f11aff8de45@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0A9FB6E2BB for ; Wed, 10 Jan 2018 13:47:01 +0000 (UTC) In-Reply-To: <976e432a-b49e-0fd7-ce34-6f11aff8de45@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Hans de Goede , Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org SGFucyBkZSBHb2VkZSA8aGRlZ29lZGVAcmVkaGF0LmNvbT4gd3JpdGVzOgoKPiBIaSwKPgo+IE9u IDEwLTAxLTE4IDEzOjU1LCBDaHJpcyBXaWxzb24gd3JvdGU6Cj4+IFdoaWxlIHdlIHRhbGsgdG8g dGhlIHB1bml0IG92ZXIgaXRzIHNpZGViYW5kLCB3ZSBuZWVkIHRvIHByZXZlbnQgdGhlIGNwdQo+ PiBmcm9tIHNsZWVwaW5nIGluIG9yZGVyIHRvIHByZXZlbnQgYSBwb3RlbnRpYWwgbWFjaGluZSBo YW5nLgo+PiAKPj4gTm90ZSB0aGF0IGJ5IGl0c2VsZiwgaXQgYXBwZWFycyB0aGF0IHBtX3Fvc191 cGRhdGVfcmVxdWVzdCAodmlhCj4+IGludGVsX2lkbGUpIGRvZXNuJ3QgcHJvdmlkZSBhIHN1ZmZp Y2llbnQgYmFycmllciB0byBlbnN1cmUgdGhhdCBhbGwgY29yZQo+PiBhcmUgaW5kZWVkIGF3YWtl IChvdXQgb2YgQ3N0YXRlKSBhbmQgdGhhdCB0aGUgcGFja2FnZSBpcyBhd2FrZS4gVG8gZG8gc28s Cj4+IHdlIG5lZWQgdG8gc3VwcGxlbWVudCB0aGUgcG1fcW9zIHdpdGggYSBtYW51YWwgcGluZyBv bl9lYWNoX2NwdS4KPj4gCj4+IEJ1Z3ppbGxhOiBodHRwczovL2J1Z3ppbGxhLmtlcm5lbC5vcmcv c2hvd19idWcuY2dpP2lkPTEwOTA1MQo+PiBSZWZlcmVuY2VzOiBodHRwczovL2J1Z3MuZnJlZWRl c2t0b3Aub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDI2NTcKPj4gUmVmZXJlbmNlczogaHR0cHM6Ly9i dWd6aWxsYS5rZXJuZWwub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTUyNTUKPj4gU2lnbmVkLW9mZi1i eTogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+Cj4+IENjOiBNaWthIEt1 b3BwYWxhIDxtaWthLmt1b3BwYWxhQGxpbnV4LmludGVsLmNvbT4KPj4gQ2M6IEhhbnMgZGUgR29l ZGUgPGhkZWdvZWRlQHJlZGhhdC5jb20+Cj4KPiBJbnRlcmVzdGluZywgSSd2ZSBhZGRlZCBzaW1p bGFyIHBtX3FvcyBjb2RlIGluCj4gZHJpdmVycy9pMmMvYnVzc2VzL2kyYy1kZXNpZ253YXJlLWJh eXRyYWlsLmMgcXVpdGUgYSB3aGlsZSBhZ28gYmVjYXVzZQo+IHRoZSBDUFUgdHJhbnNpdGlvbmlu ZyB0byBoaWdoZXIgQy1zdGF0ZSB3aGlsZSBhY2Nlc3NpbmcgdGhlIGkyYyBidXMgdG8KPiB0aGUg cG1pYyAoaWYgaXQgaXMgc2hhcmVkKSBhbHNvIGNhdXNlcyB0aGUgU29DIHRvIGhhbmcuCj4KPiBJ IGNvdWxkIHJlcHJvZHVjZSB0aGlzIHF1aXRlIGVhc2lseSBieSBkb2luZyAiaTJjZHVtcCIgb24g dGhlIHBtaWMsCj4gdXN1YWxseSB0aGUgc3lzdGVtIHdvdWxkIGhhbmcgaW4gb25lIG9yIDIgaTJj ZHVtcCBjYWxscy4KPgo+IE5vdGUgSUlSQyB0aGlzIHdhcyBvbiBDSFQuCj4KPiBJIHNlZSB0aGF0 IHlvdSBhbHNvIGJsb2NrIGFueSBwbWljLWkyYyBidXMgYWNjZXNzZXMgd2hpbGUgZG9pbmcKPiBw dW5pdCBhY2Nlc3MgYnkgY2FsbGluZyBpb3NmX21iaV9wdW5pdF9hY3F1aXJlKCk7Cj4KPiBNYXli ZSB3ZSBuZWVkIHRvIG1vdmUgdGhlIHBtX3FvcyBzdHVmZiBvdXQgb2YKPiBkcml2ZXJzL2kyYy9i dXNzZXMvaTJjLWRlc2lnbndhcmUtYmF5dHJhaWwuYwo+Cj4gQW5kIGludG8gaW9zZl9tYmlfcHVu aXRfYWNxdWlyZT8gVGhlIGkyYy1kZXNpZ253YXJlLWJheXRyYWlsLmMKPiBkb2VzIGl0cyBvd24g cG1fcW9zIGRhbmNlIGRpcmVjdGx5IGFmdGVyIGNhbGxpbmcKPiBpb3NmX21iaV9wdW5pdF9hY3F1 aXJlIC8gYmVmb3JlIGNhbGxpbmcgaW9zZl9tYmlfcHVuaXRfcmVsZWFzZSgpOwo+Cj4gTm90ZSB0 aGUgaTJjLWRlc2lnbndhcmUtYmF5dHJhaWwuYyB2ZXJzaW9uIGxhY2tzIHRoZSBwaW5nLCBidXQg aXQKPiBzaG91bGQsIHByb2JhYmx5IGhhdmUgaXQgdG9vLgoKVGhlIHBpbmcsIGlmIGl0IGRlZW1l ZCB3b3J0aHksIHNob3VsZCBmaW5kIGl0cyB3YXkgaW50byBpbnRlbF9pZGxlCnBhcnRzLgoKLU1p a2EKCj4KPiBSZWdhcmRzLAo+Cj4gSGFucwo+Cj4KPgo+PiAtLS0KPj4gICBkcml2ZXJzL2dwdS9k cm0vaTkxNS9pOTE1X2Rydi5jICAgICAgIHwgIDYgKysrKwo+PiAgIGRyaXZlcnMvZ3B1L2RybS9p OTE1L2k5MTVfZHJ2LmggICAgICAgfCAgMSArCj4+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfc2lkZWJhbmQuYyB8IDYxICsrKysrKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tCj4+ ICAgMyBmaWxlcyBjaGFuZ2VkLCA1MCBpbnNlcnRpb25zKCspLCAxOCBkZWxldGlvbnMoLSkKPj4g Cj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5jIGIvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuYwo+PiBpbmRleCA2YzhkYTlkMjBjMzMuLmQ0YjkwY2Mw MTMwYiAxMDA2NDQKPj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuYwo+PiAr KysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5jCj4+IEBAIC05MDIsNiArOTAyLDkg QEAgc3RhdGljIGludCBpOTE1X2RyaXZlcl9pbml0X2Vhcmx5KHN0cnVjdCBkcm1faTkxNV9wcml2 YXRlICpkZXZfcHJpdiwKPj4gICAJc3Bpbl9sb2NrX2luaXQoJmRldl9wcml2LT51bmNvcmUubG9j ayk7Cj4+ICAgCj4+ICAgCW11dGV4X2luaXQoJmRldl9wcml2LT5zYl9sb2NrKTsKPj4gKwlwbV9x b3NfYWRkX3JlcXVlc3QoJmRldl9wcml2LT5zYl9xb3MsCj4+ICsJCQkgICBQTV9RT1NfQ1BVX0RN QV9MQVRFTkNZLCBQTV9RT1NfREVGQVVMVF9WQUxVRSk7Cj4+ICsKPj4gICAJbXV0ZXhfaW5pdCgm ZGV2X3ByaXYtPm1vZGVzZXRfcmVzdG9yZV9sb2NrKTsKPj4gICAJbXV0ZXhfaW5pdCgmZGV2X3By aXYtPmF2X211dGV4KTsKPj4gICAJbXV0ZXhfaW5pdCgmZGV2X3ByaXYtPndtLndtX211dGV4KTsK Pj4gQEAgLTk1Myw2ICs5NTYsOSBAQCBzdGF0aWMgdm9pZCBpOTE1X2RyaXZlcl9jbGVhbnVwX2Vh cmx5KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPj4gICAJaW50ZWxfaXJxX2Zp bmkoZGV2X3ByaXYpOwo+PiAgIAlpOTE1X3dvcmtxdWV1ZXNfY2xlYW51cChkZXZfcHJpdik7Cj4+ ICAgCWk5MTVfZW5naW5lc19jbGVhbnVwKGRldl9wcml2KTsKPj4gKwo+PiArCXBtX3Fvc19yZW1v dmVfcmVxdWVzdCgmZGV2X3ByaXYtPnNiX3Fvcyk7Cj4+ICsJbXV0ZXhfZGVzdHJveSgmZGV2X3By aXYtPnNiX2xvY2spOwo+PiAgIH0KPj4gICAKPj4gICBzdGF0aWMgaW50IGk5MTVfbW1pb19zZXR1 cChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4+IGRpZmYgLS1naXQgYS9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9k cnYuaAo+PiBpbmRleCBhNjg5Mzk2ZDBmZjYuLmZmM2Y5ZWZmYzBiYiAxMDA2NDQKPj4gLS0tIGEv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaAo+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pOTE1X2Rydi5oCj4+IEBAIC0xODg3LDYgKzE4ODcsNyBAQCBzdHJ1Y3QgZHJtX2k5MTVf cHJpdmF0ZSB7Cj4+ICAgCj4+ICAgCS8qIFNpZGViYW5kIG1haWxib3ggcHJvdGVjdGlvbiAqLwo+ PiAgIAlzdHJ1Y3QgbXV0ZXggc2JfbG9jazsKPj4gKwlzdHJ1Y3QgcG1fcW9zX3JlcXVlc3Qgc2Jf cW9zOwo+PiAgIAo+PiAgIAkvKiogQ2FjaGVkIHZhbHVlIG9mIElNUiB0byBhdm9pZCByZWFkcyBp biB1cGRhdGluZyB0aGUgYml0ZmllbGQgKi8KPj4gICAJdW5pb24gewo+PiBkaWZmIC0tZ2l0IGEv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfc2lkZWJhbmQuYyBiL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX3NpZGViYW5kLmMKPj4gaW5kZXggNzVjODcyYmI4Y2M5Li4wMmJkZDJlMmNlZjYg MTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3NpZGViYW5kLmMKPj4g KysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfc2lkZWJhbmQuYwo+PiBAQCAtMjIsNiAr MjIsOCBAQAo+PiAgICAqCj4+ICAgICovCj4+ICAgCj4+ICsjaW5jbHVkZSA8YXNtL2lvc2ZfbWJp Lmg+Cj4+ICsKPj4gICAjaW5jbHVkZSAiaTkxNV9kcnYuaCIKPj4gICAjaW5jbHVkZSAiaW50ZWxf ZHJ2LmgiCj4+ICAgCj4+IEBAIC0zOSwxOCArNDEsMjAgQEAKPj4gICAvKiBQcml2YXRlIHJlZ2lz dGVyIHdyaXRlLCBkb3VibGUtd29yZCBhZGRyZXNzaW5nLCBub24tcG9zdGVkICovCj4+ICAgI2Rl ZmluZSBTQl9DUldSREFfTlAJMHgwNwo+PiAgIAo+PiAtc3RhdGljIGludCB2bHZfc2lkZWJhbmRf cncoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LCB1MzIgZGV2Zm4sCj4+IC0JCQkg ICB1MzIgcG9ydCwgdTMyIG9wY29kZSwgdTMyIGFkZHIsIHUzMiAqdmFsKQo+PiArc3RhdGljIHZv aWQgcGluZyh2b2lkICppbmZvKQo+PiAgIHsKPj4gLQl1MzIgY21kLCBiZSA9IDB4ZiwgYmFyID0g MDsKPj4gLQlib29sIGlzX3JlYWQgPSAob3Bjb2RlID09IFNCX01SRF9OUCB8fCBvcGNvZGUgPT0g U0JfQ1JSRERBX05QKTsKPj4gK30KPj4gICAKPj4gLQljbWQgPSAoZGV2Zm4gPDwgSU9TRl9ERVZG Tl9TSElGVCkgfCAob3Bjb2RlIDw8IElPU0ZfT1BDT0RFX1NISUZUKSB8Cj4+IC0JCShwb3J0IDw8 IElPU0ZfUE9SVF9TSElGVCkgfCAoYmUgPDwgSU9TRl9CWVRFX0VOQUJMRVNfU0hJRlQpIHwKPj4g LQkJKGJhciA8PCBJT1NGX0JBUl9TSElGVCk7Cj4+ICtzdGF0aWMgaW50IHZsdl9zaWRlYmFuZF9y dyhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4+ICsJCQkgICB1MzIgZGV2Zm4s IHUzMiBwb3J0LCB1MzIgb3Bjb2RlLAo+PiArCQkJICAgdTMyIGFkZHIsIHUzMiAqdmFsKQo+PiAr ewo+PiArCWNvbnN0IGJvb2wgaXNfcmVhZCA9IChvcGNvZGUgPT0gU0JfTVJEX05QIHx8IG9wY29k ZSA9PSBTQl9DUlJEREFfTlApOwo+PiArCWludCBlcnI7Cj4+ICAgCj4+IC0JV0FSTl9PTighbXV0 ZXhfaXNfbG9ja2VkKCZkZXZfcHJpdi0+c2JfbG9jaykpOwo+PiArCWxvY2tkZXBfYXNzZXJ0X2hl bGQoJmRldl9wcml2LT5zYl9sb2NrKTsKPj4gICAKPj4gKwkvKiBGbHVzaCB0aGUgcHJldmlvdXMg Y29tbXMsIGp1c3QgaW4gY2FzZSBpdCBmYWlsZWQgbGFzdCB0aW1lLiAqLwo+PiAgIAlpZiAoaW50 ZWxfd2FpdF9mb3JfcmVnaXN0ZXIoZGV2X3ByaXYsCj4+ICAgCQkJCSAgICBWTFZfSU9TRl9ET09S QkVMTF9SRVEsIElPU0ZfU0JfQlVTWSwgMCwKPj4gICAJCQkJICAgIDUpKSB7Cj4+IEBAIC01OSwy MiArNjMsNDMgQEAgc3RhdGljIGludCB2bHZfc2lkZWJhbmRfcncoc3RydWN0IGRybV9pOTE1X3By aXZhdGUgKmRldl9wcml2LCB1MzIgZGV2Zm4sCj4+ICAgCQlyZXR1cm4gLUVBR0FJTjsKPj4gICAJ fQo+PiAgIAo+PiAtCUk5MTVfV1JJVEUoVkxWX0lPU0ZfQUREUiwgYWRkcik7Cj4+IC0JSTkxNV9X UklURShWTFZfSU9TRl9EQVRBLCBpc19yZWFkID8gMCA6ICp2YWwpOwo+PiAtCUk5MTVfV1JJVEUo VkxWX0lPU0ZfRE9PUkJFTExfUkVRLCBjbWQpOwo+PiArCWlvc2ZfbWJpX3B1bml0X2FjcXVpcmUo KTsKPj4gICAKPj4gLQlpZiAoaW50ZWxfd2FpdF9mb3JfcmVnaXN0ZXIoZGV2X3ByaXYsCj4+IC0J CQkJICAgIFZMVl9JT1NGX0RPT1JCRUxMX1JFUSwgSU9TRl9TQl9CVVNZLCAwLAo+PiAtCQkJCSAg ICA1KSkgewo+PiArCS8qCj4+ICsJICogUHJldmVudCB0aGUgY3B1IGZyb20gc2xlZXBpbmcgd2hp bGUgd2UgdXNlIHRoaXMgc2lkZWJhbmQsIG90aGVyd2lzZQo+PiArCSAqIHRoZSBwdW5pdCBtYXkg Y2F1c2UgYSBtYWNoaW5lIGhhbmcuCj4+ICsJICovCj4+ICsJcG1fcW9zX3VwZGF0ZV9yZXF1ZXN0 KCZkZXZfcHJpdi0+c2JfcW9zLCAwKTsKPj4gKwlvbl9lYWNoX2NwdShwaW5nLCBOVUxMLCAxKTsK Pj4gKwlwcmVlbXB0X2Rpc2FibGUoKTsKPj4gKwo+PiArCUk5MTVfV1JJVEVfRlcoVkxWX0lPU0Zf QUREUiwgYWRkcik7Cj4+ICsJSTkxNV9XUklURV9GVyhWTFZfSU9TRl9EQVRBLCBpc19yZWFkID8g MCA6ICp2YWwpOwo+PiArCUk5MTVfV1JJVEVfRlcoVkxWX0lPU0ZfRE9PUkJFTExfUkVRLAo+PiAr CQkgICAgICAoZGV2Zm4gPDwgSU9TRl9ERVZGTl9TSElGVCkgfAo+PiArCQkgICAgICAob3Bjb2Rl IDw8IElPU0ZfT1BDT0RFX1NISUZUKSB8Cj4+ICsJCSAgICAgIChwb3J0IDw8IElPU0ZfUE9SVF9T SElGVCkgfAo+PiArCQkgICAgICAoMHhmIDw8IElPU0ZfQllURV9FTkFCTEVTX1NISUZUKSB8Cj4+ ICsJCSAgICAgICgwIDw8IElPU0ZfQkFSX1NISUZUKSB8Cj4+ICsJCSAgICAgIElPU0ZfU0JfQlVT WSk7Cj4+ICsKPj4gKwlpZiAoX19pbnRlbF93YWl0X2Zvcl9yZWdpc3Rlcl9mdyhkZXZfcHJpdiwK Pj4gKwkJCQkJIFZMVl9JT1NGX0RPT1JCRUxMX1JFUSwgSU9TRl9TQl9CVVNZLCAwLAo+PiArCQkJ CQkgMTAwMDAsIDAsIE5VTEwpID09IDApIHsKPj4gKwkJaWYgKGlzX3JlYWQpCj4+ICsJCQkqdmFs ID0gSTkxNV9SRUFEX0ZXKFZMVl9JT1NGX0RBVEEpOwo+PiArCQllcnIgPSAwOwo+PiArCX0gZWxz ZSB7Cj4+ICAgCQlEUk1fREVCVUdfRFJJVkVSKCJJT1NGIHNpZGViYW5kIGZpbmlzaCB3YWl0ICgl cykgdGltZWQgb3V0XG4iLAo+PiAgIAkJCQkgaXNfcmVhZCA/ICJyZWFkIiA6ICJ3cml0ZSIpOwo+ PiAtCQlyZXR1cm4gLUVUSU1FRE9VVDsKPj4gKwkJZXJyID0gLUVUSU1FRE9VVDsKPj4gICAJfQo+ PiAgIAo+PiAtCWlmIChpc19yZWFkKQo+PiAtCQkqdmFsID0gSTkxNV9SRUFEKFZMVl9JT1NGX0RB VEEpOwo+PiArCXByZWVtcHRfZW5hYmxlKCk7Cj4+ICsJcG1fcW9zX3VwZGF0ZV9yZXF1ZXN0KCZk ZXZfcHJpdi0+c2JfcW9zLCBQTV9RT1NfREVGQVVMVF9WQUxVRSk7Cj4+ICsJaW9zZl9tYmlfcHVu aXRfcmVsZWFzZSgpOwo+PiAgIAo+PiAtCXJldHVybiAwOwo+PiArCXJldHVybiBlcnI7Cj4+ICAg fQo+PiAgIAo+PiAgIHUzMiB2bHZfcHVuaXRfcmVhZChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAq ZGV2X3ByaXYsIHUzMiBhZGRyKQo+PiAKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJl ZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGlu Zm8vaW50ZWwtZ2Z4Cg==