From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752405AbdJDOKq (ORCPT ); Wed, 4 Oct 2017 10:10:46 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45134 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752366AbdJDOKp (ORCPT ); Wed, 4 Oct 2017 10:10:45 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 35A0BC059B82 Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=vkuznets@redhat.com From: Vitaly Kuznetsov To: Stephen Hemminger Cc: devel@linuxdriverproject.org, Stephen Hemminger , Haiyang Zhang , linux-kernel@vger.kernel.org, Steven Rostedt Subject: Re: [PATCH v2 16/16] hyper-v: trace vmbus_send_tl_connect_request() References: <20170929132602.24487-1-vkuznets@redhat.com> <20170929132602.24487-17-vkuznets@redhat.com> <20171003101001.2c8e4ad8@xeon-e3> Date: Wed, 04 Oct 2017 16:10:42 +0200 In-Reply-To: <20171003101001.2c8e4ad8@xeon-e3> (Stephen Hemminger's message of "Tue, 3 Oct 2017 10:10:01 -0700") Message-ID: <87d163j95p.fsf@vitty.brq.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Wed, 04 Oct 2017 14:10:45 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Stephen Hemminger writes: > I added an additional set of trace points for when channel gets notified or signals host. > Will add this in v3, thanks! > diff -urNp linux-msft/drivers/hv/channel.c msft-4.14-rc3/drivers/hv/channel.c > --- linux-msft/drivers/hv/channel.c 2017-10-03 10:06:54.893209237 -0700 > +++ msft-4.14-rc3/drivers/hv/channel.c 2017-10-03 10:07:35.501665114 -0700 > @@ -55,6 +55,8 @@ void vmbus_setevent(struct vmbus_channel > { > struct hv_monitor_page *monitorpage; > > + trace_vmbus_setevent(channel); > + > /* > * For channels marked as in "low latency" mode > * bypass the monitor page mechanism. > diff -urNp linux-msft/drivers/hv/connection.c msft-4.14-rc3/drivers/hv/connection.c > --- linux-msft/drivers/hv/connection.c 2017-10-03 10:06:54.893209237 -0700 > +++ msft-4.14-rc3/drivers/hv/connection.c 2017-10-03 10:07:35.501665114 -0700 > @@ -322,6 +322,8 @@ void vmbus_on_event(unsigned long data) > struct vmbus_channel *channel = (void *) data; > unsigned long time_limit = jiffies + 2; > > + trace_vmbus_on_event(channel); > + > do { > void (*callback_fn)(void *); > > diff -urNp linux-msft/drivers/hv/hv_trace.h msft-4.14-rc3/drivers/hv/hv_trace.h > --- linux-msft/drivers/hv/hv_trace.h 2017-10-03 10:08:06.514014019 -0700 > +++ msft-4.14-rc3/drivers/hv/hv_trace.h 2017-10-03 10:07:35.505665159 -0700 > @@ -294,6 +294,29 @@ TRACE_EVENT(vmbus_send_tl_connect_reques > ) > ); > > +DECLARE_EVENT_CLASS(vmbus_channel, > + TP_PROTO(const struct vmbus_channel *channel), > + TP_ARGS(channel), > + TP_STRUCT__entry(__field(u32, relid)), > + TP_fast_assign(__entry->relid = channel->offermsg.child_relid), > + TP_printk("relid 0x%x", __entry->relid) > +); > + > +DEFINE_EVENT(vmbus_channel, vmbus_chan_sched, > + TP_PROTO(const struct vmbus_channel *channel), > + TP_ARGS(channel) > +); > + > +DEFINE_EVENT(vmbus_channel, vmbus_setevent, > + TP_PROTO(const struct vmbus_channel *channel), > + TP_ARGS(channel) > +); > + > +DEFINE_EVENT(vmbus_channel, vmbus_on_event, > + TP_PROTO(const struct vmbus_channel *channel), > + TP_ARGS(channel) > +); > + > #undef TRACE_INCLUDE_PATH > #define TRACE_INCLUDE_PATH . > #undef TRACE_INCLUDE_FILE > diff -urNp linux-msft/drivers/hv/vmbus_drv.c msft-4.14-rc3/drivers/hv/vmbus_drv.c > --- linux-msft/drivers/hv/vmbus_drv.c 2017-10-03 10:06:54.897209282 -0700 > +++ msft-4.14-rc3/drivers/hv/vmbus_drv.c 2017-10-03 10:07:35.505665159 -0700 > @@ -948,6 +948,7 @@ static void vmbus_chan_sched(struct hv_p > continue; > > ++channel->interrupts_in; > + trace_vmbus_chan_sched(channel); > > switch (channel->callback_mode) { > case HV_CALL_ISR: -- Vitaly