From: Andi Kleen <andi@firstfloor.org>
To: Jiri Olsa <jolsa@kernel.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
lkml <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Kan Liang <kan.liang@intel.com>
Subject: Re: [PATCH] perf/x86/intel: Fix debug_store reset field for freq events
Date: Fri, 14 Jul 2017 10:22:49 -0700 [thread overview]
Message-ID: <87d193lyqe.fsf@firstfloor.org> (raw)
In-Reply-To: <20170714163551.19459-1-jolsa@kernel.org> (Jiri Olsa's message of "Fri, 14 Jul 2017 18:35:51 +0200")
Jiri Olsa <jolsa@kernel.org> writes:
>
> Setting the reset field to 0 for freq events.
Looks good to me.
Reviewed-by: Andi Kleen <ak@linux.intel.com>
BTW I suspect there's a related bug that
perf record -e '{cycles:pp,branches}:S' ..
would enable multi record PEBS, even though it shouldn't because
we need the PMI to read the other events.
-Andi
next prev parent reply other threads:[~2017-07-14 17:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-14 16:35 [PATCH] perf/x86/intel: Fix debug_store reset field for freq events Jiri Olsa
2017-07-14 17:22 ` Andi Kleen [this message]
2017-07-17 7:38 ` Jiri Olsa
2017-07-17 11:37 ` Jiri Olsa
2017-07-17 18:07 ` Andi Kleen
2017-07-18 10:44 ` [tip:perf/urgent] " tip-bot for Jiri Olsa
2017-07-18 12:16 ` tip-bot for Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d193lyqe.fsf@firstfloor.org \
--to=andi@firstfloor.org \
--cc=a.p.zijlstra@chello.nl \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.