From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44737) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dUTiG-0001im-Na for qemu-devel@nongnu.org; Mon, 10 Jul 2017 04:06:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dUTiD-0006vq-J0 for qemu-devel@nongnu.org; Mon, 10 Jul 2017 04:06:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48866) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dUTiD-0006uw-9f for qemu-devel@nongnu.org; Mon, 10 Jul 2017 04:06:33 -0400 From: Markus Armbruster References: <0a1d5638543965d532284bdc6fce391cf9f509d0.1499381754.git.alistair.francis@xilinx.com> <84wp7layt8.wl-Peter.Chubb@data61.csiro.au> Date: Mon, 10 Jul 2017 10:06:18 +0200 In-Reply-To: (Alistair Francis's message of "Fri, 7 Jul 2017 10:19:20 -0700") Message-ID: <87d1987m2t.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH v1 3/6] Convert error_report() to warn_report() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alistair Francis Cc: Peter.Chubb@data61.csiro.au, Peter Maydell , cohuck@redhat.com, Stefan Hajnoczi , "Michael S. Tsirkin" , jcody@redhat.com, "qemu-devel@nongnu.org Developers" , Alexander Graf , Gerd Hoffmann , Eduardo Habkost , Rob Herring , jdurgin@redhat.com, Christian Borntraeger , Marcel Apfelbaum , David Gibson , Jason Wang , philippe@mathieu-daude.net, pl@kamp.de, groug@kaod.org, Peter Chubb , ronniesahlberg@gmail.com, Igor Mammedov , Richard Henderson , Kevin Wolf , Peter Crosthwaite , Marcelo Tosatti , rjones@redhat.com, Max Reitz , aneesh.kumar@linux.vnet.ibm.com, Paolo Bonzini Alistair Francis writes: > On Thu, Jul 6, 2017 at 5:14 PM, wrote: >>>>>>> "Alistair" == Alistair Francis writes: >> >> Alistair> Convert all uses of error_report("[Ww]arning:"... to use >> Alistair> warn_report() instead. This helps standardise on a single >> Alistair> method of printing warnings to the user. >> >> In a number of cases the initial double quote has been removed as >> well. This will have to be fixed. >> e.g., >> - error_report("Warning: 'filename' option specified. " >> + warn_report('filename' option specified. " > > Yeah, I thought I saw this when I was doing it, but then everything > compiled so I figured it was fine. > > It must not all be included with the default ./configure, because I > just tried again and it all compiles for me. The result of ./configure depends on the packages you got installed. You need quite a few development packages to get anywhere near a full compile. For a first step, you could do worse than installing your distribution's QEMU package's build dependencies. [...]