From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH v1] ACPI: Switch to use generic UUID API Date: Thu, 04 May 2017 12:37:27 +0300 Message-ID: <87d1bpotd4.fsf@intel.com> References: <20170504092151.88646-1-andriy.shevchenko@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20170504092151.88646-1-andriy.shevchenko@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: linux-acpi@vger.kernel.org, tpmdd-devel@lists.sourceforge.net, intel-gfx@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-input@vger.kernel.org, iommu@lists.linux-foundation.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-pci@vger.kernel.org, linux-usb@vger.kernel.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Cc: Felipe Balbi , Borislav Petkov , Mathias Nyman , Yisen Zhuang , Joerg Roedel , Amir Goldstein , "Rafael J . Wysocki" , Adrian Hunter , Jarkko Sakkinen , Liam Girdwood , Benjamin Tissoires , Heikki Krogerus , Ben Skeggs , Mark Brown , Bjorn Helgaas , Dan Williams , Andy Shevchenko , Mika Westerberg , Zhang Rui List-Id: alsa-devel@alsa-project.org T24gVGh1LCAwNCBNYXkgMjAxNywgQW5keSBTaGV2Y2hlbmtvIDxhbmRyaXkuc2hldmNoZW5rb0Bs aW51eC5pbnRlbC5jb20+IHdyb3RlOgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF9hY3BpLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9hY3BpLmMKPiBpbmRl eCBlYjYzOGExZTY5ZDIuLjcyYmZlNmNlYWRmOCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF9hY3BpLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9h Y3BpLmMKPiBAQCAtMTUsMTMgKzE1LDkgQEAgc3RhdGljIHN0cnVjdCBpbnRlbF9kc21fcHJpdiB7 Cj4gIAlhY3BpX2hhbmRsZSBkaGFuZGxlOwo+ICB9IGludGVsX2RzbV9wcml2Owo+ICAKPiAtc3Rh dGljIGNvbnN0IHU4IGludGVsX2RzbV9ndWlkW10gPSB7Cj4gLQkweGQzLCAweDczLCAweGQ4LCAw eDdlLAo+IC0JMHhkMCwgMHhjMiwKPiAtCTB4NGYsIDB4NGUsCj4gLQkweGE4LCAweDU0LAo+IC0J MHgwZiwgMHgxMywgMHgxNywgMHhiMCwgMHgxYywgMHgyYwo+IC19Owo+ICtzdGF0aWMgY29uc3Qg dXVpZF9sZSBpbnRlbF9kc21fZ3VpZCA9Cj4gKwlVVUlEX0xFKDB4N2VkODczZDMsIDB4YzJkMCwg MHg0ZTRmLAo+ICsJCTB4YTgsIDB4NTQsIDB4MGYsIDB4MTMsIDB4MTcsIDB4YjAsIDB4MWMsIDB4 MmMpOwo+ICAKPiAgc3RhdGljIGNoYXIgKmludGVsX2RzbV9wb3J0X25hbWUodTggaWQpCj4gIHsK PiBAQCAtODAsNyArNzYsNyBAQCBzdGF0aWMgdm9pZCBpbnRlbF9kc21fcGxhdGZvcm1fbXV4X2lu Zm8odm9pZCkKPiAgCWludCBpOwo+ICAJdW5pb24gYWNwaV9vYmplY3QgKnBrZywgKmNvbm5lY3Rv cl9jb3VudDsKPiAgCj4gLQlwa2cgPSBhY3BpX2V2YWx1YXRlX2RzbV90eXBlZChpbnRlbF9kc21f cHJpdi5kaGFuZGxlLCBpbnRlbF9kc21fZ3VpZCwKPiArCXBrZyA9IGFjcGlfZXZhbHVhdGVfZHNt X3R5cGVkKGludGVsX2RzbV9wcml2LmRoYW5kbGUsICZpbnRlbF9kc21fZ3VpZCwKPiAgCQkJSU5U RUxfRFNNX1JFVklTSU9OX0lELCBJTlRFTF9EU01fRk5fUExBVEZPUk1fTVVYX0lORk8sCj4gIAkJ CU5VTEwsIEFDUElfVFlQRV9QQUNLQUdFKTsKPiAgCWlmICghcGtnKSB7Cj4gQEAgLTExOCw3ICsx MTQsNyBAQCBzdGF0aWMgYm9vbCBpbnRlbF9kc21fcGNpX3Byb2JlKHN0cnVjdCBwY2lfZGV2ICpw ZGV2KQo+ICAJaWYgKCFkaGFuZGxlKQo+ICAJCXJldHVybiBmYWxzZTsKPiAgCj4gLQlpZiAoIWFj cGlfY2hlY2tfZHNtKGRoYW5kbGUsIGludGVsX2RzbV9ndWlkLCBJTlRFTF9EU01fUkVWSVNJT05f SUQsCj4gKwlpZiAoIWFjcGlfY2hlY2tfZHNtKGRoYW5kbGUsICZpbnRlbF9kc21fZ3VpZCwgSU5U RUxfRFNNX1JFVklTSU9OX0lELAo+ICAJCQkgICAgMSA8PCBJTlRFTF9EU01fRk5fUExBVEZPUk1f TVVYX0lORk8pKSB7Cj4gIAkJRFJNX0RFQlVHX0tNUygibm8gX0RTTSBtZXRob2QgZm9yIGludGVs IGRldmljZVxuIik7Cj4gIAkJcmV0dXJuIGZhbHNlOwoKVGhlIGRybS9pOTE1IGh1bmsgYWJvdmUg aXMKClJldmlld2VkLWJ5OiBKYW5pIE5pa3VsYSA8amFuaS5uaWt1bGFAaW50ZWwuY29tPgoKYW5k IGFja2VkIGZvciBtZXJnaW5nIHZpYSB3aGljaGV2ZXIgdHJlZSBpcyBzdWl0YWJsZS4KCgpCUiwK SmFuaS4KCi0tIApKYW5pIE5pa3VsYSwgSW50ZWwgT3BlbiBTb3VyY2UgVGVjaG5vbG9neSBDZW50 ZXIKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwt Z2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8v bGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Jani Nikula To: Andy Shevchenko , linux-acpi@vger.kernel.org, tpmdd-devel@lists.sourceforge.net, intel-gfx@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-input@vger.kernel.org, iommu@lists.linux-foundation.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-pci@vger.kernel.org, linux-usb@vger.kernel.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Cc: Andy Shevchenko , "Rafael J . Wysocki" , Mika Westerberg , Borislav Petkov , Dan Williams , Amir Goldstein , Jarkko Sakkinen , Ben Skeggs , Benjamin Tissoires , Joerg Roedel , Adrian Hunter , Yisen Zhuang , Bjorn Helgaas , Zhang Rui , Felipe Balbi , Mathias Nyman , Heikki Krogerus , Liam Girdwood , Mark Brown Subject: Re: [PATCH v1] ACPI: Switch to use generic UUID API In-Reply-To: <20170504092151.88646-1-andriy.shevchenko@linux.intel.com> References: <20170504092151.88646-1-andriy.shevchenko@linux.intel.com> Date: Thu, 04 May 2017 12:37:27 +0300 Message-ID: <87d1bpotd4.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-acpi-owner@vger.kernel.org List-ID: On Thu, 04 May 2017, Andy Shevchenko wrote: > diff --git a/drivers/gpu/drm/i915/intel_acpi.c b/drivers/gpu/drm/i915/intel_acpi.c > index eb638a1e69d2..72bfe6ceadf8 100644 > --- a/drivers/gpu/drm/i915/intel_acpi.c > +++ b/drivers/gpu/drm/i915/intel_acpi.c > @@ -15,13 +15,9 @@ static struct intel_dsm_priv { > acpi_handle dhandle; > } intel_dsm_priv; > > -static const u8 intel_dsm_guid[] = { > - 0xd3, 0x73, 0xd8, 0x7e, > - 0xd0, 0xc2, > - 0x4f, 0x4e, > - 0xa8, 0x54, > - 0x0f, 0x13, 0x17, 0xb0, 0x1c, 0x2c > -}; > +static const uuid_le intel_dsm_guid = > + UUID_LE(0x7ed873d3, 0xc2d0, 0x4e4f, > + 0xa8, 0x54, 0x0f, 0x13, 0x17, 0xb0, 0x1c, 0x2c); > > static char *intel_dsm_port_name(u8 id) > { > @@ -80,7 +76,7 @@ static void intel_dsm_platform_mux_info(void) > int i; > union acpi_object *pkg, *connector_count; > > - pkg = acpi_evaluate_dsm_typed(intel_dsm_priv.dhandle, intel_dsm_guid, > + pkg = acpi_evaluate_dsm_typed(intel_dsm_priv.dhandle, &intel_dsm_guid, > INTEL_DSM_REVISION_ID, INTEL_DSM_FN_PLATFORM_MUX_INFO, > NULL, ACPI_TYPE_PACKAGE); > if (!pkg) { > @@ -118,7 +114,7 @@ static bool intel_dsm_pci_probe(struct pci_dev *pdev) > if (!dhandle) > return false; > > - if (!acpi_check_dsm(dhandle, intel_dsm_guid, INTEL_DSM_REVISION_ID, > + if (!acpi_check_dsm(dhandle, &intel_dsm_guid, INTEL_DSM_REVISION_ID, > 1 << INTEL_DSM_FN_PLATFORM_MUX_INFO)) { > DRM_DEBUG_KMS("no _DSM method for intel device\n"); > return false; The drm/i915 hunk above is Reviewed-by: Jani Nikula and acked for merging via whichever tree is suitable. BR, Jani. -- Jani Nikula, Intel Open Source Technology Center From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH v1] ACPI: Switch to use generic UUID API Date: Thu, 04 May 2017 12:37:27 +0300 Message-ID: <87d1bpotd4.fsf@intel.com> References: <20170504092151.88646-1-andriy.shevchenko@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: Felipe Balbi , Borislav Petkov , Mathias Nyman , Yisen Zhuang , Joerg Roedel , Amir Goldstein , "Rafael J . Wysocki" , Adrian Hunter , Jarkko Sakkinen , Liam Girdwood , Benjamin Tissoires , Heikki Krogerus , Ben Skeggs , Mark Brown , Bjorn Helgaas , Dan Williams , Andy Shevchenko , Mika Westerberg , Zhang Rui To: Andy Shevchenko , linux-acpi@vger.kernel.org, tpmdd-devel@lists.sourceforge.net, intel-gfx@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-input@vger.kernel.org, iommu@lists.linux-foundation.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-pci@vger.kernel.org, linux-usb@vger.kernel.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Return-path: In-Reply-To: <20170504092151.88646-1-andriy.shevchenko@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" List-Id: netdev.vger.kernel.org T24gVGh1LCAwNCBNYXkgMjAxNywgQW5keSBTaGV2Y2hlbmtvIDxhbmRyaXkuc2hldmNoZW5rb0Bs aW51eC5pbnRlbC5jb20+IHdyb3RlOgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF9hY3BpLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9hY3BpLmMKPiBpbmRl eCBlYjYzOGExZTY5ZDIuLjcyYmZlNmNlYWRmOCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF9hY3BpLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9h Y3BpLmMKPiBAQCAtMTUsMTMgKzE1LDkgQEAgc3RhdGljIHN0cnVjdCBpbnRlbF9kc21fcHJpdiB7 Cj4gIAlhY3BpX2hhbmRsZSBkaGFuZGxlOwo+ICB9IGludGVsX2RzbV9wcml2Owo+ICAKPiAtc3Rh dGljIGNvbnN0IHU4IGludGVsX2RzbV9ndWlkW10gPSB7Cj4gLQkweGQzLCAweDczLCAweGQ4LCAw eDdlLAo+IC0JMHhkMCwgMHhjMiwKPiAtCTB4NGYsIDB4NGUsCj4gLQkweGE4LCAweDU0LAo+IC0J MHgwZiwgMHgxMywgMHgxNywgMHhiMCwgMHgxYywgMHgyYwo+IC19Owo+ICtzdGF0aWMgY29uc3Qg dXVpZF9sZSBpbnRlbF9kc21fZ3VpZCA9Cj4gKwlVVUlEX0xFKDB4N2VkODczZDMsIDB4YzJkMCwg MHg0ZTRmLAo+ICsJCTB4YTgsIDB4NTQsIDB4MGYsIDB4MTMsIDB4MTcsIDB4YjAsIDB4MWMsIDB4 MmMpOwo+ICAKPiAgc3RhdGljIGNoYXIgKmludGVsX2RzbV9wb3J0X25hbWUodTggaWQpCj4gIHsK PiBAQCAtODAsNyArNzYsNyBAQCBzdGF0aWMgdm9pZCBpbnRlbF9kc21fcGxhdGZvcm1fbXV4X2lu Zm8odm9pZCkKPiAgCWludCBpOwo+ICAJdW5pb24gYWNwaV9vYmplY3QgKnBrZywgKmNvbm5lY3Rv cl9jb3VudDsKPiAgCj4gLQlwa2cgPSBhY3BpX2V2YWx1YXRlX2RzbV90eXBlZChpbnRlbF9kc21f cHJpdi5kaGFuZGxlLCBpbnRlbF9kc21fZ3VpZCwKPiArCXBrZyA9IGFjcGlfZXZhbHVhdGVfZHNt X3R5cGVkKGludGVsX2RzbV9wcml2LmRoYW5kbGUsICZpbnRlbF9kc21fZ3VpZCwKPiAgCQkJSU5U RUxfRFNNX1JFVklTSU9OX0lELCBJTlRFTF9EU01fRk5fUExBVEZPUk1fTVVYX0lORk8sCj4gIAkJ CU5VTEwsIEFDUElfVFlQRV9QQUNLQUdFKTsKPiAgCWlmICghcGtnKSB7Cj4gQEAgLTExOCw3ICsx MTQsNyBAQCBzdGF0aWMgYm9vbCBpbnRlbF9kc21fcGNpX3Byb2JlKHN0cnVjdCBwY2lfZGV2ICpw ZGV2KQo+ICAJaWYgKCFkaGFuZGxlKQo+ICAJCXJldHVybiBmYWxzZTsKPiAgCj4gLQlpZiAoIWFj cGlfY2hlY2tfZHNtKGRoYW5kbGUsIGludGVsX2RzbV9ndWlkLCBJTlRFTF9EU01fUkVWSVNJT05f SUQsCj4gKwlpZiAoIWFjcGlfY2hlY2tfZHNtKGRoYW5kbGUsICZpbnRlbF9kc21fZ3VpZCwgSU5U RUxfRFNNX1JFVklTSU9OX0lELAo+ICAJCQkgICAgMSA8PCBJTlRFTF9EU01fRk5fUExBVEZPUk1f TVVYX0lORk8pKSB7Cj4gIAkJRFJNX0RFQlVHX0tNUygibm8gX0RTTSBtZXRob2QgZm9yIGludGVs IGRldmljZVxuIik7Cj4gIAkJcmV0dXJuIGZhbHNlOwoKVGhlIGRybS9pOTE1IGh1bmsgYWJvdmUg aXMKClJldmlld2VkLWJ5OiBKYW5pIE5pa3VsYSA8amFuaS5uaWt1bGFAaW50ZWwuY29tPgoKYW5k IGFja2VkIGZvciBtZXJnaW5nIHZpYSB3aGljaGV2ZXIgdHJlZSBpcyBzdWl0YWJsZS4KCgpCUiwK SmFuaS4KCi0tIApKYW5pIE5pa3VsYSwgSW50ZWwgT3BlbiBTb3VyY2UgVGVjaG5vbG9neSBDZW50 ZXIKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwt Z2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8v bGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==