From: dev@michaelmera.com (Michael Mera)
To: kernelnewbies@lists.kernelnewbies.org
Subject: question on patch submission
Date: Fri, 28 Apr 2017 21:49:05 +0900 [thread overview]
Message-ID: <87d1bw7l4u.fsf@michaelmera.com> (raw)
Hello,
As part of the eudyptula challenge I submitted a coding style patch on
staging (that you can find here: https://lkml.org/lkml/2017/4/28/148)
I had read beforehand the submission guidelines, but I still have some
questions which I think are more appropriate posted here than as an
answer to the patch thread:
- the patch is clear with "checkpatch.pl --strict", but there are some
tabs in the middle of the line. In my editor and apparently with
checkpatch.pl those tabs are used for alignment (so spend less than 8
characters) so that the total of the line in less than 80 characters.
In the submitted patch however, due to the +- at the beginning of the
line they appear larger and thus the line in more than 80 character.
My question is: Should I consider the patch clean or interpret the
guideline "tabs are 8 characters" strictly (and not tabs "at the
beginning on the line" are 8 characters)?
- when I make modification to the patch message but not the diff lines,
should I still increment the patch version, or rather maybe resend it
with something like RESEND in the subject?
Sorry if these are written in the doc, I reread it but couldn't find
clear answers (and sorry to Greg Kroah-Hartma who has to read my dumb
submissions both here and in the kernel mailing list).
Thank you,
Michael Mera
next reply other threads:[~2017-04-28 12:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-28 12:49 Michael Mera [this message]
2017-04-28 13:01 ` question on patch submission Greg KH
2017-04-28 14:52 ` Michael Mera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d1bw7l4u.fsf@michaelmera.com \
--to=dev@michaelmera.com \
--cc=kernelnewbies@lists.kernelnewbies.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.