From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH] drm/i915: Fix not finding the VBT when it overlaps with OPREGION_ASLE_EXT Date: Fri, 10 Feb 2017 14:21:07 +0200 Message-ID: <87d1eqs0cs.fsf@intel.com> References: <20161225101928.7618-1-hdegoede@redhat.com> <87vasnby1e.fsf@intel.com> <51453855-216b-1966-226f-b223badf61b7@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <51453855-216b-1966-226f-b223badf61b7@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Hans de Goede , Daniel Vetter , Ville =?utf-8?B?U3lyasOkbMOk?= Cc: intel-gfx , stable@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gRnJpLCAxMCBGZWIgMjAxNywgSGFucyBkZSBHb2VkZSA8aGRlZ29lZGVAcmVkaGF0LmNvbT4g d3JvdGU6Cj4gT24gMDYtMDItMTcgMDg6MDQsIEphbmkgTmlrdWxhIHdyb3RlOgo+PiBGaXJzdCwg SSB3YW50IGEgYmlnIGZhdCB3YXJuaW5nIGNvbW1lbnQgYWJvdXQgd2hhdCdzIGdvaW5nIG9uCj4+ IGhlcmUuIE90aGVyd2lzZSBzb21lb25lJ3MgYm91bmQgdG8gImZpeCIgdGhpcyBsYXRlciBvbi4K Pgo+IERvbmUgZm9yIHYyLCB3aGljaCBJIHdpbGwgc2VuZCBzaG9ydGx5LgoKVGhhbmtzLgoKPj4g U2Vjb25kLCBwZXIgdGhlIHNwZWMsIHRoZSBBU0xFIGV4dCBtYWlsYm94IGlzIDFrIGluIHNpemUs IGFuZCB0aGVyZSdzIGEKPj4gMWsgcmVzZXJ2ZWQgcmVnaW9uIGF0IHRoZSBlbmQuIFdlIHByb2Jh Ymx5IHNob3VsZG4ndCBhbGxvdyBWQlQgdG8gZXh0ZW5kCj4+IG92ZXIgdGhlcmUuIEJ1dCBoZXks IHBlciB0aGUgc3BlYyB3ZSBhbHNvIHNob3VsZG4ndCBhbGxvdyBWQlQgdG8gZXh0ZW5kCj4+IG92 ZXIgbWFpbGJveCAjNSBlaXRoZXIuIFNvIGlmIHlvdSBjYW4ndCBiZSBib3RoZXJlZCB3aXRoIHRo YXQsIG5laXRoZXIKPj4gd2lsbCBJLgo+Cj4gSG1tLCB0aGF0IG1ha2VzIG5vIHNlbnNlLCBPUFJF R0lPTl9TSVpFIGlzIDgxOTIgYnl0ZXMgb3IgMHgyMDAwLAo+IE9QUkVHSU9OX0FTTEVfRVhUX09G RlNFVCBpcyAweDFDMDAgb3IgNzE2OCBieXRlcywgaWYgdGhlcmUgaXMgMWsKPiByZXNlcnZlZCBh ZnRlciB0aGUgQVNMRSBleHQgbWFpbGJveCB0aGVuIHRoZXJlIGlzIGV4YWN0bHkgMCBieXRlcwo+ IGF2YWlsYWJsZSBmb3IgdGhlIEFTTEUgZXh0IG1haWxib3ggb3IgT1BSRUdJT05fU0laRSBzaG91 bGQgYmUgOTIxNgo+IG5vdCA4MTkyICh3aGljaCBJIGRvbid0IHRoaW5rIHNvKS4gTWF5YmUgdGhl IGxhc3QgMWsgaXMgZWl0aGVyCj4gdGhlIEFTTEUgZXh0IG1haWxib3ggT1IgcmVzZXJ2ZWQgPwoK WW91J3JlIHF1aXRlIHJpZ2h0LCB0aGF0IG1ha2VzIG5vIHNlbnNlLiA6KSBMb29rcyBsaWtlIHdl IGFjY291bnQgZm9yCnRoZSByZXNlcnZlZCBwYXJ0IGF0IHRoZSBlbmQgb2Ygc3RydWN0IG9wcmVn aW9uX2FzbGVfZXh0LCBidXQgdGhlIHNwZWMKaXNuJ3QgcXVpdGUgY2xlYXIgd2hldGhlciB0aGUg cmVzZXJ2ZWQgcGFydCBpcyBhY3R1YWxseSBwYXJ0IG9mIHRoZQptYWlsYm94IG9yIG5vdC4gSSdt IG5vdCBxdWl0ZSBzdXJlIGhvdyBJIG1hbmFnZWQgdG8gY29uZnVzZSBteXNlbGYgdG8KdHVybiB0 aGF0IGludG8gMWsuIFNvcnJ5LgoKQlIsCkphbmkuCgotLSAKSmFuaSBOaWt1bGEsIEludGVsIE9w ZW4gU291cmNlIFRlY2hub2xvZ3kgQ2VudGVyCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3Rz LmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2ludGVsLWdmeAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com ([192.55.52.93]:53087 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751305AbdBJMgu (ORCPT ); Fri, 10 Feb 2017 07:36:50 -0500 From: Jani Nikula To: Hans de Goede , Daniel Vetter , Ville =?utf-8?B?U3lyasOkbMOk?= Cc: intel-gfx , dri-devel@lists.freedesktop.org, stable@vger.kernel.org Subject: Re: [PATCH] drm/i915: Fix not finding the VBT when it overlaps with OPREGION_ASLE_EXT In-Reply-To: <51453855-216b-1966-226f-b223badf61b7@redhat.com> References: <20161225101928.7618-1-hdegoede@redhat.com> <87vasnby1e.fsf@intel.com> <51453855-216b-1966-226f-b223badf61b7@redhat.com> Date: Fri, 10 Feb 2017 14:21:07 +0200 Message-ID: <87d1eqs0cs.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: stable-owner@vger.kernel.org List-ID: On Fri, 10 Feb 2017, Hans de Goede wrote: > On 06-02-17 08:04, Jani Nikula wrote: >> First, I want a big fat warning comment about what's going on >> here. Otherwise someone's bound to "fix" this later on. > > Done for v2, which I will send shortly. Thanks. >> Second, per the spec, the ASLE ext mailbox is 1k in size, and there's a >> 1k reserved region at the end. We probably shouldn't allow VBT to extend >> over there. But hey, per the spec we also shouldn't allow VBT to extend >> over mailbox #5 either. So if you can't be bothered with that, neither >> will I. > > Hmm, that makes no sense, OPREGION_SIZE is 8192 bytes or 0x2000, > OPREGION_ASLE_EXT_OFFSET is 0x1C00 or 7168 bytes, if there is 1k > reserved after the ASLE ext mailbox then there is exactly 0 bytes > available for the ASLE ext mailbox or OPREGION_SIZE should be 9216 > not 8192 (which I don't think so). Maybe the last 1k is either > the ASLE ext mailbox OR reserved ? You're quite right, that makes no sense. :) Looks like we account for the reserved part at the end of struct opregion_asle_ext, but the spec isn't quite clear whether the reserved part is actually part of the mailbox or not. I'm not quite sure how I managed to confuse myself to turn that into 1k. Sorry. BR, Jani. -- Jani Nikula, Intel Open Source Technology Center