From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH] drm/gma500: dont expose bytes from kernel stack Date: Mon, 22 Aug 2016 11:32:46 +0300 Message-ID: <87d1l1urtd.fsf@intel.com> References: <1471804778-3656-1-git-send-email-xypron.glpk@gmx.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id 853356E08D for ; Mon, 22 Aug 2016 08:32:48 +0000 (UTC) In-Reply-To: <1471804778-3656-1-git-send-email-xypron.glpk@gmx.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Patrik Jakobsson Cc: Heinrich Schuchardt , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gU3VuLCAyMSBBdWcgMjAxNiwgSGVpbnJpY2ggU2NodWNoYXJkdCA8eHlwcm9uLmdscGtAZ214 LmRlPiB3cm90ZToKPiBDb21wb25lbnRzIG0xLCBtMiwgcDIsIGRvdCwgdmNvIG9mIHZhcmlhYmxl IGNsb2NrIHNob3VsZCBiZQo+IGluaXRpYWxpemVkIHRvIGF2b2lkIGJ5dGVzIGZyb20gdGhlIGtl cm5lbCBzdGFjayB0byBiZQo+IGV4cG9zZWQuCj4KPiBTaWduZWQtb2ZmLWJ5OiBIZWlucmljaCBT Y2h1Y2hhcmR0IDx4eXByb24uZ2xwa0BnbXguZGU+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9n bWE1MDAvb2FrdHJhaWxfY3J0Yy5jIHwgMSArCj4gIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlv bigrKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9nbWE1MDAvb2FrdHJhaWxfY3J0 Yy5jIGIvZHJpdmVycy9ncHUvZHJtL2dtYTUwMC9vYWt0cmFpbF9jcnRjLmMKPiBpbmRleCBkYTlm ZDM0Li4yOGJkOGYzIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9nbWE1MDAvb2FrdHJh aWxfY3J0Yy5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2dtYTUwMC9vYWt0cmFpbF9jcnRjLmMK PiBAQCAtMTM4LDYgKzEzOCw3IEBAIHN0YXRpYyBib29sIG1yc3Rfc2R2b19maW5kX2Jlc3RfcGxs KGNvbnN0IHN0cnVjdCBnbWFfbGltaXRfdCAqbGltaXQsCj4gIAl1MzIgdGFyZ2V0X3ZjbywgYWN0 dWFsX2ZyZXE7Cj4gIAlzMzIgZnJlcV9lcnJvciwgbWluX2Vycm9yID0gMTAwMDAwOwo+ICAKPiAr CW1lbXNldChjbG9jaywgMCwgc2l6ZW9mKHN0cnVjdCBnbWFfY2xvY2tfdCkpOwoKRGlkIHlvdSBi dWlsZCB0aGlzPyBEaWQgeW91IHJ1biB0aGlzPwoKQlIsCkphbmkuCgoKPiAgCW1lbXNldChiZXN0 X2Nsb2NrLCAwLCBzaXplb2YoKmJlc3RfY2xvY2spKTsKPiAgCj4gIAlmb3IgKGNsb2NrLm0gPSBs aW1pdC0+bS5taW47IGNsb2NrLm0gPD0gbGltaXQtPm0ubWF4OyBjbG9jay5tKyspIHsKCi0tIApK YW5pIE5pa3VsYSwgSW50ZWwgT3BlbiBTb3VyY2UgVGVjaG5vbG9neSBDZW50ZXIKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcg bGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRl c2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754172AbcHVIct (ORCPT ); Mon, 22 Aug 2016 04:32:49 -0400 Received: from mga11.intel.com ([192.55.52.93]:56381 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750961AbcHVIcs (ORCPT ); Mon, 22 Aug 2016 04:32:48 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,559,1464678000"; d="scan'208";a="1045238243" From: Jani Nikula To: Heinrich Schuchardt , Patrik Jakobsson Cc: Heinrich Schuchardt , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH] drm/gma500: dont expose bytes from kernel stack In-Reply-To: <1471804778-3656-1-git-send-email-xypron.glpk@gmx.de> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <1471804778-3656-1-git-send-email-xypron.glpk@gmx.de> User-Agent: Notmuch/0.22.1+63~g648dcc7 (https://notmuchmail.org) Emacs/24.4.1 (x86_64-pc-linux-gnu) Date: Mon, 22 Aug 2016 11:32:46 +0300 Message-ID: <87d1l1urtd.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 21 Aug 2016, Heinrich Schuchardt wrote: > Components m1, m2, p2, dot, vco of variable clock should be > initialized to avoid bytes from the kernel stack to be > exposed. > > Signed-off-by: Heinrich Schuchardt > --- > drivers/gpu/drm/gma500/oaktrail_crtc.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/gma500/oaktrail_crtc.c b/drivers/gpu/drm/gma500/oaktrail_crtc.c > index da9fd34..28bd8f3 100644 > --- a/drivers/gpu/drm/gma500/oaktrail_crtc.c > +++ b/drivers/gpu/drm/gma500/oaktrail_crtc.c > @@ -138,6 +138,7 @@ static bool mrst_sdvo_find_best_pll(const struct gma_limit_t *limit, > u32 target_vco, actual_freq; > s32 freq_error, min_error = 100000; > > + memset(clock, 0, sizeof(struct gma_clock_t)); Did you build this? Did you run this? BR, Jani. > memset(best_clock, 0, sizeof(*best_clock)); > > for (clock.m = limit->m.min; clock.m <= limit->m.max; clock.m++) { -- Jani Nikula, Intel Open Source Technology Center