From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1947262AbcHRNps (ORCPT ); Thu, 18 Aug 2016 09:45:48 -0400 Received: from mga01.intel.com ([192.55.52.88]:62228 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1947182AbcHRNpb (ORCPT ); Thu, 18 Aug 2016 09:45:31 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,539,1464678000"; d="asc'?scan'208";a="1016661852" From: Felipe Balbi To: Baolin Wang Cc: Greg KH , mathias.nyman@intel.com, USB , LKML , Mark Brown Subject: Re: [PATCH 2/4] usb: host: xhci: Introduce one new 'usb3_slow_suspend' member for xhci private data In-Reply-To: References: <87inuy5yvr.fsf@linux.intel.com> <87inuy463c.fsf@linux.intel.com> User-Agent: Notmuch/0.22.1+63~g994277e (https://notmuchmail.org) Emacs/25.1.1 (x86_64-pc-linux-gnu) Date: Thu, 18 Aug 2016 16:42:08 +0300 Message-ID: <87d1l642j3.fsf@linux.intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi Baolin, Baolin Wang writes: >>>>> diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-pla= t.c >>>>> index e2e2487..162f17c 100644 >>>>> --- a/drivers/usb/host/xhci-plat.c >>>>> +++ b/drivers/usb/host/xhci-plat.c >>>>> @@ -250,6 +250,9 @@ static int xhci_plat_probe(struct platform_device= *pdev) >>>>> (pdata && pdata->usb3_lpm_capable)) >>>>> xhci->quirks |=3D XHCI_LPM_SUPPORT; >>>>> >>>>> + if (pdata && pdata->usb3_slow_suspend) >>>>> + xhci->quirks |=3D XHCI_SLOW_SUSPEND; >>>> >>>> I remember having a discussion about this with Paul Z and it turned out >>>> that we really didn't need SLOW_SUSPEND. Can you describe further in >>>> what situation you need this quirk? >>> >>> On my dwc3 platform, xhci suspend will be failed if we have not >>> enabled XHCI_SLOW_SUSPEND quirk. >> >> fail how? What error do you see? Do you have some traces of what's >> happening? Did you try figuring out if this is, perhaps, caused by some >> call ordering which is wrong? Perhaps disabling PHYs too early or >> something like that? > > It shows the warning "WARN: xHC CMD_RUN timeout" when running > xhci_suspend(). If I enbale XHCI_SLOW_SUSPEND quirk, then it can work > well. I did not try to figure out other things, due to I think the > dwc3 need XHCI_SLOW_SUSPEND quirk. But I can re-try to figure out if > there are other issues if you still believe that dwc3 does not need > XHCI_SLOW_SUSPEND quirk. Thanks. When I discussed this with Paul Z, he told me there was no known DWC3 SoC that really needed SLOW_SUSPEND, so it's likely to be a bug in either xhci or dwc3. Please try to track this down. I would start looking at ordering with PHY poweroff or something like that. =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBCAAGBQJXtbswAAoJEIaOsuA1yqREYZIP/0n5w8ZYXhvZFrDYKv1tTrVu 70rEEkYo9D+7MIY5EwzLBzUeCjAaggWWxLxYQGiu81SR4K9PG+sTo0bGnCAw7gFE bgWSE3Hsa7iiVC9kEAbhM4xdDHaQo7JlOkxY4GiJTHQl7gXciOHJnrsoBOlTOLLD +Z5/nFvSIVcWP6nhTQf1+rWz72iZO3B7uEr0GRYXnclh+De9YySzAG/U3gf5NBFe gZNpnbVmfJsUVrOXVfbAZxbwbd0RL4NCITPyB5tAAEUeUI4/nbjC6fTBZqx7T1rQ uOt/XL75DvA5Tzdsy/avkD8ew68OJZFHmAsAI20LMVpNoLBgNglZQoiLJOlKhNwC C9MMcS4khgAZ9h0//biJZelhdazvMM7Tx18WlUgNp36940PVtaGR8LFnptQnZTS/ FnI64D6/ZEUofLRxDfdXKLftmvsn015zLQrYLUqWD2siXk1W/Sbdj8DIx4znwqfd yYD1kbBt93R2JNWZZeuWQVtHtg25fIqI6NsRd1Wd+LnsFYKybZOxIPijnrgw7PBa HMlbh1FPFxozt7MqjyUz5bjSht+XB0L2mOiyAu9WFCTXNaD/UyO7EZ/ZVGN4T9yS EuyAy9BwDkkD08M5i/Vy7qVdyazyvciLNFXIB/uSTaFrEbUDKxXhYizVbUPUqdEM devP54arh+9F273i/3ng =fdDx -----END PGP SIGNATURE----- --=-=-=--