Re: [Qemu-devel] [PATCH v8 7/7] trace: Add QAPI/QMP interfaces to query and control per-vCPU tracing state

["Lluís Vilanova" <vilanova@ac.upc.edu>]

Eric Blake writes:

> On 07/04/2016 03:41 AM, Lluís Vilanova wrote:
>> Signed-off-by: Lluís Vilanova <vilanova@ac.upc.edu>
>> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
>> ---
>> hmp-commands-info.hx |    6 +-
>> hmp-commands.hx      |    7 +-
>> monitor.c            |   17 +++++-
>> qapi/trace.json      |   32 +++++++++--
>> qmp-commands.hx      |   35 +++++++++++-
>> trace/qmp.c          |  148 ++++++++++++++++++++++++++++++++++++++++----------
>> 6 files changed, 202 insertions(+), 43 deletions(-)
>> 

>> +++ b/qapi/trace.json
>> @@ -1,6 +1,6 @@
>> # -*- mode: python -*-
>> #
>> -# Copyright (C) 2011-2014 Lluís Vilanova <vilanova@ac.upc.edu>
>> +# Copyright (C) 2011-2016 Lluís Vilanova <vilanova@ac.upc.edu>
>> #
>> # This work is licensed under the terms of the GNU GPL, version 2 or later.
>> # See the COPYING file in the top-level directory.
>> @@ -29,11 +29,14 @@
>> #
>> # @name: Event name.
>> # @state: Tracing state.
>> +# @vcpu: Whether this is a per-vCPU event (since 2.7).
>> +#
>> +# An event is per-vCPU if it has the "vcpu" property in the "trace-events" file.

> Is this comment still true, now that we've split trace-events into
> multiple files?

It is true for the few events we have now with this property. I can change it
to:

  An event is per-vCPU if it has the "vcpu" property in the "trace-events"
  files.

Note the plural in "files".


Cheers,
  Lluis