From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46372) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b8imq-00026a-BK for qemu-devel@nongnu.org; Fri, 03 Jun 2016 02:40:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b8imm-0001eQ-6U for qemu-devel@nongnu.org; Fri, 03 Jun 2016 02:40:51 -0400 From: Markus Armbruster Date: Fri, 03 Jun 2016 08:40:43 +0200 Message-ID: <87d1ny93mc.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: [Qemu-devel] Why is "spapr-pci-host-bridge" no-user? List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexey Kardashevskiy Cc: qemu-devel@nongnu.org, qemu-ppc@nongnu.org, Alexander Graf Commit 09aa9a5 "spapr-pci: enable adding PHB via -device" set cannot_instantiate_with_device_add_yet without also adding a comment explaining why. It is currently the only one lacking such a comment. Let's fix that. Unfortunately, the commit message doesn't tell me (or I'm too dense to understand it): spapr-pci: enable adding PHB via -device Recent changes introduced cannot_instantiate_with_device_add_yet and removed capability of adding yet another PCI host bridge via command line for SPAPR platform (POWERPC64 server). This brings the capability back and puts SPAPR PHB into "bridge" category. This is not much use for emulated PHB but it is absolutely required for VFIO as we put an IOMMU group onto a separate PHB on SPAPR. Signed-off-by: Alexey Kardashevskiy Signed-off-by: Alexander Graf Alexey, can you explain why the device cannot be used with -device / device_add?