From: Stewart Smith <stewart@linux.vnet.ibm.com>
To: Adriana Kobylak <anoo@us.ibm.com>,
OpenBMC Patches <openbmc-patches@stwcx.xyz>
Cc: openbmc@lists.ozlabs.org
Subject: Re: [PATCH ipmi-fru-parser] Increase size of buffer length variable
Date: Mon, 16 May 2016 10:53:15 +1000 [thread overview]
Message-ID: <87d1om3jt0.fsf@linux.vnet.ibm.com> (raw)
In-Reply-To: <201605131351.u4DDpf9u004682@d01av01.pok.ibm.com>
Adriana Kobylak <anoo@us.ibm.com> writes:
> The size of size_t is different in 32 and 64-bit architectures. There has
> been issues in the past in op-build where we had to change size_t to
> uint32_t to support compiling in 64-bit. So thought I'd make the change
> consistent and change the length to uint32_t.
If size_t is part of a binary format, then yes, this matters.
Otherwise, it really shouldn't - addressing things >2GB on 32bit systems
is going to be problematic anyway, and all that really should matter
there is off_t vs off64_t if you're doing seeking in large files.
So what exactly is the problem with size_t here?
--
Stewart Smith
OPAL Architect, IBM.
prev parent reply other threads:[~2016-05-16 0:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-12 19:10 [PATCH ipmi-fru-parser] Increase size of buffer length variable OpenBMC Patches
2016-05-12 19:10 ` OpenBMC Patches
2016-05-13 13:51 ` Adriana Kobylak
2016-05-16 0:53 ` Stewart Smith [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d1om3jt0.fsf@linux.vnet.ibm.com \
--to=stewart@linux.vnet.ibm.com \
--cc=anoo@us.ibm.com \
--cc=openbmc-patches@stwcx.xyz \
--cc=openbmc@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.