From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH 3/5] drm/edid: move displayid tiled block parsing into separate function. Date: Wed, 04 May 2016 11:04:19 +0300 Message-ID: <87d1p2fdvg.fsf@intel.com> References: <1462307812-3341-1-git-send-email-airlied@gmail.com> <1462307812-3341-4-git-send-email-airlied@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id 75FE689D81 for ; Wed, 4 May 2016 08:04:21 +0000 (UTC) In-Reply-To: <1462307812-3341-4-git-send-email-airlied@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Dave Airlie , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCAwMyBNYXkgMjAxNiwgRGF2ZSBBaXJsaWUgPGFpcmxpZWRAZ21haWwuY29tPiB3cm90 ZToKPiBGcm9tOiBEYXZlIEFpcmxpZSA8YWlybGllZEByZWRoYXQuY29tPgo+Cj4gVGhpcyBqdXN0 IG1ha2VzIHRoZSBjb2RlIGVhc2llciB0byBmb2xsb3cuCgpTd2FwcGluZyB0aGUgb3JkZXIgb2Yg cGF0Y2hlcyAyIGFuZCAzIHdvdWxkIG1ha2UgdGhlIHBhdGNoIHNlcmllcyBlYXNpZXIKdG8gZm9s bG93LiA7KQoKQlIsCkphbmkuCgo+Cj4gU2lnbmVkLW9mZi1ieTogRGF2ZSBBaXJsaWUgPGFpcmxp ZWRAcmVkaGF0LmNvbT4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2RybV9lZGlkLmMgfCAxMTAg KysrKysrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLS0tLS0tCj4gIDEgZmlsZSBj aGFuZ2VkLCA1OSBpbnNlcnRpb25zKCspLCA1MSBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQg YS9kcml2ZXJzL2dwdS9kcm0vZHJtX2VkaWQuYyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fZWRpZC5j Cj4gaW5kZXggMWEzNjRiMy4uZTRjNjgxZiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0v ZHJtX2VkaWQuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fZWRpZC5jCj4gQEAgLTQxNTIs NiArNDE1Miw2MCBAQCBkcm1faGRtaV92ZW5kb3JfaW5mb2ZyYW1lX2Zyb21fZGlzcGxheV9tb2Rl KHN0cnVjdCBoZG1pX3ZlbmRvcl9pbmZvZnJhbWUgKmZyYW1lLAo+ICB9Cj4gIEVYUE9SVF9TWU1C T0woZHJtX2hkbWlfdmVuZG9yX2luZm9mcmFtZV9mcm9tX2Rpc3BsYXlfbW9kZSk7Cj4gIAo+ICtz dGF0aWMgaW50IGRybV9wYXJzZV90aWxlZF9ibG9jayhzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAqY29u bmVjdG9yLAo+ICsJCQkJIHN0cnVjdCBkaXNwbGF5aWRfYmxvY2sgKmJsb2NrKQo+ICt7Cj4gKwlz dHJ1Y3QgZGlzcGxheWlkX3RpbGVkX2Jsb2NrICp0aWxlID0gKHN0cnVjdCBkaXNwbGF5aWRfdGls ZWRfYmxvY2sgKilibG9jazsKPiArCXUxNiB3LCBoOwo+ICsJdTggdGlsZV92X2xvYywgdGlsZV9o X2xvYzsKPiArCXU4IG51bV92X3RpbGUsIG51bV9oX3RpbGU7Cj4gKwlzdHJ1Y3QgZHJtX3RpbGVf Z3JvdXAgKnRnOwo+ICsKPiArCXcgPSB0aWxlLT50aWxlX3NpemVbMF0gfCB0aWxlLT50aWxlX3Np emVbMV0gPDwgODsKPiArCWggPSB0aWxlLT50aWxlX3NpemVbMl0gfCB0aWxlLT50aWxlX3NpemVb M10gPDwgODsKPiArCj4gKwludW1fdl90aWxlID0gKHRpbGUtPnRvcG9bMF0gJiAweGYpIHwgKHRp bGUtPnRvcG9bMl0gJiAweDMwKTsKPiArCW51bV9oX3RpbGUgPSAodGlsZS0+dG9wb1swXSA+PiA0 KSB8ICgodGlsZS0+dG9wb1syXSA+PiAyKSAmIDB4MzApOwo+ICsJdGlsZV92X2xvYyA9ICh0aWxl LT50b3BvWzFdICYgMHhmKSB8ICgodGlsZS0+dG9wb1syXSAmIDB4MykgPDwgNCk7Cj4gKwl0aWxl X2hfbG9jID0gKHRpbGUtPnRvcG9bMV0gPj4gNCkgfCAoKCh0aWxlLT50b3BvWzJdID4+IDIpICYg MHgzKSA8PCA0KTsKPiArCj4gKwljb25uZWN0b3ItPmhhc190aWxlID0gdHJ1ZTsKPiArCWlmICh0 aWxlLT50aWxlX2NhcCAmIDB4ODApCj4gKwkJY29ubmVjdG9yLT50aWxlX2lzX3NpbmdsZV9tb25p dG9yID0gdHJ1ZTsKPiArCj4gKwljb25uZWN0b3ItPm51bV9oX3RpbGUgPSBudW1faF90aWxlICsg MTsKPiArCWNvbm5lY3Rvci0+bnVtX3ZfdGlsZSA9IG51bV92X3RpbGUgKyAxOwo+ICsJY29ubmVj dG9yLT50aWxlX2hfbG9jID0gdGlsZV9oX2xvYzsKPiArCWNvbm5lY3Rvci0+dGlsZV92X2xvYyA9 IHRpbGVfdl9sb2M7Cj4gKwljb25uZWN0b3ItPnRpbGVfaF9zaXplID0gdyArIDE7Cj4gKwljb25u ZWN0b3ItPnRpbGVfdl9zaXplID0gaCArIDE7Cj4gKwo+ICsJRFJNX0RFQlVHX0tNUygidGlsZSBj YXAgMHgleFxuIiwgdGlsZS0+dGlsZV9jYXApOwo+ICsJRFJNX0RFQlVHX0tNUygidGlsZV9zaXpl ICVkIHggJWRcbiIsIHcgKyAxLCBoICsgMSk7Cj4gKwlEUk1fREVCVUdfS01TKCJ0b3BvIG51bSB0 aWxlcyAlZHglZCwgbG9jYXRpb24gJWR4JWRcbiIsCj4gKwkJICAgICAgbnVtX2hfdGlsZSArIDEs IG51bV92X3RpbGUgKyAxLCB0aWxlX2hfbG9jLCB0aWxlX3ZfbG9jKTsKPiArCURSTV9ERUJVR19L TVMoInZlbmQgJWMlYyVjXG4iLCB0aWxlLT50b3BvbG9neV9pZFswXSwgdGlsZS0+dG9wb2xvZ3lf aWRbMV0sIHRpbGUtPnRvcG9sb2d5X2lkWzJdKTsKPiArCj4gKwl0ZyA9IGRybV9tb2RlX2dldF90 aWxlX2dyb3VwKGNvbm5lY3Rvci0+ZGV2LCB0aWxlLT50b3BvbG9neV9pZCk7Cj4gKwlpZiAoIXRn KSB7Cj4gKwkJdGcgPSBkcm1fbW9kZV9jcmVhdGVfdGlsZV9ncm91cChjb25uZWN0b3ItPmRldiwg dGlsZS0+dG9wb2xvZ3lfaWQpOwo+ICsJfQo+ICsJaWYgKCF0ZykKPiArCQlyZXR1cm4gLUVOT01F TTsKPiArCj4gKwlpZiAoY29ubmVjdG9yLT50aWxlX2dyb3VwICE9IHRnKSB7Cj4gKwkJLyogaWYg d2UgaGF2ZW4ndCBnb3QgYSBwb2ludGVyLAo+ICsJCSAgIHRha2UgdGhlIHJlZmVyZW5jZSwgZHJv cCByZWYgdG8gb2xkIHRpbGUgZ3JvdXAgKi8KPiArCQlpZiAoY29ubmVjdG9yLT50aWxlX2dyb3Vw KSB7Cj4gKwkJCWRybV9tb2RlX3B1dF90aWxlX2dyb3VwKGNvbm5lY3Rvci0+ZGV2LCBjb25uZWN0 b3ItPnRpbGVfZ3JvdXApOwo+ICsJCX0KPiArCQljb25uZWN0b3ItPnRpbGVfZ3JvdXAgPSB0ZzsK PiArCX0gZWxzZQo+ICsJCS8qIGlmIHNhbWUgdGlsZSBncm91cCwgdGhlbiByZWxlYXNlIHRoZSBy ZWYgd2UganVzdCB0b29rLiAqLwo+ICsJCWRybV9tb2RlX3B1dF90aWxlX2dyb3VwKGNvbm5lY3Rv ci0+ZGV2LCB0Zyk7Cj4gKwlyZXR1cm4gMDsKPiArfQo+ICsKPiAgc3RhdGljIGludCBkcm1fcGFy c2VfZGlzcGxheV9pZChzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAqY29ubmVjdG9yLAo+ICAJCQkJdTgg KmRpc3BsYXlpZCwgaW50IGxlbmd0aCwKPiAgCQkJCWJvb2wgaXNfZWRpZF9leHRlbnNpb24pCj4g QEAgLTQxNjIsNiArNDIxNiw3IEBAIHN0YXRpYyBpbnQgZHJtX3BhcnNlX2Rpc3BsYXlfaWQoc3Ry dWN0IGRybV9jb25uZWN0b3IgKmNvbm5lY3RvciwKPiAgCXN0cnVjdCBkaXNwbGF5aWRfYmxvY2sg KmJsb2NrOwo+ICAJdTggY3N1bSA9IDA7Cj4gIAlpbnQgaTsKPiArCWludCByZXQ7Cj4gIAo+ICAJ aWYgKGlzX2VkaWRfZXh0ZW5zaW9uKQo+ICAJCWlkeCA9IDE7Cj4gQEAgLTQxOTIsNTcgKzQyNDcs MTAgQEAgc3RhdGljIGludCBkcm1fcGFyc2VfZGlzcGxheV9pZChzdHJ1Y3QgZHJtX2Nvbm5lY3Rv ciAqY29ubmVjdG9yLAo+ICAJCQkgICAgICBibG9jay0+dGFnLCBibG9jay0+cmV2LCBibG9jay0+ bnVtX2J5dGVzKTsKPiAgCj4gIAkJc3dpdGNoIChibG9jay0+dGFnKSB7Cj4gLQkJY2FzZSBEQVRB X0JMT0NLX1RJTEVEX0RJU1BMQVk6IHsKPiAtCQkJc3RydWN0IGRpc3BsYXlpZF90aWxlZF9ibG9j ayAqdGlsZSA9IChzdHJ1Y3QgZGlzcGxheWlkX3RpbGVkX2Jsb2NrICopYmxvY2s7Cj4gLQo+IC0J CQl1MTYgdywgaDsKPiAtCQkJdTggdGlsZV92X2xvYywgdGlsZV9oX2xvYzsKPiAtCQkJdTggbnVt X3ZfdGlsZSwgbnVtX2hfdGlsZTsKPiAtCQkJc3RydWN0IGRybV90aWxlX2dyb3VwICp0ZzsKPiAt Cj4gLQkJCXcgPSB0aWxlLT50aWxlX3NpemVbMF0gfCB0aWxlLT50aWxlX3NpemVbMV0gPDwgODsK PiAtCQkJaCA9IHRpbGUtPnRpbGVfc2l6ZVsyXSB8IHRpbGUtPnRpbGVfc2l6ZVszXSA8PCA4Owo+ IC0KPiAtCQkJbnVtX3ZfdGlsZSA9ICh0aWxlLT50b3BvWzBdICYgMHhmKSB8ICh0aWxlLT50b3Bv WzJdICYgMHgzMCk7Cj4gLQkJCW51bV9oX3RpbGUgPSAodGlsZS0+dG9wb1swXSA+PiA0KSB8ICgo dGlsZS0+dG9wb1syXSA+PiAyKSAmIDB4MzApOwo+IC0JCQl0aWxlX3ZfbG9jID0gKHRpbGUtPnRv cG9bMV0gJiAweGYpIHwgKCh0aWxlLT50b3BvWzJdICYgMHgzKSA8PCA0KTsKPiAtCQkJdGlsZV9o X2xvYyA9ICh0aWxlLT50b3BvWzFdID4+IDQpIHwgKCgodGlsZS0+dG9wb1syXSA+PiAyKSAmIDB4 MykgPDwgNCk7Cj4gLQo+IC0JCQljb25uZWN0b3ItPmhhc190aWxlID0gdHJ1ZTsKPiAtCQkJaWYg KHRpbGUtPnRpbGVfY2FwICYgMHg4MCkKPiAtCQkJCWNvbm5lY3Rvci0+dGlsZV9pc19zaW5nbGVf bW9uaXRvciA9IHRydWU7Cj4gLQo+IC0JCQljb25uZWN0b3ItPm51bV9oX3RpbGUgPSBudW1faF90 aWxlICsgMTsKPiAtCQkJY29ubmVjdG9yLT5udW1fdl90aWxlID0gbnVtX3ZfdGlsZSArIDE7Cj4g LQkJCWNvbm5lY3Rvci0+dGlsZV9oX2xvYyA9IHRpbGVfaF9sb2M7Cj4gLQkJCWNvbm5lY3Rvci0+ dGlsZV92X2xvYyA9IHRpbGVfdl9sb2M7Cj4gLQkJCWNvbm5lY3Rvci0+dGlsZV9oX3NpemUgPSB3 ICsgMTsKPiAtCQkJY29ubmVjdG9yLT50aWxlX3Zfc2l6ZSA9IGggKyAxOwo+IC0KPiAtCQkJRFJN X0RFQlVHX0tNUygidGlsZSBjYXAgMHgleFxuIiwgdGlsZS0+dGlsZV9jYXApOwo+IC0JCQlEUk1f REVCVUdfS01TKCJ0aWxlX3NpemUgJWQgeCAlZFxuIiwgdyArIDEsIGggKyAxKTsKPiAtCQkJRFJN X0RFQlVHX0tNUygidG9wbyBudW0gdGlsZXMgJWR4JWQsIGxvY2F0aW9uICVkeCVkXG4iLAo+IC0J CQkgICAgICAgbnVtX2hfdGlsZSArIDEsIG51bV92X3RpbGUgKyAxLCB0aWxlX2hfbG9jLCB0aWxl X3ZfbG9jKTsKPiAtCQkJRFJNX0RFQlVHX0tNUygidmVuZCAlYyVjJWNcbiIsIHRpbGUtPnRvcG9s b2d5X2lkWzBdLCB0aWxlLT50b3BvbG9neV9pZFsxXSwgdGlsZS0+dG9wb2xvZ3lfaWRbMl0pOwo+ IC0KPiAtCQkJdGcgPSBkcm1fbW9kZV9nZXRfdGlsZV9ncm91cChjb25uZWN0b3ItPmRldiwgdGls ZS0+dG9wb2xvZ3lfaWQpOwo+IC0JCQlpZiAoIXRnKSB7Cj4gLQkJCQl0ZyA9IGRybV9tb2RlX2Ny ZWF0ZV90aWxlX2dyb3VwKGNvbm5lY3Rvci0+ZGV2LCB0aWxlLT50b3BvbG9neV9pZCk7Cj4gLQkJ CX0KPiAtCQkJaWYgKCF0ZykKPiAtCQkJCXJldHVybiAtRU5PTUVNOwo+IC0KPiAtCQkJaWYgKGNv bm5lY3Rvci0+dGlsZV9ncm91cCAhPSB0Zykgewo+IC0JCQkJLyogaWYgd2UgaGF2ZW4ndCBnb3Qg YSBwb2ludGVyLAo+IC0JCQkJICAgdGFrZSB0aGUgcmVmZXJlbmNlLCBkcm9wIHJlZiB0byBvbGQg dGlsZSBncm91cCAqLwo+IC0JCQkJaWYgKGNvbm5lY3Rvci0+dGlsZV9ncm91cCkgewo+IC0JCQkJ CWRybV9tb2RlX3B1dF90aWxlX2dyb3VwKGNvbm5lY3Rvci0+ZGV2LCBjb25uZWN0b3ItPnRpbGVf Z3JvdXApOwo+IC0JCQkJfQo+IC0JCQkJY29ubmVjdG9yLT50aWxlX2dyb3VwID0gdGc7Cj4gLQkJ CX0gZWxzZQo+IC0JCQkJLyogaWYgc2FtZSB0aWxlIGdyb3VwLCB0aGVuIHJlbGVhc2UgdGhlIHJl ZiB3ZSBqdXN0IHRvb2suICovCj4gLQkJCQlkcm1fbW9kZV9wdXRfdGlsZV9ncm91cChjb25uZWN0 b3ItPmRldiwgdGcpOwo+IC0JCX0KPiArCQljYXNlIERBVEFfQkxPQ0tfVElMRURfRElTUExBWToK PiArCQkJcmV0ID0gZHJtX3BhcnNlX3RpbGVkX2Jsb2NrKGNvbm5lY3RvciwgYmxvY2spOwo+ICsJ CQlpZiAocmV0KQo+ICsJCQkJcmV0dXJuIHJldDsKPiAgCQkJYnJlYWs7Cj4gIAkJZGVmYXVsdDoK PiAgCQkJRFJNX0RFQlVHX0tNUygiZm91bmQgRGlzcGxheUlEIHRhZyAweCV4LCB1bmhhbmRsZWRc biIsIGJsb2NrLT50YWcpOwoKLS0gCkphbmkgTmlrdWxhLCBJbnRlbCBPcGVuIFNvdXJjZSBUZWNo bm9sb2d5IENlbnRlcgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5v cmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2 ZWwK