From: Markus Armbruster <armbru@redhat.com>
To: Igor Mammedov <imammedo@redhat.com>
Cc: lvivier@redhat.com, thuth@redhat.com,
Peter Krempa <pkrempa@redhat.com>,
ehabkost@redhat.com, aik@ozlabs.ru, qemu-devel@nongnu.org,
agraf@suse.de, abologna@redhat.com, bharata@linux.vnet.ibm.com,
pbonzini@redhat.com, afaerber@suse.de,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [Qemu-devel] [RFC] QMP: add query-hotpluggable-cpus
Date: Wed, 24 Feb 2016 09:53:33 +0100 [thread overview]
Message-ID: <87d1rm1oc2.fsf@blackfin.pond.sub.org> (raw)
In-Reply-To: <20160223104645.6b64f60c@nial.brq.redhat.com> (Igor Mammedov's message of "Tue, 23 Feb 2016 10:46:45 +0100")
Igor Mammedov <imammedo@redhat.com> writes:
> On Mon, 22 Feb 2016 13:54:32 +1100
> David Gibson <david@gibson.dropbear.id.au> wrote:
[...]
>> This is why Eduardo suggested - and I agreed - that it's probably
>> better to implement the "1st layer" as an internal structure/interface
>> only, and implement the 2nd layer on top of that. When/if we need to
>> we can revisit a user-accessible interface to the 1st layer.
> We are going around QOM based CPU introspecting interface for
> years now and that's exactly what 2nd layer is, just another
> implementation. I've just lost hope in this approach.
>
> What I'm suggesting in this RFC is to forget controversial
> QOM approach for now and use -device/device_add + QMP introspection,
> i.e. completely split interface from how boards internally implement
> CPU hotplug.
QMP introspection doesn't tell you anything about device_add now.
Covering device_add is hard, because introspection data is fixed at
compile-time, but device models are collected only at run time. Worse,
non-qdev QOM properties are buried in code, which you have to run to
find them. See also my slide 39 of my KVM Form 2015 presentation
http://events.linuxfoundation.org/sites/events/files/slides/armbru-qemu-introspection.pdf
But perhaps you means something else.
next prev parent reply other threads:[~2016-02-24 8:53 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-15 17:10 [Qemu-devel] [RFC] QMP: add query-hotpluggable-cpus Igor Mammedov
2016-02-15 17:44 ` Eric Blake
2016-02-16 9:58 ` Igor Mammedov
2016-02-15 19:43 ` Markus Armbruster
2016-02-16 5:48 ` David Gibson
2016-02-16 10:52 ` Igor Mammedov
2016-02-18 4:05 ` David Gibson
2016-02-18 10:55 ` Igor Mammedov
2016-02-24 11:26 ` David Gibson
2016-02-24 13:10 ` Igor Mammedov
2016-02-16 10:36 ` Igor Mammedov
2016-02-16 12:35 ` Markus Armbruster
2016-02-16 12:41 ` Andreas Färber
2016-02-16 12:58 ` Markus Armbruster
2016-02-18 3:52 ` David Gibson
2016-02-18 7:33 ` Markus Armbruster
2016-02-17 20:59 ` Eduardo Habkost
2016-02-18 3:39 ` David Gibson
2016-02-18 10:37 ` Igor Mammedov
2016-02-19 4:38 ` David Gibson
2016-02-19 9:51 ` Markus Armbruster
2016-02-19 16:11 ` Igor Mammedov
2016-02-22 2:32 ` David Gibson
2016-02-22 9:05 ` Markus Armbruster
2016-02-24 1:57 ` David Gibson
2016-02-24 8:42 ` Markus Armbruster
2016-02-24 10:51 ` David Gibson
2016-02-24 11:03 ` Igor Mammedov
2016-02-25 1:03 ` David Gibson
2016-02-25 10:22 ` Igor Mammedov
2016-02-19 15:49 ` Igor Mammedov
2016-02-22 2:54 ` David Gibson
2016-02-23 9:46 ` Igor Mammedov
2016-02-23 21:26 ` Eduardo Habkost
2016-02-24 1:52 ` David Gibson
2016-02-24 14:42 ` Igor Mammedov
2016-02-25 1:05 ` David Gibson
2016-02-25 17:52 ` Eduardo Habkost
2016-02-29 15:42 ` Igor Mammedov
2016-03-01 1:19 ` David Gibson
2016-03-01 10:49 ` Igor Mammedov
2016-03-01 18:17 ` Igor Mammedov
2016-03-01 14:02 ` Eduardo Habkost
2016-02-24 1:54 ` David Gibson
2016-02-24 14:17 ` Igor Mammedov
2016-02-25 1:25 ` David Gibson
2016-02-25 12:43 ` Igor Mammedov
2016-02-26 4:12 ` David Gibson
2016-02-26 10:37 ` Igor Mammedov
2016-02-24 8:53 ` Markus Armbruster [this message]
2016-02-24 11:31 ` Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d1rm1oc2.fsf@blackfin.pond.sub.org \
--to=armbru@redhat.com \
--cc=abologna@redhat.com \
--cc=afaerber@suse.de \
--cc=agraf@suse.de \
--cc=aik@ozlabs.ru \
--cc=bharata@linux.vnet.ibm.com \
--cc=david@gibson.dropbear.id.au \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=pkrempa@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.