From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49230) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aTpfo-0000Uw-Co for qemu-devel@nongnu.org; Thu, 11 Feb 2016 06:44:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aTpfk-0005sK-1x for qemu-devel@nongnu.org; Thu, 11 Feb 2016 06:44:36 -0500 Received: from mail-wm0-x22f.google.com ([2a00:1450:400c:c09::22f]:36305) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aTpfj-0005sG-Oj for qemu-devel@nongnu.org; Thu, 11 Feb 2016 06:44:31 -0500 Received: by mail-wm0-x22f.google.com with SMTP id p63so68973886wmp.1 for ; Thu, 11 Feb 2016 03:44:31 -0800 (PST) References: <1455187265-26631-1-git-send-email-alex.bennee@linaro.org> <1455187265-26631-6-git-send-email-alex.bennee@linaro.org> From: Alex =?utf-8?Q?Benn=C3=A9e?= In-reply-to: <1455187265-26631-6-git-send-email-alex.bennee@linaro.org> Date: Thu, 11 Feb 2016 11:44:29 +0000 Message-ID: <87d1s3bheq.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH v6 5/9] qemu-log: support simple pid substitution in logfile List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: pbonzini@redhat.com, crosthwaitepeter@gmail.com, dgilbert@redhat.com, aurelien@aurel32.net, rth@twiddle.net Alex Bennée writes: > When debugging stuff that occurs over several forks it would be useful > not to keep overwriting the one logfile you've set-up. This allows a > simple %d to be included once in the logfile parameter which is > substituted with getpid(). > > Signed-off-by: Alex Bennée > Reviewed-by: Leandro Dorileo > Reviewed-by: Aurelien Jarno > > --- > v5 > - add another r-b > --- > util/log.c | 17 +++++++++++++++-- > 1 file changed, 15 insertions(+), 2 deletions(-) > > diff --git a/util/log.c b/util/log.c > index c89b226..3988b5d 100644 > --- a/util/log.c > +++ b/util/log.c > @@ -75,11 +75,24 @@ void do_qemu_set_log(int log_flags, bool use_own_buffers) > qemu_log_close(); > } > } > - > +/* > + * Allow the user to include %d in their logfile which will be > + * substituted with the current PID. This is useful for debugging many > + * nested linux-user tasks but will result in lots of logs. > + */ > void qemu_set_log_filename(const char *filename) > { > g_free(logfilename); > - logfilename = g_strdup(filename); > + if (g_strrstr(filename, "%d")) { Just realised I missed the strrstr -> strstr fix. Not that it makes a lot of difference in this case. > + /* if we are going to format this we'd better validate first */ > + if (g_regex_match_simple("^[^%]+%d[^%]+$", filename, 0, 0)) { > + logfilename = g_strdup_printf(filename, getpid()); > + } else { > + g_error("Bad logfile format: %s", filename); > + } > + } else { > + logfilename = g_strdup(filename); > + } > qemu_log_close(); > qemu_set_log(qemu_loglevel); > } -- Alex Bennée